From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F52DC19759 for ; Thu, 1 Aug 2019 13:01:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 551BD20B7C for ; Thu, 1 Aug 2019 13:01:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Lo+cSx+e"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="dmvTMafn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 551BD20B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SE0GR7qr17uGO5U1Gbxn+SBEjFYv4k9LI2aAKvzxpp4=; b=Lo+cSx+eNLXN15 zYGD4FHynSF3wcIZJomkexPw0KavpCxMkcqfxTxO/aF0QxeCYfmczDPB9hfN/rHUtxJ85lILR8rB5 4vNXAZ+JBwlTFu1nL8UiyVQ7nGAHscTjgk940h0o8u26GFJgh2y5PNBIXnvY4CC9KcrfB2bNC6wA1 fAyEDofTve0f9/73WAVCQaXWZte17K3lI1DWvrwXKZjSXGgvLZncxkw0Yq3wgKHQ43T1FEfD3iuOJ dZqMpgudXlT8sd6lZ6MMCeeIy+gfX9qii3OLrDTIwZWGGO55Rc6Xh+yj7XhvOtL1MpozZd/LbTiTg gXMjz8TBGHEw4g1rBGzA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1htAi8-0003Qj-SY; Thu, 01 Aug 2019 13:01:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1htAi3-0003QN-VS for linux-arm-kernel@lists.infradead.org; Thu, 01 Aug 2019 13:01:33 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2A3C320838; Thu, 1 Aug 2019 13:01:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564664491; bh=HG3nrkOsqHLSX0CwQdBhFk28USlDFv5Mq7fZhTnTprU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dmvTMafni34bd7yf1rJvAVkmnzWABTcmbQnd61qYYhfM48ImM37PFXDSMJs5D/257 0pfOVPlT5HbvyHHymc2odA9jsoLEPBZxJSlH2cIfMoaxT+0Re/r6O8n0CE4R2TPl0a PDGDFnb0bo7ljCO7stOUDnmOwity/6yMln35hs7c= Date: Thu, 1 Aug 2019 14:01:26 +0100 From: Will Deacon To: Julien Thierry Subject: Re: [PATCH v4 3/9] arm: perf: save/resore pmsel Message-ID: <20190801130126.xxsot2mabvisq76e@willie-the-truck> References: <1563351432-55652-1-git-send-email-julien.thierry@arm.com> <1563351432-55652-4-git-send-email-julien.thierry@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1563351432-55652-4-git-send-email-julien.thierry@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190801_060132_028016_718EC97C X-CRM114-Status: UNSURE ( 7.67 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, peterz@infradead.org, liwei391@huawei.com, will.deacon@arm.com, Russell King , acme@kernel.org, alexander.shishkin@linux.intel.com, mingo@redhat.com, stable@vger.kernel.org, namhyung@kernel.org, sthotton@marvell.com, jolsa@redhat.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org [typo in subject: resore ->restore] On Wed, Jul 17, 2019 at 09:17:06AM +0100, Julien Thierry wrote: > The callback pmu->read() can be called with interrupts enabled. > Currently, on ARM, this can cause the following callchain: > > armpmu_read() -> armpmu_event_update() -> armv7pmu_read_counter() Why can't we just disable irqs in armv7pmu_read_counter() ? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel