From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8627DC0650F for ; Mon, 5 Aug 2019 10:56:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 580662087B for ; Mon, 5 Aug 2019 10:56:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HKHpavHu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="DvfNSMsq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 580662087B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dd6WjKp03Xy2G9HLmdm4LQPyxVJiIqk8IYoFhjYvLkk=; b=HKHpavHu7Bu7kp rhsjoBdTtcFFAvCTRfgi6teoEeRauDNHtezfXPRPvmSMmPULMzmUX48n388scGxmld7S09pGDem1W xKUUCD7bkqspD+fATrTwoCDlkAPHu89/kG1N0eBxnXbq26NNpejHP8VA1AGdkfPjPTv3foZIny7dZ +tnL+m0GxQRvE6KCa6+GR/SC1X7H8uC7EHyRq2LbYtZW8Qimt/ZK1fm0L1t5na+QiGDqwOhKJFBL7 15h0e9idd8FgduDpx7TpiaB+XaJfOdhrv/aLLS5zf/kJLROwu5z6fJaa2n9NcDpWnbRzI6RPOzmvu Jvn/erfudHKIBavawSIQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1huafe-00071l-RU; Mon, 05 Aug 2019 10:56:54 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1huafb-00071K-6Q for linux-arm-kernel@lists.infradead.org; Mon, 05 Aug 2019 10:56:53 +0000 Received: from pendragon.ideasonboard.com (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E5F032F9; Mon, 5 Aug 2019 12:56:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1565002609; bh=nisUIk5L2tjJD15aLfwBsmDwP/QvwsSaKKmQVHAH03Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DvfNSMsq9Iz0RSwd24A/p89jCmKQ/1WhEHui6UQFf0FmiuolkRgjJT1onBjHZcSvh oflCXD0nj+c/zQiVLayDOq4tm6eIeDOMhUCaJ1X7HVDwJsVexhwYAZeYr20JNNZny7 Fc+8ZcDaBMGp3zyq7PONluW7eDNtNgQbtDMYivjY= Date: Mon, 5 Aug 2019 13:56:47 +0300 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH v1 13/16] drm/panel: drop return code from drm_panel_detach() Message-ID: <20190805105647.GH29747@pendragon.ideasonboard.com> References: <20190804201637.1240-1-sam@ravnborg.org> <20190804201637.1240-14-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190804201637.1240-14-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190805_035651_533055_B1546F00 X-CRM114-Status: GOOD ( 22.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Linus Walleij , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Benjamin Gaignard , Fabio Estevam , Marek Vasut , Laurent Pinchart , Joonyoung Shim , Vincent Abriou , Krzysztof Kozlowski , Jonathan Hunter , Maxime Ripard , Kukjin Kim , linux-arm-kernel@lists.infradead.org, Philipp Zabel , NXP Linux Team , Pengutronix Kernel Team , Jonas Karlman , Sascha Hauer , Alison Wang , Maarten Lankhorst , Gwan-gyeong Mun , Inki Dae , Alexios Zavras , linux-samsung-soc@vger.kernel.org, Stefan Agner , linux-tegra@vger.kernel.org, Thomas Gleixner , Sean Paul , Allison Randal , Jernej Skrabec , Shawn Guo , Seung-Woo Kim , Kyungmin Park , Daniel Vetter , Enrico Weigelt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sam, Thank you for the patch. On Sun, Aug 04, 2019 at 10:16:34PM +0200, Sam Ravnborg wrote: > There are no errors that can be reported by this function, > so drop the return code. > Fix the only bridge driver that checked the return result. > > Signed-off-by: Sam Ravnborg > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: Laurent Pinchart > Cc: Andrzej Hajda > Cc: Gwan-gyeong Mun > Cc: Thomas Gleixner > Cc: Linus Walleij Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 3 +-- > drivers/gpu/drm/drm_panel.c | 6 +----- > include/drm/drm_panel.h | 2 +- > 3 files changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > index f2f7f69d6cc3..22885dceaa17 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -1780,8 +1780,7 @@ void analogix_dp_unbind(struct analogix_dp_device *dp) > if (dp->plat_data->panel) { > if (drm_panel_unprepare(dp->plat_data->panel)) > DRM_ERROR("failed to turnoff the panel\n"); > - if (drm_panel_detach(dp->plat_data->panel)) > - DRM_ERROR("failed to detach the panel\n"); > + drm_panel_detach(dp->plat_data->panel); > } > > drm_dp_aux_unregister(&dp->aux); > diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c > index 9946b8d9bacc..da19d5b4a2f4 100644 > --- a/drivers/gpu/drm/drm_panel.c > +++ b/drivers/gpu/drm/drm_panel.c > @@ -219,15 +219,11 @@ EXPORT_SYMBOL(drm_panel_attach); > * > * This function should not be called by the panel device itself. It > * is only for the drm device that called drm_panel_attach(). > - * > - * Return: 0 on success or a negative error code on failure. > */ > -int drm_panel_detach(struct drm_panel *panel) > +void drm_panel_detach(struct drm_panel *panel) > { > panel->connector = NULL; > panel->drm = NULL; > - > - return 0; > } > EXPORT_SYMBOL(drm_panel_detach); > > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h > index 5e62deea49ba..624bd15ecfab 100644 > --- a/include/drm/drm_panel.h > +++ b/include/drm/drm_panel.h > @@ -153,7 +153,7 @@ int drm_panel_add(struct drm_panel *panel); > void drm_panel_remove(struct drm_panel *panel); > > int drm_panel_attach(struct drm_panel *panel, struct drm_connector *connector); > -int drm_panel_detach(struct drm_panel *panel); > +void drm_panel_detach(struct drm_panel *panel); > > int drm_panel_prepare(struct drm_panel *panel); > int drm_panel_unprepare(struct drm_panel *panel); -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel