From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44ADEC0650F for ; Thu, 8 Aug 2019 16:57:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1804A2173C for ; Thu, 8 Aug 2019 16:57:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iWFWk7ms" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1804A2173C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UDMWvLhr2V2PaRYEiR/l/2wRWPB/Nmbgdhz+RjvQaao=; b=iWFWk7ms8VY5c+ QKEy0bqFZFKZ8SSNdIkvXsU53MSTBC/tPgmk7ADa3docWTlsNLZaY5uL3NmARB+M1MOE9SmdAm3mW QWExFqIA5wKpzcNILdRUPiLfvZN/lpJjULfKjk+NSEQuJXPrvLerg5vJv4L6PgRVMMArZBIFgqsqA ldWPDpqgJ9wr3RDVsgjshvPmORIBZbARkyM+EhgZxYNok6u8NmTi7Fsd/vqJQ9NvtniVh30zx/md5 M6ce5D6Tr4uv/90bw5Q0vFMPeVjPzjNocISehFMsEji2tcFVi4IhtdV+BmS5vDlMnssa2mfdmvk53 L4Q7qIg0cAcFYW4Cu28w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvlix-0006oA-Ev; Thu, 08 Aug 2019 16:57:11 +0000 Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvlit-0006nZ-Al; Thu, 08 Aug 2019 16:57:10 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 09:57:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,362,1559545200"; d="scan'208";a="179895442" Received: from okartau-mobl.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.252.35.161]) by orsmga006.jf.intel.com with ESMTP; 08 Aug 2019 09:57:00 -0700 Received: by kekkonen.fi.intel.com (Postfix, from userid 1000) id 0E0F721F8E; Thu, 8 Aug 2019 19:54:16 +0300 (EEST) Date: Thu, 8 Aug 2019 19:54:16 +0300 From: Sakari Ailus To: dongchun.zhu@mediatek.com Subject: Re: [V1, 1/2] media: dt-bindings: media: i2c: Add bindings for ov8856 Message-ID: <20190808165416.GA1845@kekkonen.localdomain> References: <20190808092215.5608-1-dongchun.zhu@mediatek.com> <20190808092215.5608-2-dongchun.zhu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190808092215.5608-2-dongchun.zhu@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190808_095707_388076_200C6334 X-CRM114-Status: GOOD ( 17.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, drinkcat@chromium.org, srv_heupstream@mediatek.com, shengnan.wang@mediatek.com, Ben Kao , tfiga@chromium.org, louis.kuo@mediatek.com, sj.huang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, bingbu.cao@intel.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dongchun, (Cc'ing Ben, too.) On Thu, Aug 08, 2019 at 05:22:14PM +0800, dongchun.zhu@mediatek.com wrote: > From: Dongchun Zhu > > Add device tree binding documentation for the ov8856 camera sensor. > > Signed-off-by: Dongchun Zhu > --- > .../devicetree/bindings/media/i2c/ov8856.txt | 41 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8856.txt > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.txt b/Documentation/devicetree/bindings/media/i2c/ov8856.txt > new file mode 100644 > index 0000000..96b10e0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.txt > @@ -0,0 +1,41 @@ > +* Omnivision OV8856 MIPI CSI-2 sensor > + > +Required Properties: > +- compatible: shall be "ovti,ov8856" > +- clocks: reference to the xvclk input clock > +- clock-names: shall be "xvclk" Could you add "clock-frequency" property here, please, and specify the upper and lower limits? > +- avdd-supply: Analog voltage supply, 2.8 volts > +- dovdd-supply: Digital I/O voltage supply, 1.8 volts > +- dvdd-supply: Digital core voltage supply, 1.2 volts > +- reset-gpios: Low active reset gpio > + > +The device node shall contain one 'port' child node with an > +'endpoint' subnode for its digital output video port, > +in accordance with the video interface bindings defined in > +Documentation/devicetree/bindings/media/video-interfaces.txt. > +The endpoint optional property 'data-lanes' shall be "<0 1 3 4>". If you don't support lane reordering, then monotonically incrementing lane numbers from 1 onwards are recommended. Please also make the property mandatory. > + > +Example: > +&i2c7 { > + ov8856: camera-sensor@10 { > + compatible = "ovti,ov8856"; > + reg = <0x10>; > + pinctrl-names = "default"; > + pinctrl-0 = <&clk_24m_cam>; > + > + clocks = <&cru SCLK_TESTCLKOUT1>; > + clock-names = "xvclk"; > + > + avdd-supply = <&mt6358_vcama2_reg>; > + dvdd-supply = <&mt6358_vcamd_reg>; > + dovdd-supply = <&mt6358_vcamio_reg>; > + reset-gpios = <&gpio2 3 GPIO_ACTIVE_LOW>; > + > + port { > + wcam_out: endpoint { > + remote-endpoint = <&mipi_in_wcam>; > + data-lanes = <0 1 3 4>; > + }; > + }; > + }; > +}; > diff --git a/MAINTAINERS b/MAINTAINERS > index 783569e..7746c6b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11889,6 +11889,7 @@ L: linux-media@vger.kernel.org > T: git git://linuxtv.org/media_tree.git > S: Maintained > F: drivers/media/i2c/ov8856.c > +F: Documentation/devicetree/bindings/media/i2c/ov8856.txt > > OMNIVISION OV9650 SENSOR DRIVER > M: Sakari Ailus -- Regards, Sakari Ailus sakari.ailus@linux.intel.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel