From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21A17C32756 for ; Fri, 9 Aug 2019 09:53:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC0DB2166E for ; Fri, 9 Aug 2019 09:53:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VbC6UTsk"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="mAW5usvY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC0DB2166E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ddDx2cWCdno1n+E/XeewU8eGINc8luKrjJxwpI/cPaA=; b=VbC6UTsk5GmvAz A8P05JcXSDPdml9vPpAsQG6BUoA0vX4w/4yRRVk+6kP93xb2ziCS8kOOUW/ynbSMFIRp8TBKhSv7g p1WRdXo3/FD2rTSRVjSfy8F+uDIT9BYf4a+32yqRy7gPwCQECHUxtbLhVBpTqECHT419qcdHy3V2j 6B2Z9uFIXr28kjJ34zI1NDE93Eueco8T4YrkQ1C+VI2QYgQbxVOyld+iopnUK4507YLxQhJ2Ssx7E fUAaeuUs/Vr7o+hZRrnbPPHja970SGQUf+ZbRzUPe3Yl+HhA6j1tSM/9XTLMVLQ1xNzsIqPRHt8C5 f9xgs9Z7KySI9PfVZpYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hw1al-00075m-9W; Fri, 09 Aug 2019 09:53:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hw1ai-00075E-GI for linux-arm-kernel@lists.infradead.org; Fri, 09 Aug 2019 09:53:45 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 815C82171F; Fri, 9 Aug 2019 09:53:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565344424; bh=HvIMRzJAD8xKVNar+I0poiTdap6cuZjybn8Cb39/S4A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mAW5usvY5TRTwNwiyb9HbLqnttY7Fl181BMCrvMtghPMrPW3HXe/FUImhq15iYn+R Fy0fDCyZCSZqFB9kERdFKnUn41T527BTUSDqT89jqc5LukkdNqmwjulPAd8DZKyhu6 eTjpDwZA0xMwsF4/pd+QBlSjd51QxUOAeObojS5I= Date: Fri, 9 Aug 2019 10:53:38 +0100 From: Will Deacon To: Stefan-gabriel Mirea Subject: Re: [PATCH 5/6] tty: serial: Add linflexuart driver for S32V234 Message-ID: <20190809095338.d73fomq424gayf2b@willie-the-truck> References: <20190802194702.30249-1-stefan-gabriel.mirea@nxp.com> <20190802194702.30249-6-stefan-gabriel.mirea@nxp.com> <20190808080832.nleult5bknmzr3ze@willie-the-truck> <20190808171711.nk7ljqkugtketu4q@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190809_025344_585814_7E422BB7 X-CRM114-Status: GOOD ( 18.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "corbet@lwn.net" , "gregkh@linuxfoundation.org" , "jslaby@suse.com" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Leo Li , Cosmin Stefan Stoica , "robh+dt@kernel.org" , "linux-serial@vger.kernel.org" , "catalin.marinas@arm.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , Larisa Ileana Grigore Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 09, 2019 at 09:45:40AM +0000, Stefan-gabriel Mirea wrote: > On 8/8/2019 8:17 PM, Will Deacon wrote: > > On Thu, Aug 08, 2019 at 12:47:00PM +0000, Stefan-gabriel Mirea wrote: > >> On 8/8/2019 11:08 AM, Will Deacon wrote: > >>> On Fri, Aug 02, 2019 at 07:47:23PM +0000, Stefan-gabriel Mirea wrote: > >>>> + linflex, > >>>> + Use early console provided by Freescale LinFlex UART > >>>> + serial driver for NXP S32V234 SoCs. A valid base > >>>> + address must be provided, and the serial port must > >>>> + already be setup and configured. > >>> > >>> Why isn't earlycon= sufficient for this? > >> > >> "earlycon=" is not actually supported. I will fix this in the next > >> version by adding a /chosen/stdout-path to the dts. The compatible > >> string provided to OF_EARLYCON_DECLARE will also be changed from > >> "fsl,s32v234-linflexuart" to "fsl,s32-linflexuart" to match the one in > >> the device tree nodes. I missed this after importing a rename from our > >> codebase. > >> > >> Should I remove this addition from kernel-parameters.txt after that? > > > > Yes, if you can use earlycon instead, then you can drop your custom option > > entirely and therefore there's no need to document it either. > > Can you please clarify what you mean by "drop your custom option"? The > "linflex" option documented in the paragraph is the name of the > earlycon_id declared via "OF_EARLYCON_DECLARE(linflex, ...)". We have > not done anything particular to accept it in the parameter value. My apologies, I completely misread your patch and thought your were adding a *new* kernel parameter. Having looked at the context, I now see you're adding a new earlycon option, which is what I was suggesting :) By all means, please update the stdout-path, because then you can just pass "earlycon" and things will work as expected. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel