From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28203C32750 for ; Tue, 13 Aug 2019 12:00:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1FA720679 for ; Tue, 13 Aug 2019 12:00:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EvAmRIaS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1FA720679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PRJhDm+GFPexITyjx6RAI/DwXbKNOxWDdNY8NUF3VVY=; b=EvAmRIaSA22yco Amt79VBTfTZ8WEigFMaZnbjxojHbv3sWqcbM6VFH0g56JFeeBwYZkwrYxcHSlAh9dQUgCC2P7B/5Y bdGaET39TFyRQ7LXNAfkM4bnSiNA8Z1DztXC8y0AppiosZEtW7UG171u9J4SJtgXD+pAuhzas4sDY mCCaZHbcr/jXwZvoNfmonFpV/neze7pkDWYYWQ54258/iuU/uU6XuTWzU4MaA/5yWZOS/l9a0kEx/ m3FTrVzZ3MnoT96gY5KVT8z2XDwZH4TnXSgFBo0/iqbad0WBLuhviqGGe9dXK9VYUfqE/+6DrQd1l 6iWNukDcMGOiqRwfLDjg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxVU0-0005Tw-Fq; Tue, 13 Aug 2019 12:00:56 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxVTx-0005TF-Ca for linux-arm-kernel@lists.infradead.org; Tue, 13 Aug 2019 12:00:54 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 1F4BB805C; Tue, 13 Aug 2019 12:01:20 +0000 (UTC) Date: Tue, 13 Aug 2019 05:00:49 -0700 From: Tony Lindgren To: Kees Cook Subject: Re: [PATCH] ARM: OMAP: dma: Mark expected switch fall-throughs Message-ID: <20190813120049.GV52127@atomide.com> References: <20190728232240.GA22393@embeddedor> <201907290934.B2053972E3@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201907290934.B2053972E3@keescook> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190813_050053_462051_A699786F X-CRM114-Status: UNSURE ( 9.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Rothwell , Aaro Koskinen , "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Kees Cook [190729 16:35]: > On Sun, Jul 28, 2019 at 06:22:40PM -0500, Gustavo A. R. Silva wrote: > > Mark switch cases where we are expecting to fall through. > > > > This patch fixes the following warnings: > > > > arch/arm/plat-omap/dma.c: In function 'omap_set_dma_src_burst_mode': > > arch/arm/plat-omap/dma.c:384:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > > if (dma_omap2plus()) { > > ^ > > arch/arm/plat-omap/dma.c:393:2: note: here > > case OMAP_DMA_DATA_BURST_16: > > ^~~~ > > arch/arm/plat-omap/dma.c:394:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > > if (dma_omap2plus()) { > > ^ > > arch/arm/plat-omap/dma.c:402:2: note: here > > default: > > ^~~~~~~ > > arch/arm/plat-omap/dma.c: In function 'omap_set_dma_dest_burst_mode': > > arch/arm/plat-omap/dma.c:473:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > > if (dma_omap2plus()) { > > ^ > > arch/arm/plat-omap/dma.c:481:2: note: here > > default: > > ^~~~~~~ > > > > Notice that, in this particular case, the code comment is > > modified in accordance with what GCC is expecting to find. > > > > Reported-by: Stephen Rothwell > > Signed-off-by: Gustavo A. R. Silva > > Reviewed-by: Kees Cook Applying into fixes thanks. Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel