From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1B71C433FF for ; Tue, 13 Aug 2019 18:12:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8B4C20665 for ; Tue, 13 Aug 2019 18:12:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DfoKyrcG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8B4C20665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=iki.fi Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HI5q/Q67C+YAKq6S5a68JXlgXLaPXVwExmS4w2dA9HY=; b=DfoKyrcGhF6dTb DXAJG5ET4xWfxOT6c5iwuKKFp7aTZ8OmGTEY6ifu1Gg3wpuDEWV2EzyCpsD1R5vpw83pP+LZU5oTu duUbP5EAZ9BJBNKQDs8ifNP5/w3iSlVplapsLDwGdIMmHhJ6rwHnwy7tMwGyyAKs7MljZfgzoCix9 Yvfm8ob1ww4cbPEuVuppV1eY3BaTX5G5jSZrDBgX5tr1uBSP8PZ7Bz8qdo4zw7/cQDZ9AEBhtWYAq tCveyeW0w5knH2NM6TeMR1gbFb5069yb77ZnOQUEombzCGHkGxb9/Z3F7ZlRNVQ3617K8uD+SnBLG q3cEndohcpyHvam1+APQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxbHH-0003bm-Iz; Tue, 13 Aug 2019 18:12:11 +0000 Received: from emh06.mail.saunalahti.fi ([62.142.5.116]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hxbHC-0003bH-L2 for linux-arm-kernel@lists.infradead.org; Tue, 13 Aug 2019 18:12:09 +0000 Received: from darkstar.musicnaut.iki.fi (85-76-96-82-nat.elisa-mobile.fi [85.76.96.82]) by emh06.mail.saunalahti.fi (Postfix) with ESMTP id 3918430016; Tue, 13 Aug 2019 21:11:59 +0300 (EEST) Date: Tue, 13 Aug 2019 21:11:58 +0300 From: Aaro Koskinen To: Arnd Bergmann Subject: Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf Message-ID: <20190813181158.GA26798@darkstar.musicnaut.iki.fi> References: <20190808212234.2213262-1-arnd@arndb.de> <20190808212234.2213262-15-arnd@arndb.de> <20190813103605.GL52127@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190813_111207_028116_01A94950 X-CRM114-Status: GOOD ( 18.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartlomiej Zolnierkiewicz , Tony Lindgren , Greg Kroah-Hartman , Linus Walleij , Linux Kernel Mailing List , Dominik Brodowski , Tomi Valkeinen , linux-omap , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Tue, Aug 13, 2019 at 01:02:16PM +0200, Arnd Bergmann wrote: > On Tue, Aug 13, 2019 at 12:36 PM Tony Lindgren wrote: > > * Arnd Bergmann [190808 21:34]: > > > The ISA I/O space handling in omap_cf is incompatible with > > > PCI drivers in a multiplatform kernel, and requires a custom > > > mach/io.h. > > > > > > Change the driver to use pci_ioremap_io() like PCI drivers do, > > > so the generic ioport access can work across platforms. > > > > > > To actually use that code, we have to select CONFIG_PCI > > > here. > > > > > > Signed-off-by: Arnd Bergmann > > > > Looks like this series boots for me on 5912osk up to this > > patch > > Ok, that's something. Thanks for testing! > > >, but this patch breaks booting somehow. > > > > Any ideas for fixes? > > I can think of multiple possible issues: > > - I force CONFIG_PCI to be enabled here in order to keep the > asm/io.h logic unchanged. If PCI support in itself is an issue, > then turning on CONFIG_PCI without the rest of this patch > should also break. The board dies early, probably in pci_reserve_io(): Starting kernel ... [ 0.000000] Booting Linux on physical CPU 0x0 [ 0.000000] Linux version 5.3.0-rc4-osk-los_80efa+-00028-g09f6f22a63e9 (aaro@amd-fx-6350) (gcc version 8.3.0 (GCC)) #1 Tue Aug 13 20:50:11 EEST 2019 [ 0.000000] CPU: ARM926EJ-S [41069263] revision 3 (ARMv5TEJ), cr=0005317f [ 0.000000] CPU: VIVT data cache, VIVT instruction cache [ 0.000000] Machine: TI-OSK [ 0.000000] Ignoring tag cmdline (using the default kernel command line) [ 0.000000] printk: bootconsole [earlycon0] enabled [ 0.000000] Memory policy: Data cache writeback [ 0.000000] Internal error: Oops - undefined instruction: 0 [#1] ARM [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 5.3.0-rc4-osk-los_80efa+-00028-g09f6f22a63e9 #1 [ 0.000000] Hardware name: TI-OSK [ 0.000000] PC is at vm_area_add_early+0x1c/0x74 [ 0.000000] LR is at 0x200000 [ 0.000000] pc : [] lr : [<00200000>] psr: 800000d3 [ 0.000000] sp : c05b5f14 ip : ff000000 fp : c05bad68 [ 0.000000] r10: fefb0000 r9 : ffe00000 r8 : 001fffff [ 0.000000] r7 : c05bad88 r6 : c05db3d4 r5 : c05ca678 r4 : c1ffcf60 [ 0.000000] r3 : c1ffcfd8 r2 : c1ffcfb0 r1 : fefb0000 r0 : c1ffcf60 [ 0.000000] Flags: Nzcv IRQs off FIQs off Mode SVC_32 ISA ARM Segment none [ 0.000000] Control: 0005317f Table: 10004000 DAC: 00000053 [ 0.000000] Process swapper (pid: 0, stack limit = 0x(ptrval)) [ 0.000000] Stack: (0xc05b5f14 to 0xc05b6000) [ 0.000000] 5f00: c0411724 ff000000 c041260c [ 0.000000] 5f20: 00010000 00010600 c0428794 c05b7008 c042b000 00600000 00000000 ffff1000 [ 0.000000] 5f40: 00011fff 00001000 00000007 00000000 00000000 c0428794 c0008000 c060ba7c [ 0.000000] 5f60: c0429a38 c05b5fc4 c05ca818 00053177 00000001 c04101fc 0000006c 0005317f [ 0.000000] 5f80: 00000000 00000000 00000053 00003135 c05b7008 c05b7000 41069263 00053177 [ 0.000000] 5fa0: 00000001 c040da10 00000000 00000000 00000000 00000000 00000000 00000000 [ 0.000000] 5fc0: 00000000 c0429a38 00000000 00000000 00000000 c040d330 00000053 00003135 [ 0.000000] 5fe0: 00000203 10000100 41069263 00053177 00000000 00000000 00000000 00000000 [ 0.000000] [] (vm_area_add_early) from [] (add_static_vm_early+0xc/0x5c) [ 0.000000] [] (add_static_vm_early) from [] (paging_init+0x2e0/0x5b4) [ 0.000000] [] (paging_init) from [] (setup_arch+0x4c8/0x7cc) [ 0.000000] [] (setup_arch) from [] (start_kernel+0x58/0x478) [ 0.000000] [] (start_kernel) from [<00000000>] (0x0) [ 0.000000] Code: e3530000 059f2058 05923000 0a000006 (e7f001f2) [ 0.000000] random: get_random_bytes called from init_oops_id+0x20/0x3c with crng_init=0 [ 0.000000] ---[ end trace 0000000000000000 ]--- [ 0.000000] Kernel panic - not syncing: Attempted to kill the idle task! [ 0.000000] ---[ end Kernel panic - not syncing: Attempted to kill the idle task! ]--- A. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel