From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 975C5C433FF for ; Wed, 14 Aug 2019 09:11:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6879A2084F for ; Wed, 14 Aug 2019 09:11:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DaZRUO9v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6879A2084F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/V8cTtA7orR/uhxfJET+a260zx+X/WHPAn06IMO42lE=; b=DaZRUO9vCF5Rfz 71a8MZ5JFkJjJm1u8Mr9aam4LqvjXsmgdYrFkq+RY1TMK55wC4K7vGyX/EmfO/rp3VHP1Cym6Oauo 8obP+iTEtOvHTll8YKEOFrxLtvjjDqxXQxOu0WIzbvE6BkSDaaJ6M9TBomT9v+zk8lDjJxj3/etKC p/qYRFzI9j+XQjaQH6xn+LN+nAlrC1NrlI9LApRjCs7xV4nxek7WYkMBClddMr0LKy7eiMMLRuFCP dDOEZJjs6cov35iXyF/vL158DcX021NJZ8OPgAhH88JrjcsW8RqkBu25LK5QB0tW9AphJFwrAWZjc ehxHYWBYzK4W/uIxQUVg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxpJ1-00052L-Jn; Wed, 14 Aug 2019 09:10:55 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxpIy-00051k-5Y for linux-arm-kernel@lists.infradead.org; Wed, 14 Aug 2019 09:10:53 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8ABDE344; Wed, 14 Aug 2019 02:10:51 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D84723F694; Wed, 14 Aug 2019 02:10:50 -0700 (PDT) Date: Wed, 14 Aug 2019 10:10:48 +0100 From: Dave Martin To: Mark Rutland Subject: Re: [PATCH 2/3] arm64: constify aarch64_insn_encoding_class[] Message-ID: <20190814091048.GL10425@arm.com> References: <20190813141639.13476-1-mark.rutland@arm.com> <20190813141639.13476-3-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190813141639.13476-3-mark.rutland@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190814_021052_255487_9860C455 X-CRM114-Status: GOOD ( 14.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, will.deacon@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 13, 2019 at 03:16:38PM +0100, Mark Rutland wrote: > The aarch64_insn_encoding_class[] array contains compile-time constant > data, and is never intentionally modified, so let's mark it as const. > > Signed-off-by: Mark Rutland > Cc: Catalin Marinas > Cc: Will Deacon > --- > arch/arm64/kernel/insn.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c > index 84b059ed04fc..d801a7094076 100644 > --- a/arch/arm64/kernel/insn.c > +++ b/arch/arm64/kernel/insn.c > @@ -26,7 +26,7 @@ > #define AARCH64_INSN_N_BIT BIT(22) > #define AARCH64_INSN_LSL_12 BIT(22) > > -static int aarch64_insn_encoding_class[] = { > +static const int aarch64_insn_encoding_class[] = { > AARCH64_INSN_CLS_UNKNOWN, > AARCH64_INSN_CLS_UNKNOWN, > AARCH64_INSN_CLS_UNKNOWN, This is an implementation detail of aarch64_get_insn_class(), so it could be moved inside there, or rewritten as a switch. It works as-is though. Either way, Reviewed-by: Dave Martin Cheers ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel