From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6298CC32753 for ; Wed, 14 Aug 2019 13:40:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32D6A206C2 for ; Wed, 14 Aug 2019 13:40:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="T4/vBRm6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32D6A206C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jagRs8cKm4cVqqQcDHxxx8+/TNwGU0Y4Z+LtJ8FHsLk=; b=T4/vBRm668ONWk 3t6W4Wv1g0ZHp8HL0A4x+bbrA07LhQI+bPSKTpFbtYqycN8WVGPBgKFsAPK9UhLXKo6ZTLh88rP3V 1KqxAPqplEFYU1xs3ppuQbwTyBPC/DlnXMldYIzvEDU4wxgxrhx71qdtUz7wU5PoXEThP0f/ZEUmN uH6n7hOiL8MogQncToSfCkBOFblAaMQC8Xo0y8auWW3OqsgWN3pWarkyAXV+ZaudzGo7riuHzTAZA RqRj+a1bAMnsLsygxKNMibMFpKEVAQZSuT8W2VFYU1HmwPvKojckuimmp1QCY+BgWA9+CSUTG/yc9 lf89RNsvdXm49WmWQGdA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxtVd-0001tj-NZ; Wed, 14 Aug 2019 13:40:13 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxtVb-0001tI-5F for linux-arm-kernel@lists.infradead.org; Wed, 14 Aug 2019 13:40:12 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D37C680C8; Wed, 14 Aug 2019 13:40:36 +0000 (UTC) Date: Wed, 14 Aug 2019 06:40:06 -0700 From: Tony Lindgren To: Arnd Bergmann Subject: Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf Message-ID: <20190814134006.GE52127@atomide.com> References: <20190808212234.2213262-1-arnd@arndb.de> <20190808212234.2213262-15-arnd@arndb.de> <20190813103605.GL52127@atomide.com> <20190813181158.GA26798@darkstar.musicnaut.iki.fi> <20190814074918.GA52127@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190814_064011_243816_26BD287D X-CRM114-Status: GOOD ( 15.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aaro Koskinen , Greg Kroah-Hartman , Linus Walleij , Bartlomiej Zolnierkiewicz , Linux Kernel Mailing List , Dominik Brodowski , Tomi Valkeinen , linux-omap , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Arnd Bergmann [190814 10:37]: > On Wed, Aug 14, 2019 at 9:49 AM Tony Lindgren wrote: > > * Arnd Bergmann [190813 19:34]: > > > On Tue, Aug 13, 2019 at 8:12 PM Aaro Koskinen wrote: > > > diff --git a/arch/arm/mach-omap1/hardware.h b/arch/arm/mach-omap1/hardware.h > > > index 232b8deef907..9fc76a3c9e57 100644 > > > --- a/arch/arm/mach-omap1/hardware.h > > > +++ b/arch/arm/mach-omap1/hardware.h > > > @@ -61,7 +61,7 @@ static inline u32 omap_cs3_phys(void) > > > > > > #endif /* ifndef __ASSEMBLER__ */ > > > > > > -#define OMAP1_IO_OFFSET 0x01000000 /* Virtual IO > > > = 0xfefb0000 */ > > > +#define OMAP1_IO_OFFSET 0x00fb0000 /* Virtual IO > > > = 0xff000000 */ > > > #define OMAP1_IO_ADDRESS(pa) IOMEM((pa) - OMAP1_IO_OFFSET) > > > > > > #include "serial.h" > > > > Oh OK yeah sounds like that's the issue. > > > > > There may be additional locations that hardcode the virtual address. > > > > Those should be in mach-omap1/io.c, and I recall innovator had some > > hardcoded fpga address that should also be checked. > > I see four boards with hardcoded I/O addresses, but they are all below > the PCI I/O virtual address range, and are not affected by that change. > > For the innovator FPGA access, this was ok, it uses the correct address > in the OMAP1_IO_OFFSET range. OK thanks for checking. I tried to apply your virtual address patch to test boot it, but could not get it to apply. What tree is it against? Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel