From: Steve Capper <Steve.Capper@arm.com>
To: Mark Rutland <Mark.Rutland@arm.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>, nd <nd@arm.com>,
"will@kernel.org" <will@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] arm64: memory: rename VA_START to PAGE_END
Date: Wed, 14 Aug 2019 14:51:21 +0000 [thread overview]
Message-ID: <20190814145119.GA3646@capper-ampere.manchester.arm.com> (raw)
In-Reply-To: <20190814132848.24295-3-mark.rutland@arm.com>
On Wed, Aug 14, 2019 at 02:28:48PM +0100, Mark Rutland wrote:
> Prior to commit:
>
> 14c127c957c1c607 ("arm64: mm: Flip kernel VA space")
>
> ... VA_START described the start of the TTBR1 address space for a given
> VA size described by VA_BITS, where all kernel mappings began.
>
> Since that commit, VA_START described a portion midway through the
> address space, where the linear map ends and other kernel mappings
> begin.
>
> To avoid confusion, let's rename VA_START to PAGE_END, making it clear
> that it's not the start of the TTBR1 address space and implying that
> it's related to PAGE_OFFSET. Comments and other mnemonics are updated
> accordingly, along with a typo fix in the decription of VMEMMAP_SIZE.
>
> There should be no functional change as a result of this patch.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Steve Capper <steve.capper@arm.com>
> Cc: Will Deacon <will@kernel.org>
This looks a lot better, and avoids future use of "VA_START", thanks Mark!
Reviewed-by: Steve Capper <steve.capper@arm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-14 14:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 13:28 [PATCH 0/2] arm64: memory: VA_START fixups Mark Rutland
2019-08-14 13:28 ` [PATCH 1/2] arm64: memory: fix flipped VA space fallout Mark Rutland
2019-08-14 14:51 ` Steve Capper
2019-08-14 13:28 ` [PATCH 2/2] arm64: memory: rename VA_START to PAGE_END Mark Rutland
2019-08-14 14:51 ` Steve Capper [this message]
2019-08-14 14:51 ` [PATCH 0/2] arm64: memory: VA_START fixups Steve Capper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814145119.GA3646@capper-ampere.manchester.arm.com \
--to=steve.capper@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nd@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).