From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47584C433FF for ; Wed, 14 Aug 2019 17:27:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0133216F4 for ; Wed, 14 Aug 2019 17:27:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KdpygM+C"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="S4LZ0ZhI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0133216F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oXNJcyyb06L3KSFBepLLWMdUY8oTIB5v+qMgt24uNGk=; b=KdpygM+C1AZhTH 4R/0zc/b2z0fjOcn/U2fYlagReB05ZWchiJ9pr/wNwB3alYZmWJvjLD6QnWSSfnv6Btdj6c+vu/T/ vFgSuE8hBbjeHF6b3E+WtubsO8OaMdCFGD/4M44As/aALxTaPxJro0euxXbCJjvulTceXHAyHGqfE OYYIYqfB5GqOkpA7JPQn2yl80rEzqzOwmaiKnqh3K06DhU6Q1kSXOTiLO6f8hXzLAM617SjfFJACZ E/pssVXXMKsUqmDjVomrczU07g9UsCASsf8skbkSn7H5XPL74X+z1stx64C0XhpkwoAGHBbjSdmKw cbQ5oqGBcdPxqa7rKDgw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxx3g-0003aG-Bp; Wed, 14 Aug 2019 17:27:36 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hxx3c-0003TR-3e for linux-arm-kernel@lists.infradead.org; Wed, 14 Aug 2019 17:27:33 +0000 Received: by mail-ed1-x541.google.com with SMTP id r12so7750526edo.5 for ; Wed, 14 Aug 2019 10:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+2YJRbop7obhJvx6M/oXULPH/J+nom3HFlj8fZHLgck=; b=S4LZ0ZhIFTLmy+dmmZbaLaOg0YS4AVm25WTeqTC5q04TLFmuKXix6ea6GroX69AccQ TVsyDYKimeexBM+zMbTI7uThBz1wKxoZ2LA/DsPjtLnCxTpInBlf253wnioU/rbc30kx lxmEzhEsWTICGjuh7wAQdG5twlk69J1nGF1g0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=+2YJRbop7obhJvx6M/oXULPH/J+nom3HFlj8fZHLgck=; b=KT7gn6Deht0gkrGXrpyoVZKljdZljCX69PKS0WqEaP6IEmIxME1NmAoAVdXdaWxfSp WsDwgQp9dV9u9jq1thdnQm7SSPbrQJdC6i1LuqpIqIcpNAbFPsFhGpMhyHXtI1pv1tu6 sqKI7SvF3E/8yXpunUgque4FzkRpRWXpLzc7oEUo9JlME4a0jfCDjHOzBGBqgJpnZji6 G1OAzVetS0kRs4sfzdqIcgWSjG45kr5NDf1RhFXMOqe8ksvg8c68jYDRv29pXj5p0jfk bpWy1qCpOswrYlkL9ri/PjUsU6Nbum4yxrl6nBpfNFKcYEhpOLC1R1v/QtDnIgcgqwNm NcJA== X-Gm-Message-State: APjAAAVrOqEdXp/Kf8jDBu8S8kEYknFd5YZUGfjU7PPVhRJqjasLDY8/ uqGUMrLMZB5HshqpfVDJaxSEdw== X-Google-Smtp-Source: APXvYqxDenh8FqJ/E7jAQeR7LkcaMiSGhd2axDUeDfcgpFNQ91SfeEo1ZCMhZXrO8haciNGMe7XFWQ== X-Received: by 2002:a50:ed94:: with SMTP id h20mr814730edr.59.1565803650087; Wed, 14 Aug 2019 10:27:30 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id f6sm72806edk.79.2019.08.14.10.27.29 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 14 Aug 2019 10:27:29 -0700 (PDT) Date: Wed, 14 Aug 2019 19:27:27 +0200 From: Daniel Vetter To: Nishka Dasgupta Subject: Re: [PATCH] drm/aspeed: gfc_crtc: Make structure aspeed_gfx_funcs constant Message-ID: <20190814172727.GQ7444@phenom.ffwll.local> References: <20190813063355.25549-1-nishkadg.linux@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190813063355.25549-1-nishkadg.linux@gmail.com> X-Operating-System: Linux phenom 4.19.0-5-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190814_102732_204005_D409B52F X-CRM114-Status: GOOD ( 15.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, andrew@aj.id.au, joel@jms.id.au, daniel@ffwll.ch, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 13, 2019 at 12:03:55PM +0530, Nishka Dasgupta wrote: > The static structure aspeed_gfx_funcs, of type > drm_simple_display_pipe_funcs, is used only as an argument to > drm_simple_display_pipe_init(), which does not modify it. Hence make it > constant to protect it from unintended modification. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta Applied, thanks for your patch. > --- > drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c b/drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c > index 15db9e426ec4..2184b8be6fd4 100644 > --- a/drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c > @@ -215,7 +215,7 @@ static void aspeed_gfx_disable_vblank(struct drm_simple_display_pipe *pipe) > writel(reg | CRT_CTRL_VERTICAL_INTR_STS, priv->base + CRT_CTRL1); > } > > -static struct drm_simple_display_pipe_funcs aspeed_gfx_funcs = { > +static const struct drm_simple_display_pipe_funcs aspeed_gfx_funcs = { > .enable = aspeed_gfx_pipe_enable, > .disable = aspeed_gfx_pipe_disable, > .update = aspeed_gfx_pipe_update, > -- > 2.19.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel