From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 531E8C3A59C for ; Fri, 16 Aug 2019 11:57:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AFE721655 for ; Fri, 16 Aug 2019 11:57:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fd7UPGun"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n+RGjsXk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AFE721655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ez6miP1Qh4nP17RKgpSgSscuLZtUkcLeLmgWMSf800w=; b=fd7UPGun2Vh2bc VdGozL8qlNHT8EAw2NbxI/HxzOWiL88YGmc3HIAd3tRa5ifOY4jD1wfVJtnZyaFoRsSX/X2gogVHl wnfBtv1srVB3yqZli6gL/sWMBbTmtghmlZBoXv1Y/i0LRiunCDoQD6ywG6RcZmvvIkMPQh79TSg9l 7cDhbirvVlmCCvozAyWvay5jDqqVPI3MvOf+9d0meyAfd34XK1hESxn75AWOO+O/YJpMQwWtkZvW5 czxrLhxulGp4eXjpmJe5/lqg8ZNR68XSRSDdBlNK+o1tPrNkiiGjGevdUz1cquhzqbq4fGLxe88SH 8SZ8alQ8PKvPOn0bwR/A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hyarl-0002sq-Og; Fri, 16 Aug 2019 11:57:57 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hyari-0002sR-Td for linux-arm-kernel@lists.infradead.org; Fri, 16 Aug 2019 11:57:56 +0000 Received: by mail-wr1-x443.google.com with SMTP id t16so1293224wra.6 for ; Fri, 16 Aug 2019 04:57:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3owt7CIcSpc8cBZykFrs5XYNVBKRHnGIaWwBA3IAOUg=; b=n+RGjsXkn7qujRTwk8aiu8/bBhtBcZVb/be6IIAS5tuj2MIO/85uX4jq+zNdIjO/8t PmrK2Au1oQGF1N7EmhiyitWkXjrebzls+6qiEUcOmAzaYVnolRiZqcmkhkbhhZZI1M1C J/56uGjaQGmHyPBVeOZ5ie9Zb1wmUBMIp7TQCv8twj5jTx7X68e0SfgHJyS63hVsVFUn wgKACA86RZg89Lvt2WsJBOAmV52zl63pbTFpqHn90pZZpyZMmiygdDj4pDfRvU7ExiZz RHzQBU8lfuTBKjOiSJRAzmI2/dNyxNeaJtE0TPFB2WV4XYuM+/jklpHDu7ygWiqKkq3y 0O0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3owt7CIcSpc8cBZykFrs5XYNVBKRHnGIaWwBA3IAOUg=; b=CoGAt+JT1/s7tXbbNCHMzrFy1oYCiFiRz18dttpT3fn901tKOFnBK2l4WYu9pWOm0i fjcbvDcfv6Sa3ALdlaKVQby/Ip3e/5NpgL1/bEeNDG/WtVdQFV/IP9v4seAsF1nQxnyZ Jh29sELE6AUha4NPwW0WDSIAkBuIw2U/i220kZoHy6+q4RHkmdEFXCcd+7ReTggHuZzq FU+4lOSmfhRsnVpjAkCAIcFzXOEWg+znBfvnX0oVURx+X7AcUB7GBLayyUtdEL4mGiCA TIey72dvXSxBmOZZi9+UlxGBrZt1HOsIgDDnBROuosCWEHxQUorLql7k9k+f/GreMo15 gpcg== X-Gm-Message-State: APjAAAURnZv/cOv4BalZn4A3py6Hf+HFOj9OUn1gf+ikHytCMMZ/Vi2L ibc0zo/L5S7rTrGpwIPIAI4BCZRs X-Google-Smtp-Source: APXvYqxTNqwHq0WVu2D09lrdzA/RLQGrmdozZ6J5eBdQXu18+f9N8PeAwHj98h+nMUCQawcD2DuQ6Q== X-Received: by 2002:a5d:4bc1:: with SMTP id l1mr10864468wrt.259.1565956673248; Fri, 16 Aug 2019 04:57:53 -0700 (PDT) Received: from Red ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id m23sm7291053wml.41.2019.08.16.04.57.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Aug 2019 04:57:52 -0700 (PDT) Date: Fri, 16 Aug 2019 13:57:50 +0200 From: Corentin Labbe To: Maxime Ripard Subject: Re: [PATCH] ARM64: dts: allwinner: Add devicetree for pine H64 modelA evaluation board Message-ID: <20190816115750.GA24545@Red> References: <20190808084253.10573-1-clabbe.montjoie@gmail.com> <20190812094000.ebdmhyxx7xzbevef@flea> <20190814131741.GB24324@Red> <20190814133322.dawzv3ityakxtqs4@flea> <20190816093513.GA25042@Red> <20190816113650.hstbi5ntstx3wh4a@flea> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190816113650.hstbi5ntstx3wh4a@flea> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190816_045754_985795_714D148E X-CRM114-Status: GOOD ( 29.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, wens@csie.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 16, 2019 at 01:36:50PM +0200, Maxime Ripard wrote: > On Fri, Aug 16, 2019 at 11:35:13AM +0200, Corentin Labbe wrote: > > On Wed, Aug 14, 2019 at 03:33:22PM +0200, Maxime Ripard wrote: > > > On Wed, Aug 14, 2019 at 03:17:41PM +0200, Corentin Labbe wrote: > > > > On Mon, Aug 12, 2019 at 11:40:00AM +0200, Maxime Ripard wrote: > > > > > On Thu, Aug 08, 2019 at 10:42:53AM +0200, Corentin Labbe wrote: > > > > > > This patch adds the evaluation variant of the model A of the PineH64. > > > > > > The model A has the same size of the pine64 and has a PCIE slot. > > > > > > > > > > > > The only devicetree difference with current pineH64, is the PHY > > > > > > regulator. > > > > > > > > > > > > Signed-off-by: Corentin Labbe > > > > > > --- > > > > > > arch/arm64/boot/dts/allwinner/Makefile | 1 + > > > > > > .../sun50i-h6-pine-h64-modelA-eval.dts | 26 +++++++++++++++++++ > > > > > > 2 files changed, 27 insertions(+) > > > > > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelA-eval.dts > > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile > > > > > > index f6db0611cb85..9a02166cbf72 100644 > > > > > > --- a/arch/arm64/boot/dts/allwinner/Makefile > > > > > > +++ b/arch/arm64/boot/dts/allwinner/Makefile > > > > > > @@ -25,3 +25,4 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-3.dtb > > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-lite2.dtb > > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-one-plus.dtb > > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb > > > > > > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-modelA-eval.dtb > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelA-eval.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelA-eval.dts > > > > > > new file mode 100644 > > > > > > index 000000000000..d8ff02747efe > > > > > > --- /dev/null > > > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelA-eval.dts > > > > > > @@ -0,0 +1,26 @@ > > > > > > +// SPDX-License-Identifier: (GPL-2.0+ or MIT) > > > > > > +/* > > > > > > + * Copyright (C) 2019 Corentin Labbe > > > > > > + */ > > > > > > + > > > > > > +#include "sun50i-h6-pine-h64.dts" > > > > > > + > > > > > > +/ { > > > > > > + model = "Pine H64 model A evaluation board"; > > > > > > + compatible = "pine64,pine-h64-modelA-eval", "allwinner,sun50i-h6"; > > > > > > + > > > > > > + reg_gmac_3v3: gmac-3v3 { > > > > > > + compatible = "regulator-fixed"; > > > > > > + regulator-name = "vcc-gmac-3v3"; > > > > > > + regulator-min-microvolt = <3300000>; > > > > > > + regulator-max-microvolt = <3300000>; > > > > > > + startup-delay-us = <100000>; > > > > > > + gpio = <&pio 2 16 GPIO_ACTIVE_HIGH>; > > > > > > + enable-active-high; > > > > > > + }; > > > > > > + > > > > > > +}; > > > > > > + > > > > > > +&emac { > > > > > > + phy-supply = <®_gmac_3v3>; > > > > > > +}; > > > > > > > > > > I might be missing some context here, but I'm pretty sure that the > > > > > initial intent of the pine h64 DTS was to support the model A all > > > > > along. > > > > > > > > > > > > > The regulator changed between modelA and B. > > > > See this old patchset (supporting modelA) https://patchwork.kernel.org/patch/10539149/ for example. > > > > > > I'm not sure what your point is, but mine is that everything about the > > > model A should be in sun50i-h6-pine-h64.dts. > > > > > > > model A and B are different enough for distinct dtb, (see sub-thread > > on HDMI difference for an other difference than PHY regulator) > > I don't mind having separate DTBs for model A and model B. > > > And clearly, the current dtb is for model B. > > That DTS was added almost a year before the model B was announced, and > no commit to that file mention the model B, so it's definitely not > clear. Normal it was added for model A (without any ethernet/HDMI support, so nothing distinct from model B), and the modelB ethernet/HDMI support cames after. > > > So do you mean that we need to create a new dtb for model B ? (and > > hack the current back to model A ?) > > I'd prefer not to hack anything, but yes > Since model A is not public (only evaluations boards exists), the probability of a production model A is low and the current dtb is perfect for model B , could you reconsider this ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel