From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E91FAC3A59C for ; Fri, 16 Aug 2019 16:15:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCE122133F for ; Fri, 16 Aug 2019 16:15:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N2DZCRt5"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cEY+U4e9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCE122133F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ii7LRQ1FqtXhgGeTxBtZxIj62QJTSiqULYP0DG47uHI=; b=N2DZCRt5wua5jo k//nRLUriPal0isVSVsPpkEIuSZxRq5VH9RouJCpzVCmHEkdAxuI07PDLHnthLhnWbtdmBIBGgncB DUT3GM/iivbGMXhyAMZEwCWASvQ09HePyQ98WldHMIPwCE8OK2NC6HjvkO0QJjmFCF3LHvYeFn8yj d2Uw9FqEyt+b0ZjdxzUWtwl5Y2AVJwALGNMAVFgD2AgzD0de5y1XMKSQb6/OdwztviZ9oHIpf+NO3 NK7hjnTaKQ0xDh2VuntRr6vn9ij7VCpnFmdWIC4oHvlEqLcMCHUrOLPRXO5lTt0OC5yn3YPzWOfyN km9b6uw4J0aGUOhWi5qQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hyetB-0000QP-2H; Fri, 16 Aug 2019 16:15:41 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hyesv-0000EZ-9j for linux-arm-kernel@lists.infradead.org; Fri, 16 Aug 2019 16:15:26 +0000 Received: by mail-pl1-x641.google.com with SMTP id y8so2626852plr.12 for ; Fri, 16 Aug 2019 09:15:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hCoByiGuId6oRoUOKH9JltqEdAI/w+EDZR7ajwPu6Eg=; b=cEY+U4e9trgXyTjSEt9vrxrwlEj6etSwe8plNjb5q28w+Wxur+kCTmIF226UIgzk75 dvPoTVJMRci3+YUoOFEBhnmPFKJWKXWQYi78uuYCC4gO3XWUoBq8L8m3OJF0iSy0z/0b fOrNu1ZIeDNAgu/++i71X8rIk6UWS7hrAmik3Fb1VfxRK6qRFS8/LBHOcLADPdHqmDBf nUSpPGyXinAFNpx+NMt59xxGH/sP9TBP+3a0nrez4KxiHw0nv8OGC3gcSBL63R41w7M0 j4yynVIgTUUGsAl3YjT0hVhsXLDfXJ+9hX3K5lKIL7hCg4CvT94Ujts5O2T+YVPMdLqk ZyeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=hCoByiGuId6oRoUOKH9JltqEdAI/w+EDZR7ajwPu6Eg=; b=SIYNRIiCxdxPH9zotft0FgnDdgpCV3QIT6Lwr6/6yeX3UFGtKfN1bSpUXd/eGonX4h /9JBUVcaqbB6hFV711FKEgn5UjxSuFThVgvDCsNO8QrjhaegD7MsTVTGgz0EyRKQYkry FhlGkbLczrFxG7wwokBHQtTUN8ll1fcJRpfrmrlBP6teyk/n40ersGsvNXmVt3cvG8iV Urct3nhECwPuw7AoJO4xsJduj+g4Q91m0qH6gjCnN72xzisRIoz1sQIxoXN0lAKbYYkg lmtxcwgRfhMo44xLw14qQCzLtCpmmhpXjWht3t2B6+tlSFGqDZ9OXBnz0bFnhNCqFep1 9V7g== X-Gm-Message-State: APjAAAVgGk1EUqnmGWRX1Tg4gThJ2c4sJu0hRxO16UPZEiW18hh2nlS+ lC5qc53OLnLEP0nTZpHGUic= X-Google-Smtp-Source: APXvYqw+LolKRAdIcj6iyMrq3orXbq1VOEpKjI2WhIQf3CZL5CeFaTHUCj2rnQbX09fALyYKmfk+xg== X-Received: by 2002:a17:902:b110:: with SMTP id q16mr155147plr.273.1565972124591; Fri, 16 Aug 2019 09:15:24 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id u69sm5262143pgu.77.2019.08.16.09.15.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Aug 2019 09:15:24 -0700 (PDT) Date: Fri, 16 Aug 2019 09:15:23 -0700 From: Guenter Roeck To: Joel Stanley Subject: Re: [PATCH 2/2] watchdog: aspeed: Add support for AST2600 Message-ID: <20190816161523.GB5396@roeck-us.net> References: <20190816160347.23393-1-joel@jms.id.au> <20190816160347.23393-3-joel@jms.id.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190816160347.23393-3-joel@jms.id.au> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190816_091525_388693_23BC3529 X-CRM114-Status: GOOD ( 16.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Ryan Chen , linux-watchdog@vger.kernel.org, linux-aspeed@lists.ozlabs.org, Andrew Jeffery , Rob Herring , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Aug 17, 2019 at 01:33:47AM +0930, Joel Stanley wrote: > From: Ryan Chen > > The ast2600 can be supported by the same code as the ast2500. > > Signed-off-by: Ryan Chen > Signed-off-by: Joel Stanley > --- > drivers/watchdog/aspeed_wdt.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/watchdog/aspeed_wdt.c b/drivers/watchdog/aspeed_wdt.c > index cc71861e033a..94f73796ba9d 100644 > --- a/drivers/watchdog/aspeed_wdt.c > +++ b/drivers/watchdog/aspeed_wdt.c > @@ -31,9 +31,14 @@ static const struct aspeed_wdt_config ast2500_config = { > .ext_pulse_width_mask = 0xfffff, > }; > > +static const struct aspeed_wdt_config ast2600_config = { > + .ext_pulse_width_mask = 0xfffff, > +}; > + Why not just reuse ast2500_config ? Guenter > static const struct of_device_id aspeed_wdt_of_table[] = { > { .compatible = "aspeed,ast2400-wdt", .data = &ast2400_config }, > { .compatible = "aspeed,ast2500-wdt", .data = &ast2500_config }, > + { .compatible = "aspeed,ast2600-wdt", .data = &ast2600_config }, > { }, > }; > MODULE_DEVICE_TABLE(of, aspeed_wdt_of_table); > @@ -259,7 +264,8 @@ static int aspeed_wdt_probe(struct platform_device *pdev) > set_bit(WDOG_HW_RUNNING, &wdt->wdd.status); > } > > - if (of_device_is_compatible(np, "aspeed,ast2500-wdt")) { > + if ((of_device_is_compatible(np, "aspeed,ast2500-wdt")) || > + (of_device_is_compatible(np, "aspeed,ast2600-wdt"))) { > u32 reg = readl(wdt->base + WDT_RESET_WIDTH); > > reg &= config->ext_pulse_width_mask; > -- > 2.23.0.rc1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel