From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F06C8C3A59C for ; Fri, 16 Aug 2019 17:39:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3032205F4 for ; Fri, 16 Aug 2019 17:39:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cyQhvXHe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="VEUKX1wo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3032205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wc1DB3k4oKOM7KSH4OuCs+eIdDOtUFB5jm4SoTcLBBY=; b=cyQhvXHe7tbATw QmvA9A+wTJTMGsuPP/dAYmoYeRGabYqIgE1hKuA5BNEm+ArTW3Q4/WjS2GUalK60oEM6mB396ikNg LJ9DPSoUwoxv7ISD3LkaHApXF2+i51NzxAH9A3CiRxcpZfqAkxJkfRXJolJ73+kZcMKGM2qmZCrUV S6OWL4OkIyilDd3khAN+TUEqzA9xzVhPGgALnw+4RXcX7HhzuPl4NUAs6+eGsiySNtjCGkIBbT0HT yHyEXCnybh4Pl1becCY+M1XIhQkNqfz8E6EK0Jbj6dn+tU005C5KSt/5ZF+O43prrEi8kJnyRzJkw 4HkGjQAGTCSLRUlkU/TQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hygCR-0002qn-JI; Fri, 16 Aug 2019 17:39:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hygCM-0002qK-Uc; Fri, 16 Aug 2019 17:39:36 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 60509205F4; Fri, 16 Aug 2019 17:39:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565977174; bh=Hkql629r7jMcpDCSxxQyeYY9VUfj+ahusqlu9yDMvrc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=VEUKX1woF1+HKNWJy9m1xpe3/2wVZkOVt6mzeKpwGagd4EEyDFFQ5aIFPPYudf/u9 WI2YjhZvHidzvy2iHc7gwEzPwnYeshMTHPpS6vQTqDNKa9bvgvUbXaZ201A9ru/0LT SnNpM1nc4HKDqE1dego2rca6fTLJ1bh6niL07Rho= MIME-Version: 1.0 In-Reply-To: <1565713248-4906-7-git-send-email-wahrenst@gmx.net> References: <1565713248-4906-1-git-send-email-wahrenst@gmx.net> <1565713248-4906-7-git-send-email-wahrenst@gmx.net> Subject: Re: [PATCH V2 06/13] clk: bcm2835: Mark PLLD_PER as CRITICAL From: Stephen Boyd To: Eric Anholt , Florian Fainelli , Mark Rutland , Michael Turquette , Ray Jui , Rob Herring , Scott Branden , Stefan Wahren , Wolfram Sang User-Agent: alot/0.8.1 Date: Fri, 16 Aug 2019 10:39:33 -0700 Message-Id: <20190816173934.60509205F4@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190816_103935_008565_F935B4C0 X-CRM114-Status: GOOD ( 15.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Stefan Wahren , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Stefan Wahren (2019-08-13 09:20:41) > The VPU firmware assume that the PLLD_PER isn't modified by the ARM core. > Otherwise this could cause firmware lookups. So mark the clock as critical > to avoid this. > > Signed-off-by: Stefan Wahren > --- > drivers/clk/bcm/clk-bcm2835.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c > index fdf672a..b62052e 100644 > --- a/drivers/clk/bcm/clk-bcm2835.c > +++ b/drivers/clk/bcm/clk-bcm2835.c > @@ -1785,7 +1785,7 @@ static const struct bcm2835_clk_desc clk_desc_array[] = { > .load_mask = CM_PLLD_LOADPER, > .hold_mask = CM_PLLD_HOLDPER, > .fixed_divider = 1, > - .flags = CLK_SET_RATE_PARENT), > + .flags = CLK_IS_CRITICAL | CLK_SET_RATE_PARENT), Please add a comment in the code to the effect that is in the commit text so we don't have to dig through commits to figure out why this special CLK_IS_CRITICAL flag is here. > [BCM2835_PLLD_DSI0] = REGISTER_PLL_DIV( > SOC_ALL, > .name = "plld_dsi0", _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel