From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A79BCC3A589 for ; Sun, 18 Aug 2019 09:51:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 738EF205ED for ; Sun, 18 Aug 2019 09:51:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YqlN1AFv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ingics-com.20150623.gappssmtp.com header.i=@ingics-com.20150623.gappssmtp.com header.b="Zj7X6NrL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 738EF205ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ingics.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=WKDbqn86ICJGbqsqWHwEuTJ3i3g9NvX7daYk3/wsPN4=; b=YqlN1AFvk5VZSA e0qkVzbdTTSu4Hv7L0kVIp35p3QCogOIx1kzcyUvpcJR8pynfyf2IVwDEyT6CDEl5GcM0jH87GskL n0rl3NEp0/T4VFoGxeEs50WfgV96C1xKO3haxIceNyqI33WN7PAglMtVQc0+p+JYGHCqCZBYCXctq xUv3BqZ6zthA6L0i+fu59WJ1Uf4kwC7DYrpyBH/I+pndoqmYlDeNqkjB2kR8+SGEHJ3as+LXDhbvl KfDyNlvwAdVwYGYdi/3VOWvJ4Y5KG+8kLEQ0Bdc7QP3ucDwgR57bMRPqTk+BuDb97CC/5wj8EbNU7 kwBv/6W+1q5rFo4ckH/w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzHqV-0006bH-1c; Sun, 18 Aug 2019 09:51:31 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hzHqS-0006at-En for linux-arm-kernel@lists.infradead.org; Sun, 18 Aug 2019 09:51:29 +0000 Received: by mail-pf1-x443.google.com with SMTP id 196so5420183pfz.8 for ; Sun, 18 Aug 2019 02:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingics-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fPFwCZoR+0RfxABah+OM05It7kpLvC0foG3il7KX154=; b=Zj7X6NrLuEUJqmZRqJ5jLUufow80BiJ4nT/gAmJ32eCfAj4hrkYoA7VfdC7+9hNWkA gLGdnC8bU5FErbKMKjvLer9grsQYgcFpKMwvOO6qWsQpxgjvopot4QYNDZ8LXEViMWBs foPKXvDqTTXOul+cohKI9Il5Vr0ExIk34v/Zn0+X/+7kP1AWh2QxkdIvttb5FW0XFqz9 1n6oyWkrT5yTvEIRqM9By42Ndmr9J311fw7auUizjKAuTunSIDSfkax2wpldoAM/LuQg dhdeVqD0zJ+HZ13ndw/7bcpWcX4HfrWaOHsFOmYLF9h+9U3s8exeC7HvMnTcUOsbKS45 lC+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fPFwCZoR+0RfxABah+OM05It7kpLvC0foG3il7KX154=; b=WqB5JloCtq032sSEffvF2B6zGXIpS+q9tt6lYaeAj2Ag581h+8BVuNES1XLSMHaID4 wCnhog8HxUdBh9whmBolLugns5mM7wGOlYraDLUAvwwPVo6V/k29VWQPKod9a7e5q2g4 +CdOUHEKyh6LbT+yzIABhixcHa7KGPpKaMYBsmumpDmG0Qm3vxfKzKLTowap2sMZPWyt SnON0THQKZcGgp3f5xsxQle/jP7RQ8cakRhjAbCqO4DYE4HAjK4F7btMK/8whozQWpFR z6nWWreBLTjr0DLjLZux/kSpTTQTjY+JtbT3b4dlYO1IIMlNmZ17uEWkrZvd25TaT1fZ uULg== X-Gm-Message-State: APjAAAU4Ptsuca3f5LhuYEc6IcXaFjpLbcZrtusYdxImFxjKDkxvHmTv SfYtoReGZM8xyUn3sOOEfph+tfpp5Yo= X-Google-Smtp-Source: APXvYqyCBVPN67Etp2d4Z4UMUzanossGvxZde/BprjcHVcrqXWrltSRca87GAVuKDet9K5vh+P84EQ== X-Received: by 2002:a63:4522:: with SMTP id s34mr15011368pga.362.1566121887112; Sun, 18 Aug 2019 02:51:27 -0700 (PDT) Received: from localhost.localdomain (122-117-179-2.HINET-IP.hinet.net. [122.117.179.2]) by smtp.gmail.com with ESMTPSA id v145sm13203521pfc.31.2019.08.18.02.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Aug 2019 02:51:26 -0700 (PDT) From: Axel Lin To: Mark Brown Subject: [PATCH] spi: zynq-qspi: Fix missing spi_unregister_controller when unload module Date: Sun, 18 Aug 2019 17:51:13 +0800 Message-Id: <20190818095113.2397-1-axel.lin@ingics.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190818_025128_522802_993988EE X-CRM114-Status: GOOD ( 10.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Axel Lin , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use devm_spi_register_controller to fix missing spi_unregister_controller when unload module. Signed-off-by: Axel Lin --- drivers/spi/spi-zynq-qspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-zynq-qspi.c b/drivers/spi/spi-zynq-qspi.c index 3155e2cabb1e..4a5326ccf65a 100644 --- a/drivers/spi/spi-zynq-qspi.c +++ b/drivers/spi/spi-zynq-qspi.c @@ -694,7 +694,7 @@ static int zynq_qspi_probe(struct platform_device *pdev) ctlr->setup = zynq_qspi_setup_op; ctlr->max_speed_hz = clk_get_rate(xqspi->refclk) / 2; ctlr->dev.of_node = np; - ret = spi_register_controller(ctlr); + ret = devm_spi_register_controller(&pdev->dev, ctlr); if (ret) { dev_err(&pdev->dev, "spi_register_master failed\n"); goto clk_dis_all; -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel