From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FFE6C3A59B for ; Mon, 19 Aug 2019 07:51:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53FFE2082C for ; Mon, 19 Aug 2019 07:51:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ny6tMbm+"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0B1qKbNH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53FFE2082C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=63GyYyjEsCSF/2uwiaFqF7ltPyOgyEXnwzPoKJX+3gU=; b=ny6tMbm+5kyWFD O/Ke/kJMnUxVA6VbmjYGfkcMlT9bDJkNZz9ySHeZkta5W/DZX1FdB4IMOYw1j5VBg1xhTw5TRu+AF 2WSEJIKk6jWEps5Yjw7VTfntSDl9lRx3vwyKuCxJpmfg43GPnq546RRUFc1oCi1tpo1zULU7SKLzK /Y9uVmWGpHvdL2C1d+SEt8B3N25IYLell2WCNeC0zZDlbTp6SB4Qm9RZ8SJ0Q6FFpH3i7oP2KS4Fc HURFR0xM0+yVtA9cBEgfTIckI+jwK+g5q03/uYxPYMAFNocFEfFb+RaCJJDQ+3vi3yA+QvyG8yP9A zfabcFqDmjtn3zGIp4lw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzcSJ-00010m-Qu; Mon, 19 Aug 2019 07:51:55 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hzcSG-0000zP-EN for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2019 07:51:53 +0000 Received: from X250 (37.80-203-192.nextgentel.com [80.203.192.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ECFAB2184E; Mon, 19 Aug 2019 07:51:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566201112; bh=2/vZ0TTiRM4QnAl22MZxwHQZvlNisoqFM1RJui0gC4Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0B1qKbNH+o4DMmEwui7F3RpwvGKKc9/Lw1t8PYcSpKx+hDIRkEgWovjezQ+ySixZ/ QlBIW8TQ7LQvIY7a1K2wavjZJ6C7W3CYncb8leNxGC7DVdI+Fm1U9JGu2QaA1rjpBO 388CHZGw5plMGz82kCVv/3w3MilzMWp+3Y/3YkGU= Date: Mon, 19 Aug 2019 09:51:40 +0200 From: Shawn Guo To: =?iso-8859-1?Q?Andr=E9?= Draszik Subject: Re: [PATCH] ARM: imx: stop adjusting ar8031 phy tx delay Message-ID: <20190819075139.GF5999@X250> References: <20190809031256.3594-1-git@andred.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190809031256.3594-1-git@andred.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190819_005152_502366_A3830957 X-CRM114-Status: GOOD ( 18.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kate Stewart , Greg Kroah-Hartman , Sascha Hauer , linux-kernel@vger.kernel.org, Russell King , NXP Linux Team , Pengutronix Kernel Team , Thomas Gleixner , Leonard Crestez , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 09, 2019 at 04:12:56AM +0100, Andr=E9 Draszik wrote: > Recent changes to the Atheros at803x driver cause > the approach taken here to stop working because > commit 6d4cd041f0af > ("net: phy: at803x: disable delay only for RGMII mode") > and commit cd28d1d6e52e > ("net: phy: at803x: Disable phy delay for RGMII mode") > fix the AR8031 driver to configure the phy's (RX/TX) > delays as per the 'phy-mode' in the device tree. > = > In particular, the phy tx (and rx) delays are updated > again as per the 'phy-mode' *after* the code in here > runs. > = > Things worked before above commits, because the AR8031 > comes out of reset with RX delay enabled, and the > at803x driver didn't touch the delay configuration at > all when "rgmii" mode was selected. > = > It appears the code in here tries to make device > trees work that incorrectly specify "rgmii", but > that can't work any more and it is imperative since > above commits to have the phy-mode configured > correctly in the device tree. > = > I suspect there are a few imx7d based boards using > the ar8031 phy and phy-mode =3D "rgmii", but given I > don't know which ones exactly, I am not in a > position to update the respective device trees. > = > Hence this patch is simply removing the superfluous > code from the imx7d initialisation. An alternative > could be to add a warning instead, but that would > penalize all boards that have been updated already. > = > Signed-off-by: Andr=E9 Draszik > CC: Russell King > CC: Shawn Guo > CC: Sascha Hauer > CC: Pengutronix Kernel Team > CC: Fabio Estevam > CC: NXP Linux Team > CC: Kate Stewart > CC: Greg Kroah-Hartman > CC: Thomas Gleixner > CC: Leonard Crestez > CC: linux-arm-kernel@lists.infradead.org Applied, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel