Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Michael Nazzareno Trimarchi <michael@amarulasolutions.com>
Cc: mpartap@gmx.net, Tony Lindgren <tony@atomide.com>,
	Merlijn Wajer <merlijn@wizzup.org>,
	"open list:TI WILINK WIRELES..." <linux-wireless@vger.kernel.org>,
	kernel list <linux-kernel@vger.kernel.org>,
	Sebastian Reichel <sre@kernel.org>,
	nekit1000@gmail.com,
	Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: wifi on Motorola Droid 4 in 5.3-rc2
Date: Mon, 19 Aug 2019 11:24:14 +0200
Message-ID: <20190819092414.GB21072@amd> (raw)
In-Reply-To: <CAOf5uwncAHQ-nfFzQhv=T+pyXJ+60_QNT4F11VJg+25GjFFkxQ@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 2506 bytes --]

Hi!

> > [   13.653778] panel-dsi-cm 58004000.encoder:display: using lookup
> > tables for GPIO lookup
> > [   13.661834] panel-dsi-cm 58004000.encoder:display: No GPIO consumer
> > te found
> > [   14.756622] ------------[ cut here ]------------
> > [   14.761352] WARNING: CPU: 0 PID: 20 at
> > /data/fast/l/k/drivers/net/wireless/ti/wlcore/sdio.c:86
> > wl12xx_sdio_raw_read+0xa8/0x128
> > [   14.772888] Modules linked in:
> > [   14.776062] CPU: 0 PID: 20 Comm: kworker/0:1 Tainted: G        W
> > 5.3.0-rc4-58571-gdbaece1 #85
> > [   14.783630] Hardware name: Generic OMAP4 (Flattened Device Tree)
> > [   14.791381] Workqueue: events request_firmware_work_func
> 
> You have a timeout here. Can be that your reset sequence of the wifi
> is not optimal because
> is not responding?

I tried delays and printks... WL12XX_REG_FUSE_BD_ADDR_1 read fails,
and retrying does not really help. If you have idea how to debug/fix
this, let me know...

Best regards,
								Pavel

diff --git a/drivers/net/wireless/ti/wl12xx/main.c b/drivers/net/wireless/ti/wl12xx/main.c
index 3c9c623..afb294a 100644
--- a/drivers/net/wireless/ti/wl12xx/main.c
+++ b/drivers/net/wireless/ti/wl12xx/main.c
@@ -1505,24 +1505,40 @@ static int wl12xx_get_fuse_mac(struct wl1271 *wl)
 {
 	u32 mac1, mac2;
 	int ret;
-
+	
+	mdelay(1);
+	printk("get_fuse_mac: %d\n", __LINE__);
 	ret = wlcore_set_partition(wl, &wl->ptable[PART_DRPW]);
 	if (ret < 0)
 		goto out;
 
+	mdelay(1);
+	printk("get_fuse_mac: %d\n", __LINE__);
+	ret = wlcore_read32(wl, WL12XX_REG_FUSE_BD_ADDR_1, &mac1);
+	if (ret < 0) {
+	printk("get_fuse_mac: X %d\n", __LINE__);
+	ret = wlcore_read32(wl, WL12XX_REG_FUSE_BD_ADDR_1, &mac1);
+	if (ret < 0) {
+	printk("get_fuse_mac: XX %d\n", __LINE__);
 	ret = wlcore_read32(wl, WL12XX_REG_FUSE_BD_ADDR_1, &mac1);
 	if (ret < 0)
 		goto out;
+	}
+	}
+	
 
+	printk("get_fuse_mac: %d\n", __LINE__);
 	ret = wlcore_read32(wl, WL12XX_REG_FUSE_BD_ADDR_2, &mac2);
 	if (ret < 0)
 		goto out;
 
+	printk("get_fuse_mac: %d\n", __LINE__);
 	/* these are the two parts of the BD_ADDR */
 	wl->fuse_oui_addr = ((mac2 & 0xffff) << 8) +
 		((mac1 & 0xff000000) >> 24);
 	wl->fuse_nic_addr = mac1 & 0xffffff;
 
+	printk("get_fuse_mac: %d\n", __LINE__);
 	ret = wlcore_set_partition(wl, &wl->ptable[PART_DOWN]);
 
 out:

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-18 10:46 Pavel Machek
2019-08-18 10:53 ` Michael Nazzareno Trimarchi
2019-08-18 11:43   ` Pavel Machek
2019-08-18 12:43     ` Michael Nazzareno Trimarchi
2019-08-19  9:24       ` Pavel Machek [this message]
2019-08-18 14:06     ` Kalle Valo
2019-08-19  9:19       ` Pavel Machek
2019-08-18 11:46   ` Pavel Machek
2019-08-18 12:45 ` Michael Nazzareno Trimarchi

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190819092414.GB21072@amd \
    --to=pavel@ucw.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=merlijn@wizzup.org \
    --cc=michael@amarulasolutions.com \
    --cc=mpartap@gmx.net \
    --cc=nekit1000@gmail.com \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git