From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55810C3A59D for ; Mon, 19 Aug 2019 11:18:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2431620989 for ; Mon, 19 Aug 2019 11:18:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DTkV9Yu2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yHvLt0Lq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2431620989 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xL4YUvroWLgLt0bl8zJLNDtrtgXj+GfydCHXPiP9CCs=; b=DTkV9Yu2fapytU 79FthCHp1/oWq3fm+PaLd22ORcJrFtwxVvxriq7kfmYKKfXV353e6tAZLr6TMUUA8CtEI9DxXQDs/ sPQR2PpgrlopB4kGjREchfgDBbrQUuB2Vll0n0eTmONRdPqIghLh3Sr3krKdr3RT67bjB4ievHWut Vp0Z2F5MBvtwlLMiwI1apWs80dqR2fV0Q+7knwLI3dK3pp4TQGWj/p8UUP7bgLPFPqnS7ZgwbFBNF 2fCeKol4jYmPx8D1WCUUC30epttnizr1BtAkpCcW84zDtV2yO8tMvd64jdJM1L876ngLQGn/VR+kv hCnD1H1uNM0dApuE3h1w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzfgS-0002vT-HQ; Mon, 19 Aug 2019 11:18:44 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hzfgO-0002uP-Hu for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2019 11:18:42 +0000 Received: by mail-pl1-x644.google.com with SMTP id bj8so827232plb.4 for ; Mon, 19 Aug 2019 04:18:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+0JHVJ6vLP57lu0mVcK3az5uoceXnYkV/uG2YnQJlFc=; b=yHvLt0Lqcb9O8pCS28X3oB0TkDb1X6NWvoLOSLok1pdmLUebRybtLcc/QVJYMDiGdI X1a9kvGLCqr3QU6LlKSeWFJPDuJM9aqVFndIz+MGlkMvOi0+AEc8DdZ8AE/RfZkEWKqL RF8Z2wgL2Y7XyOXj4P1FSMOcjOv2ELEW/kleU2VQGLqXj4dsVDB/M2TzyEcPsASqvjcW Sl/VjLG36MbKp+HKiLkfFnsXeK7GOUDvrbr4qSkOk6MaXf1XyG0CKC018GUyItmlUPlB BmHDfdzGU2Hx1N9xGdUzeCVP7hBkUfM2FZdoS7VY+JS/an1HGuQMPVAMfwC3vQ6jInDz SvrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+0JHVJ6vLP57lu0mVcK3az5uoceXnYkV/uG2YnQJlFc=; b=JC6Cr1zV3xsYH57fXjmA3HWSGjWevhFW2FFz6id+vmB0nUjJvAFVeE5ZQl2LzCJV+e +GZDkSG5lC6FsH17nkw3iY/gCn0G+Hu2V2wA+hplL/zEqfk546dlYkXPq9aXmmchSF2J aW/LDWymRJLhEfQLoMp0BzZtc1uCeNDOkVnQQzsYZhJJVu7c57cE3t9kGQ9tysxZ4vzt l08DCoeNohyTpSlob3GCRQk2BiZgaympfGaj0kCNPcH7j/BRfENUmMWQ2vAfkG7YgEgs 1gpxxRoEJ+XmnrQ45KueIpvpr8Ywf34KdBoIzVHP54yKoEXQZ48oMYIqkKhxozM+Vv/M g0rg== X-Gm-Message-State: APjAAAVQqw116npxyZQqBc0XIfs73S6hR6llEbwO453F3o+NZcJ9nBre iJHvCI/9al8Uo0sHS9kfw0uO4Q== X-Google-Smtp-Source: APXvYqyeim3wFsyNXQj/i/RDQRhJjEOMjrjuOoydnB1fIrDDwTjwzY2Z5AOdrzw4HJlIotmEz1cy5g== X-Received: by 2002:a17:902:f204:: with SMTP id gn4mr22280443plb.3.1566213519598; Mon, 19 Aug 2019 04:18:39 -0700 (PDT) Received: from localhost ([122.172.76.219]) by smtp.gmail.com with ESMTPSA id k3sm26078163pfg.23.2019.08.19.04.18.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Aug 2019 04:18:38 -0700 (PDT) Date: Mon, 19 Aug 2019 16:48:36 +0530 From: Viresh Kumar To: "Andrew-sh.Cheng" Subject: Re: [v4, 6/8] PM / OPP: Support adjusting OPP voltages at runtime Message-ID: <20190819111836.5cu245xre6ky6xav@vireshk-i7> References: <1565703113-31479-1-git-send-email-andrew-sh.cheng@mediatek.com> <1565703113-31479-7-git-send-email-andrew-sh.cheng@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1565703113-31479-7-git-send-email-andrew-sh.cheng@mediatek.com> User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190819_041840_624607_E9D21AC5 X-CRM114-Status: GOOD ( 23.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nishanth Menon , srv_heupstream@mediatek.com, linux-pm@vger.kernel.org, Stephen Boyd , Stephen Boyd , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Rob Herring , Chanwoo Choi , Kyungmin Park , MyungJoo Ham , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , fan.chen@mediatek.com, devicetree@vger.kernel.org, Roger Lu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13-08-19, 21:31, Andrew-sh.Cheng wrote: > From: Stephen Boyd > > On some SoCs the Adaptive Voltage Scaling (AVS) technique is > employed to optimize the operating voltage of a device. At a > given frequency, the hardware monitors dynamic factors and either > makes a suggestion for how much to adjust a voltage for the > current frequency, or it automatically adjusts the voltage > without software intervention. Add an API to the OPP library for > the former case, so that AVS type devices can update the voltages > for an OPP when the hardware determines the voltage should > change. The assumption is that drivers like CPUfreq or devfreq > will register for the OPP notifiers and adjust the voltage > according to suggestions that AVS makes. > > This patch is devired from [1] submitted by Stephen. > [1] https://lore.kernel.org/patchwork/patch/599279/ > > Signed-off-by: Stephen Boyd > Signed-off-by: Roger Lu > --- > drivers/opp/core.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++ > include/linux/pm_opp.h | 11 +++++++++ > 2 files changed, 74 insertions(+) > > diff --git a/drivers/opp/core.c b/drivers/opp/core.c > index c094d5d20fd7..407a07f29b12 100644 > --- a/drivers/opp/core.c > +++ b/drivers/opp/core.c > @@ -2054,6 +2054,69 @@ static int _opp_set_availability(struct device *dev, unsigned long freq, > } > > /** > + * dev_pm_opp_adjust_voltage() - helper to change the voltage of an OPP > + * @dev: device for which we do this operation > + * @freq: OPP frequency to adjust voltage of > + * @u_volt: new OPP voltage > + * > + * Return: -EINVAL for bad pointers, -ENOMEM if no memory available for the > + * copy operation, returns 0 if no modifcation was done OR modification was > + * successful. > + */ > +int dev_pm_opp_adjust_voltage(struct device *dev, unsigned long freq, > + unsigned long u_volt) Can you please update this to take a triplet instead ? That is what we are storing in OPP core now a days. -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel