From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B050AC3A59D for ; Mon, 19 Aug 2019 11:25:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79FC22087B for ; Mon, 19 Aug 2019 11:25:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Lx1B+Cot"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LCGerm8f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79FC22087B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dumYRYEOY+jVR+wWt/3Gm82jfzrQwAr6lDUF6OLvTk0=; b=Lx1B+Cotuj6zhe c3iEqZWl4ckcbnU07vmsRQP0yID2518oydtSckU/Dg83wFk/3K6mZ5CAjTln/bmfgREG/TyylIQl2 teIR3kSvEzlxLd4T9uVIsNCv9/cFdmbB9UIdG7ziyMf0Qd5fC88n77W1v+941RN3SoP3d5gnAGoQQ 0RsEPm9JAwKt5EVAvJwU4IyoM1wqnf/WO4d1f+Ch6ABQyBYdnbea8uOlcYGsIwmhUqf6+vkoxeExb 2OKs+n74TPbpJrD/0+nEel8lUxMvFGgwNerCJzhHC4b2AGSb3XDO2wZWkSMJ8qvnQI9iNYl4rZh2s FI7izMmQJAwUfS/vOgOA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzfnR-00072K-1t; Mon, 19 Aug 2019 11:25:57 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hzfnN-00071A-Q3 for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2019 11:25:55 +0000 Received: from X250 (37.80-203-192.nextgentel.com [80.203.192.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC1DA2086C; Mon, 19 Aug 2019 11:25:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566213953; bh=clRxM38BHjVRnHIlDBTCGrVwSVY/3cgF0Ls2MuBJJaQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LCGerm8fY3g/P04NCRoiEKuYqX+8276xlU14NIbB5sZrNFwl+7icni9zUmmh0LxdG 37ons1mvTwKrsMrKh3RTIysDDUzYp7fjGuTFok/rbm0Ytu8wSICvDKSdlNBADa5KVY rjiyUbOuG+EfIER+zg6Bau0BESopAPSbXGyrarFE= Date: Mon, 19 Aug 2019 13:25:40 +0200 From: Shawn Guo To: Philippe Schenker Subject: Re: [PATCH v4 10/21] ARM: dts: imx6qdl-colibri: Add missing pin declaration in iomuxc Message-ID: <20190819112539.GT5999@X250> References: <20190812142105.1995-1-philippe.schenker@toradex.com> <20190812142105.1995-11-philippe.schenker@toradex.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190812142105.1995-11-philippe.schenker@toradex.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190819_042553_863407_791677E7 X-CRM114-Status: GOOD ( 17.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , Michal =?utf-8?B?Vm9rw6HEjQ==?= , Pengutronix Kernel Team , Marcel Ziswiler , Sascha Hauer , "linux-kernel@vger.kernel.org" , "stefan@agner.ch" , Rob Herring , NXP Linux Team , Max Krummenacher , Fabio Estevam , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 12, 2019 at 02:21:29PM +0000, Philippe Schenker wrote: > This adds the muxing for the optional pins usb-oc (overcurrent) and > usb-id. > > Signed-off-by: Philippe Schenker > Acked-by: Marcel Ziswiler > > --- > > Changes in v4: > - Add Marcel Ziswiler's Ack > > Changes in v3: None > Changes in v2: None > > arch/arm/boot/dts/imx6qdl-colibri.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi b/arch/arm/boot/dts/imx6qdl-colibri.dtsi > index 019dda6b88ad..9a63debab0b5 100644 > --- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi > @@ -615,6 +615,13 @@ > >; > }; > > + pinctrl_usbh_oc_1: usbh_oc-1 { Please name it consistently in the way like: pinctrl_xxx: xxxgrp { ... }; Also, it doesn't need to be separate patch but can just be added together with the device referring to it. Shawn > + fsl,pins = < > + /* USBH_OC */ > + MX6QDL_PAD_EIM_D30__GPIO3_IO30 0x1b0b0 > + >; > + }; > + > pinctrl_spdif: spdifgrp { > fsl,pins = < > MX6QDL_PAD_GPIO_17__SPDIF_OUT 0x1b0b0 > @@ -681,6 +688,13 @@ > >; > }; > > + pinctrl_usbc_id_1: usbc_id-1 { > + fsl,pins = < > + /* USBC_ID */ > + MX6QDL_PAD_NANDF_D2__GPIO2_IO02 0x1b0b0 > + >; > + }; > + > pinctrl_usdhc1: usdhc1grp { > fsl,pins = < > MX6QDL_PAD_SD1_CMD__SD1_CMD 0x17071 > -- > 2.22.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel