From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B8DAC3A59D for ; Mon, 19 Aug 2019 12:08:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D187D20851 for ; Mon, 19 Aug 2019 12:08:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jBqET0Wb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="rzk4AQyX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D187D20851 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ymReY7Qs89mIEnHBj+QgaB7zw34C5eaAgnn9uHfGvqA=; b=jBqET0WbxoI70Y Lbel+lLC/6Oue9ZKYNYZH6J2hPwtSV7aUhFni7SHR66SSvIiTi7f86CKJFFRtrrnNJaham8igey1P Ib++TnjzWD6yvbCLDl+94bkkOO/USzgoFKJNUHBd9gcXvZltLenaBmKNctvk7/BMxkgplVRQ1By3a WwbMOS7E9c9Ylk+1YLQdCF0tNzx/Z15Sy5Pbcnc5DAJtdwydefTF+1xB+LgsHfKVNZZALiHstrkUC 3tynhW5yqf2eb3kg6KUqp306Ewi6/YH5V6jUvXBk1Z49c09/8ivIqLmz/bT3RdQ3oOZkt2Dw+klSW 1agTB6R7btYT0A4BH5Mg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzgSr-0000wN-9t; Mon, 19 Aug 2019 12:08:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hzgSo-0000w0-GT for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2019 12:08:43 +0000 Received: from X250 (37.80-203-192.nextgentel.com [80.203.192.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CF8AA20851; Mon, 19 Aug 2019 12:08:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566216522; bh=I6KGzvvULJGHZL55G/OkfCAoZhPAaIcVTYDIPygWzGY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rzk4AQyXeqgNc+HNHWnEfe19wpnctowiDet/Y34gdLZbzrfs9x9uMRFbI/lYAy1Dd P7OTYyL00fBSe9x+LxAp+ZFjLQfepqPVxTrbshJOpaBT7l59kKxPoczztWtt031VCs tH2re3j2NB0+hEPDnHU0ZX40BvxWkfg+AQSNxcl8= Date: Mon, 19 Aug 2019 14:08:30 +0200 From: Shawn Guo To: Sascha Hauer Subject: Re: [PATCH] bus: imx-weim: module_platform_driver() Message-ID: <20190819120829.GD5999@X250> References: <20190814082316.30300-1-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190814082316.30300-1-s.hauer@pengutronix.de> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190819_050842_570652_3AA0659A X-CRM114-Status: GOOD ( 17.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, NXP Linux Team Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 14, 2019 at 10:23:16AM +0200, Sascha Hauer wrote: > Switch from module_platform_driver_probe() to module_platform_driver(). > The former is not suitable for booting with device tree as the driver > will be registered before the device and thus won't be probed again > when the device is present. > > Signed-off-by: Sascha Hauer Applied with subject updated like below. bus: imx-weim: use module_platform_driver() Shawn > --- > drivers/bus/imx-weim.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c > index db74334ca5ef..8a9f8a4328c2 100644 > --- a/drivers/bus/imx-weim.c > +++ b/drivers/bus/imx-weim.c > @@ -183,8 +183,7 @@ static int __init weim_timing_setup(struct device *dev, > return 0; > } > > -static int __init weim_parse_dt(struct platform_device *pdev, > - void __iomem *base) > +static int weim_parse_dt(struct platform_device *pdev, void __iomem *base) > { > const struct of_device_id *of_id = of_match_device(weim_id_table, > &pdev->dev); > @@ -217,7 +216,7 @@ static int __init weim_parse_dt(struct platform_device *pdev, > return ret; > } > > -static int __init weim_probe(struct platform_device *pdev) > +static int weim_probe(struct platform_device *pdev) > { > struct resource *res; > struct clk *clk; > @@ -254,8 +253,9 @@ static struct platform_driver weim_driver = { > .name = "imx-weim", > .of_match_table = weim_id_table, > }, > + .probe = weim_probe, > }; > -module_platform_driver_probe(weim_driver, weim_probe); > +module_platform_driver(weim_driver); > > MODULE_AUTHOR("Freescale Semiconductor Inc."); > MODULE_DESCRIPTION("i.MX EIM Controller Driver"); > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel