From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC7BEC3A589 for ; Tue, 20 Aug 2019 09:43:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FD5422CF7 for ; Tue, 20 Aug 2019 09:43:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fOtxoYYh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FD5422CF7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WSbX8a0WsJ4eJ740+Igzsr6xUaxkKabxyW1GJ2c5NEg=; b=fOtxoYYhtSocw1 knE77d7xNlgnSDE4RrfwDPBJp1hJ5bjE9ZMeEK67ZmuXsevBzG6jCJ1MABVHv7yILgECFtGxqO82T Dwy43xHLLxisQJnzBZsORSh0TNQKLDbxyuCN5vv5fwDGYtYwo3+6FzVm/ulAj5rk3zxNPgSUKAieT 0X6roieS9hSHL5HNzZrLRZolynBMIFANywA3l5ijoRxcy+xGlpBCbBfXQyBgp9WABzrvnXAPeWxBO WtiKNXbr48F75MMWuWrsggto0oZPssq1QJEqfKiYI5S9c7jmC5MMPoXlZk8P5M09o7Fj/cRUH1/1W kSAU7STkH40zMQiIkhIg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i00fX-0000x7-Ly; Tue, 20 Aug 2019 09:43:11 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i00fS-0000ug-OG; Tue, 20 Aug 2019 09:43:06 +0000 Date: Tue, 20 Aug 2019 02:43:06 -0700 From: Christoph Hellwig To: Tom Murphy Subject: Re: [PATCH V5 3/5] iommu/dma-iommu: Handle deferred devices Message-ID: <20190820094306.GC24154@infradead.org> References: <20190815110944.3579-1-murphyt7@tcd.ie> <20190815110944.3579-4-murphyt7@tcd.ie> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190815110944.3579-4-murphyt7@tcd.ie> User-Agent: Mutt/1.11.4 (2019-03-13) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , virtualization@lists.linux-foundation.org, Matthias Brugger , Thierry Reding , Will Deacon , Jean-Philippe Brucker , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Jonathan Hunter , linux-rockchip@lists.infradead.org, Kukjin Kim , Andy Gross , linux-s390@vger.kernel.org, Gerald Schaefer , linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, David Woodhouse , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Robin Murphy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > +static int handle_deferred_device(struct device *dev, > + struct iommu_domain *domain) Nitick: we usually use double tab indents (or indents to after the opening brace) for multi-line prototyped. > + if (!is_kdump_kernel()) > + return 0; > + > + if (unlikely(ops->is_attach_deferred && > + ops->is_attach_deferred(domain, dev))) > + return iommu_attach_device(domain, dev); And for multi-line conditionals we also use two-tab indents. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel