From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39570C3A589 for ; Tue, 20 Aug 2019 15:03:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BB2C22DA9 for ; Tue, 20 Aug 2019 15:03:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QrBIlp7T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BB2C22DA9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vZtxBi495LDqZc2BgahWaAa7QqIz6I7nRVLGyOBTfRY=; b=QrBIlp7TMueIx8disllABiY5q CtTEvvm8iSkLS+NbNyzfsMrlbJtl5zZEpXafiPkuo+0No7xasmJ0viXRY4jqgYi5qzjagUmz14ZaM 5m4crIQg+SdiLaoiJA9mKJVUtg6HbnW9qIQkYFuPyOMXk/g3yeQnsCTdv6LikmM12RDaH2DtzUnMh i2PdPXL2A5MCYUHFGn/u5w+LptB7iyv/jIG2/Ssz5zltanahT6S2l3uP4xy0QkpezpUyVRRV6D3+G oGnJh+2wQaD1QNQCguPTIrpvlIpzg2LrZ4ehYCCflfPht8E+w/QwSmZlxD2n/6QIjNNaLTXwdfDy2 e6FJ/HHXw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i05f8-00022c-IR; Tue, 20 Aug 2019 15:03:06 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i05cW-0007mD-Qi for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2019 15:00:27 +0000 X-Originating-IP: 86.250.200.211 Received: from localhost (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: maxime.ripard@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 1FC3140004; Tue, 20 Aug 2019 15:00:19 +0000 (UTC) Date: Tue, 20 Aug 2019 17:00:18 +0200 From: Maxime Ripard To: Thomas Graichen Subject: Re: [v5,05/12] drm/modes: Rewrite the command line parser Message-ID: <20190820150018.uhiquahda6wuxvjd@flea> References: <5978761.uBj7R84RrF@jernej-laptop> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190820_080025_303599_B770CE82 X-CRM114-Status: GOOD ( 19.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eben@raspberrypi.org, David Airlie , Maarten Lankhorst , Jernej =?utf-8?Q?=C5=A0krabec?= , Paul Kocialkowski , Sean Paul , dri-devel@lists.freedesktop.org, Thomas Petazzoni , Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============5980536781913830119==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5980536781913830119== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="upeyyhtq7btyttw2" Content-Disposition: inline --upeyyhtq7btyttw2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Aug 19, 2019 at 09:20:00PM +0200, Thomas Graichen wrote: > On Mon, Aug 19, 2019 at 8:54 PM Jernej =C5=A0krabec wrote: > > > > +CC: Thomas Graichen > > > > Dne ponedeljek, 17. junij 2019 ob 16:51:32 CEST je Maxime Ripard napisa= l(a): > > > From: Maxime Ripard > > > > > > Rewrite the command line parser in order to get away from the state m= achine > > > parsing the video mode lines. > > > > > > Hopefully, this will allow to extend it more easily to support named = modes > > > and / or properties set directly on the command line. > > > > > > Reviewed-by: Noralf Tr=C3=B8nnes > > > Signed-off-by: Maxime Ripard > > > > Thomas reported to me that this patch breaks "video=3DCONNECTOR:e" kern= el > > parameter which he currently uses as a workaround for H6 HDMI monitor > > detection issue on one STB. > > > > I suppose this is the same issue that Dmitry noticed. > > > > Thomas Graichen (in CC) can provide more information if needed. > > as jernej already mentioned i am currently having to use the kernel > cmdline option video=3DHDMI-A-1:e to get a working hdmi output on an > eachlink h6 mini tv box and was wondering that i did not get any hdmi > output even with this option when switching from the > https://github.com/megous/linux oprange-pi-5.2 to the orange-pi-5.3 > branch which seems to contain this patch. Which kernel version is that based on? > as i had no idea what might have caused the breakage of the hdmi > output and did a full bisect of the kernel between those two > versions, which ended reliably at exactly this patch - so i guess > there is a regression at least with the video=3DCONNECTOR:e option > (maybe others too?) with this patches code which makes it not > working anymore. I'm not sure I'll have the time to look into it this week (or the next, unfortunately). However, the e parameter is supposed to be parsed by drm_mode_parse_cmdline_extra, which in turn is supposed to be called there: https://elixir.bootlin.com/linux/v5.3-rc5/source/drivers/gpu/drm/drm_modes.= c#L1810 If you can test that, having an idea of if that function is called, which return code it returns, and if it isn't if why would be super helpful. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --upeyyhtq7btyttw2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXVwLAgAKCRDj7w1vZxhR xU5jAQCoQQ2yAaOQGsg8OTMgvoNdbtjA4H4nqF4DBTXJ6/8/QQD+L4iC5VrP0gcU b989j1Th8EdacGteid9NZ8Y9NPnLzw8= =EtCt -----END PGP SIGNATURE----- --upeyyhtq7btyttw2-- --===============5980536781913830119== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5980536781913830119==--