From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A9E6C3A589 for ; Tue, 20 Aug 2019 19:50:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2857022D6D for ; Tue, 20 Aug 2019 19:50:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r/DPLAI8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2857022D6D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pWUR++CKgntDIHGrBVtRxc/oS+VKa23A6uzCPW/yj/M=; b=r/DPLAI8Lb3mM6 ZnDDnbvv/J/hYEVqPw2Ff1vMsmNpR4qnd87uROnf9zNvfD8Kz/a7eFaC7J5TExT8gQveuYasbio5e r+aqCmIfdQWZ/W2NMXDfx4vgDqwhpGmkdil3OPRjFcJ6OiRDcC/+dSRSYO3dQvDWbLR1o37GcoYk+ S8aJjM0l/TjEh4wGn5XxmUcr7965qohK9zxDANq9kmPOHD11JHjNQ0TGzCX0hFGWLZ7JHbTDUqygO it/SDfGShZaq2PosjxrBUS/ogu9ENFAgZwcOYeo08fO+pmgZSwfZ7xOjG3h6iWHCudHM87ZuN3U57 +WOP+cVYaj4NtFwFRshg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i0A8s-0005il-Uz; Tue, 20 Aug 2019 19:50:06 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i0A8o-000593-38; Tue, 20 Aug 2019 19:50:04 +0000 X-Originating-IP: 90.65.161.137 Received: from localhost (lfbn-1-1545-137.w90-65.abo.wanadoo.fr [90.65.161.137]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 51CF160004; Tue, 20 Aug 2019 19:49:59 +0000 (UTC) Date: Tue, 20 Aug 2019 21:49:59 +0200 From: Alexandre Belloni To: Frank Wunderlich Subject: Re: [PATCH v6 07/13] rtc: mt6397: improvements of rtc driver Message-ID: <20190820194959.GY3545@piout.net> References: <20190818135611.7776-1-frank-w@public-files.de> <20190818135611.7776-8-frank-w@public-files.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190818135611.7776-8-frank-w@public-files.de> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190820_125002_454496_D7FF9039 X-CRM114-Status: GOOD ( 17.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, Josef Friedl , Sean Wang , "linux-arm-kernel @ lists . infradead . org Alessandro Zummo" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , Tianping Fang , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Mark Rutland , Eddie Huang , Lee Jones , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/08/2019 15:56:05+0200, Frank Wunderlich wrote: > From: Josef Friedl > > - use regmap_read_poll_timeout to drop while-loop > - use devm-api to drop remove-callback > > Suggested-by: Alexandre Belloni > Signed-off-by: Josef Friedl > Signed-off-by: Frank Wunderlich Acked-by: Alexandre Belloni > --- > changes since v5: none > changes since v4: none > changes since v3: none > changes since v2: > - fix allocation after irq-request > - compatible for mt6323 in separate commit => part 5 > --- > drivers/rtc/rtc-mt6397.c | 51 +++++++++++++++------------------------- > 1 file changed, 19 insertions(+), 32 deletions(-) > > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c > index c08ee5edf865..9370b7fc9f81 100644 > --- a/drivers/rtc/rtc-mt6397.c > +++ b/drivers/rtc/rtc-mt6397.c > @@ -4,16 +4,19 @@ > * Author: Tianping.Fang > */ > > -#include > -#include > +#include > +#include > +#include > #include > +#include > +#include > #include > #include > #include > +#include > > static int mtk_rtc_write_trigger(struct mt6397_rtc *rtc) > { > - unsigned long timeout = jiffies + HZ; > int ret; > u32 data; > > @@ -21,19 +24,13 @@ static int mtk_rtc_write_trigger(struct mt6397_rtc *rtc) > if (ret < 0) > return ret; > > - while (1) { > - ret = regmap_read(rtc->regmap, rtc->addr_base + RTC_BBPU, > - &data); > - if (ret < 0) > - break; > - if (!(data & RTC_BBPU_CBUSY)) > - break; > - if (time_after(jiffies, timeout)) { > - ret = -ETIMEDOUT; > - break; > - } > - cpu_relax(); > - } > + ret = regmap_read_poll_timeout(rtc->regmap, > + rtc->addr_base + RTC_BBPU, data, > + !(data & RTC_BBPU_CBUSY), > + MTK_RTC_POLL_DELAY_US, > + MTK_RTC_POLL_TIMEOUT); > + if (ret < 0) > + dev_err(rtc->dev, "failed to write WRTGE: %d\n", ret); > > return ret; > } > @@ -266,19 +263,19 @@ static int mtk_rtc_probe(struct platform_device *pdev) > return rtc->irq; > > rtc->regmap = mt6397_chip->regmap; > - rtc->dev = &pdev->dev; > mutex_init(&rtc->lock); > > platform_set_drvdata(pdev, rtc); > > - rtc->rtc_dev = devm_rtc_allocate_device(rtc->dev); > + rtc->rtc_dev = devm_rtc_allocate_device(&pdev->dev); > if (IS_ERR(rtc->rtc_dev)) > return PTR_ERR(rtc->rtc_dev); > > - ret = request_threaded_irq(rtc->irq, NULL, > - mtk_rtc_irq_handler_thread, > - IRQF_ONESHOT | IRQF_TRIGGER_HIGH, > - "mt6397-rtc", rtc); > + ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL, > + mtk_rtc_irq_handler_thread, > + IRQF_ONESHOT | IRQF_TRIGGER_HIGH, > + "mt6397-rtc", rtc); > + > if (ret) { > dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", > rtc->irq, ret); > @@ -302,15 +299,6 @@ static int mtk_rtc_probe(struct platform_device *pdev) > return ret; > } > > -static int mtk_rtc_remove(struct platform_device *pdev) > -{ > - struct mt6397_rtc *rtc = platform_get_drvdata(pdev); > - > - free_irq(rtc->irq, rtc); > - > - return 0; > -} > - > #ifdef CONFIG_PM_SLEEP > static int mt6397_rtc_suspend(struct device *dev) > { > @@ -349,7 +337,6 @@ static struct platform_driver mtk_rtc_driver = { > .pm = &mt6397_pm_ops, > }, > .probe = mtk_rtc_probe, > - .remove = mtk_rtc_remove, > }; > > module_platform_driver(mtk_rtc_driver); > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel