From: Simon Horman <horms@verge.net.au>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Cc: linux-renesas-soc@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: renesas: r8a774c0-cat874: sort nodes
Date: Wed, 21 Aug 2019 10:41:02 +0200 [thread overview]
Message-ID: <20190821084101.evn6xeiqcqv772um@verge.net.au> (raw)
In-Reply-To: <1566219341-23048-1-git-send-email-ykaneko0929@gmail.com>
On Mon, Aug 19, 2019 at 09:55:41PM +0900, Yoshihiro Kaneko wrote:
> Sort nodes.
>
> If node address is present
> * Sort by node address, grouping all nodes with the same compat string
> and sorting the group alphabetically.
> Else
> * Sort alphabetically
>
> This should not have any run-time effect.
>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Thanks Kaneko-san,
I think that the i2c1_pins and hscif2_pins nodes
are also out of order.
I'm not sure if Geert would prefer you to respin or fix that himself.
In any case, with that problem resolved:
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>
> This patch is based on the master branch of Geert Uytterhoeven's renesas-devel
> tree.
>
> arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> index 651383c..aaa37158 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> @@ -82,13 +82,13 @@
> simple-audio-card,bitclock-master = <&sndcpu>;
> simple-audio-card,frame-master = <&sndcpu>;
>
> - sndcpu: simple-audio-card,cpu {
> - sound-dai = <&rcar_sound>;
> - };
> -
> sndcodec: simple-audio-card,codec {
> sound-dai = <&tda19988>;
> };
> +
> + sndcpu: simple-audio-card,cpu {
> + sound-dai = <&rcar_sound>;
> + };
> };
>
> vcc_sdhi0: regulator-vcc-sdhi0 {
> @@ -313,16 +313,16 @@
> power-source = <1800>;
> };
>
> - sound_pins: sound {
> - groups = "ssi01239_ctrl", "ssi0_data";
> - function = "ssi";
> - };
> -
> sound_clk_pins: sound_clk {
> groups = "audio_clkout1_a";
> function = "audio_clk";
> };
>
> + sound_pins: sound {
> + groups = "ssi01239_ctrl", "ssi0_data";
> + function = "ssi";
> + };
> +
> usb30_pins: usb30 {
> groups = "usb30", "usb30_id";
> function = "usb30";
> --
> 1.9.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-21 8:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 12:55 [PATCH] arm64: dts: renesas: r8a774c0-cat874: sort nodes Yoshihiro Kaneko
2019-08-21 8:41 ` Simon Horman [this message]
2019-08-21 8:46 ` Geert Uytterhoeven
2019-08-21 8:42 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821084101.evn6xeiqcqv772um@verge.net.au \
--to=horms@verge.net.au \
--cc=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).