Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/2] dt-bindings: pwm: pwm-mediatek: Add documentation for MT8516
@ 2019-08-05 12:58 Fabien Parent
  2019-08-05 12:58 ` [PATCH 2/2] pwm: pwm-mediatek: Add MT8516 SoC support Fabien Parent
  2019-08-21 18:53 ` [PATCH 1/2] dt-bindings: pwm: pwm-mediatek: Add documentation for MT8516 Rob Herring
  0 siblings, 2 replies; 5+ messages in thread
From: Fabien Parent @ 2019-08-05 12:58 UTC (permalink / raw)
  To: thierry.reding, robh+dt, matthias.bgg
  Cc: mark.rutland, linux-pwm, devicetree, linux-kernel, Fabien Parent,
	linux-mediatek, linux-arm-kernel

Add the device-tree documentation for the PWM IP on the MediaTek
MT8516 SoCs.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
 Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
index 991728cb46cb..9152bf5afe56 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
+++ b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
@@ -6,6 +6,7 @@ Required properties:
    - "mediatek,mt7622-pwm": found on mt7622 SoC.
    - "mediatek,mt7623-pwm": found on mt7623 SoC.
    - "mediatek,mt7628-pwm": found on mt7628 SoC.
+   - "mediatek,mt8516-pwm": found on mt8516 SoC.
  - reg: physical base address and length of the controller's registers.
  - #pwm-cells: must be 2. See pwm.txt in this directory for a description of
    the cell format.
-- 
2.23.0.rc1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] pwm: pwm-mediatek: Add MT8516 SoC support
  2019-08-05 12:58 [PATCH 1/2] dt-bindings: pwm: pwm-mediatek: Add documentation for MT8516 Fabien Parent
@ 2019-08-05 12:58 ` Fabien Parent
  2019-08-22  8:52   ` Matthias Brugger
  2019-08-22  9:18   ` Uwe Kleine-König
  2019-08-21 18:53 ` [PATCH 1/2] dt-bindings: pwm: pwm-mediatek: Add documentation for MT8516 Rob Herring
  1 sibling, 2 replies; 5+ messages in thread
From: Fabien Parent @ 2019-08-05 12:58 UTC (permalink / raw)
  To: thierry.reding, robh+dt, matthias.bgg
  Cc: mark.rutland, linux-pwm, devicetree, linux-kernel, Fabien Parent,
	linux-mediatek, linux-arm-kernel

Add the compatible and the platform data to support PWM on the MT8516
SoC.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
 drivers/pwm/pwm-mediatek.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
index eb6674ce995f..6697e30811e7 100644
--- a/drivers/pwm/pwm-mediatek.c
+++ b/drivers/pwm/pwm-mediatek.c
@@ -302,11 +302,18 @@ static const struct mtk_pwm_platform_data mt7628_pwm_data = {
 	.has_clks = false,
 };
 
+static const struct mtk_pwm_platform_data mt8516_pwm_data = {
+	.num_pwms = 5,
+	.pwm45_fixup = false,
+	.has_clks = true,
+};
+
 static const struct of_device_id mtk_pwm_of_match[] = {
 	{ .compatible = "mediatek,mt2712-pwm", .data = &mt2712_pwm_data },
 	{ .compatible = "mediatek,mt7622-pwm", .data = &mt7622_pwm_data },
 	{ .compatible = "mediatek,mt7623-pwm", .data = &mt7623_pwm_data },
 	{ .compatible = "mediatek,mt7628-pwm", .data = &mt7628_pwm_data },
+	{ .compatible = "mediatek,mt8516-pwm", .data = &mt8516_pwm_data },
 	{ },
 };
 MODULE_DEVICE_TABLE(of, mtk_pwm_of_match);
-- 
2.23.0.rc1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] dt-bindings: pwm: pwm-mediatek: Add documentation for MT8516
  2019-08-05 12:58 [PATCH 1/2] dt-bindings: pwm: pwm-mediatek: Add documentation for MT8516 Fabien Parent
  2019-08-05 12:58 ` [PATCH 2/2] pwm: pwm-mediatek: Add MT8516 SoC support Fabien Parent
@ 2019-08-21 18:53 ` Rob Herring
  1 sibling, 0 replies; 5+ messages in thread
From: Rob Herring @ 2019-08-21 18:53 UTC (permalink / raw)
  To: Fabien Parent
  Cc: mark.rutland, devicetree, linux-pwm, linux-kernel, robh+dt,
	Fabien Parent, thierry.reding, linux-mediatek, matthias.bgg,
	linux-arm-kernel

On Mon,  5 Aug 2019 14:58:47 +0200, Fabien Parent wrote:
> Add the device-tree documentation for the PWM IP on the MediaTek
> MT8516 SoCs.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---
>  Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] pwm: pwm-mediatek: Add MT8516 SoC support
  2019-08-05 12:58 ` [PATCH 2/2] pwm: pwm-mediatek: Add MT8516 SoC support Fabien Parent
@ 2019-08-22  8:52   ` Matthias Brugger
  2019-08-22  9:18   ` Uwe Kleine-König
  1 sibling, 0 replies; 5+ messages in thread
From: Matthias Brugger @ 2019-08-22  8:52 UTC (permalink / raw)
  To: Fabien Parent, thierry.reding, robh+dt
  Cc: mark.rutland, linux-pwm, devicetree, linux-kernel,
	linux-mediatek, linux-arm-kernel



On 05/08/2019 14:58, Fabien Parent wrote:
> Add the compatible and the platform data to support PWM on the MT8516
> SoC.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
>  drivers/pwm/pwm-mediatek.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
> index eb6674ce995f..6697e30811e7 100644
> --- a/drivers/pwm/pwm-mediatek.c
> +++ b/drivers/pwm/pwm-mediatek.c
> @@ -302,11 +302,18 @@ static const struct mtk_pwm_platform_data mt7628_pwm_data = {
>  	.has_clks = false,
>  };
>  
> +static const struct mtk_pwm_platform_data mt8516_pwm_data = {
> +	.num_pwms = 5,
> +	.pwm45_fixup = false,
> +	.has_clks = true,
> +};
> +
>  static const struct of_device_id mtk_pwm_of_match[] = {
>  	{ .compatible = "mediatek,mt2712-pwm", .data = &mt2712_pwm_data },
>  	{ .compatible = "mediatek,mt7622-pwm", .data = &mt7622_pwm_data },
>  	{ .compatible = "mediatek,mt7623-pwm", .data = &mt7623_pwm_data },
>  	{ .compatible = "mediatek,mt7628-pwm", .data = &mt7628_pwm_data },
> +	{ .compatible = "mediatek,mt8516-pwm", .data = &mt8516_pwm_data },
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, mtk_pwm_of_match);
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] pwm: pwm-mediatek: Add MT8516 SoC support
  2019-08-05 12:58 ` [PATCH 2/2] pwm: pwm-mediatek: Add MT8516 SoC support Fabien Parent
  2019-08-22  8:52   ` Matthias Brugger
@ 2019-08-22  9:18   ` Uwe Kleine-König
  1 sibling, 0 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2019-08-22  9:18 UTC (permalink / raw)
  To: Fabien Parent
  Cc: mark.rutland, devicetree, linux-pwm, linux-kernel, robh+dt,
	thierry.reding, linux-mediatek, matthias.bgg, linux-arm-kernel

On Mon, Aug 05, 2019 at 02:58:48PM +0200, Fabien Parent wrote:
> Add the compatible and the platform data to support PWM on the MT8516
> SoC.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

The change looks fine, there is however another series currently waiting
for application for this driver that conflicts with this one (I think).

Maybe it would be sensible to join your forces and produce a single
series without conflicts?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-05 12:58 [PATCH 1/2] dt-bindings: pwm: pwm-mediatek: Add documentation for MT8516 Fabien Parent
2019-08-05 12:58 ` [PATCH 2/2] pwm: pwm-mediatek: Add MT8516 SoC support Fabien Parent
2019-08-22  8:52   ` Matthias Brugger
2019-08-22  9:18   ` Uwe Kleine-König
2019-08-21 18:53 ` [PATCH 1/2] dt-bindings: pwm: pwm-mediatek: Add documentation for MT8516 Rob Herring

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox