From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67806C3A5A1 for ; Thu, 22 Aug 2019 15:33:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39E52233FD for ; Thu, 22 Aug 2019 15:33:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F6tDVT2o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39E52233FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f6owNFrDLHiys8RnUsWCN3tqkfHzYJE3buhBQTnThiQ=; b=F6tDVT2o2dshUY nUDXHnAJ5j4j0378XO8MDFCLS5hQTi6F0NTy9YljRmJnpaKjlCvMnP2gPmghAga3qK44uQZzqstul 82XsKsE6v8eZtD73MK+GPRiPh3SkTlEpIu5/LcHjqiYvkDTUDv2lazp1gPfyjTnQ0u1vwwLUeLueB D9XCtQ/6owl/v11QD/0XBQuEnLyu8SN9lRdlVcBDvvts/zYEcRZo1zvPnuLTPJQZYhaQLCw488alj jVeZ4AVT6jfLulQ9zzl3HNQtBI2GA9IV/lqr9fJ6K7xoQLz/QHvQuPgfCktXvDxPrWBh03mZGbfy0 vWFCJaqc3WAvxKZ55q2g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i0p4z-0006c0-Qn; Thu, 22 Aug 2019 15:32:49 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i0p4r-0006Um-30 for linux-arm-kernel@lists.infradead.org; Thu, 22 Aug 2019 15:32:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BF1D8337; Thu, 22 Aug 2019 08:32:40 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BC8733F718; Thu, 22 Aug 2019 08:32:39 -0700 (PDT) Date: Thu, 22 Aug 2019 16:32:37 +0100 From: Mark Rutland To: Andrew Murray Subject: Re: [PATCH v3 1/5] jump_label: Don't warn on __exit jump entries Message-ID: <20190822153237.GC33080@lakrids.cambridge.arm.com> References: <20190812143625.42745-1-andrew.murray@arm.com> <20190812143625.42745-2-andrew.murray@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190812143625.42745-2-andrew.murray@arm.com> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190822_083241_530654_6C7EED8C X-CRM114-Status: GOOD ( 20.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Catalin Marinas , Boqun Feng , Will Deacon , Ard.Biesheuvel@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 12, 2019 at 03:36:21PM +0100, Andrew Murray wrote: > On architectures that discard .exit.* sections at runtime, a > warning is printed for each jump label that is used within an > in-kernel __exit annotated function: > > can't patch jump_label at ehci_hcd_cleanup+0x8/0x3c > WARNING: CPU: 0 PID: 1 at kernel/jump_label.c:410 __jump_label_update+0x12c/0x138 > > As these functions will never get executed (they are free'd along > with the rest of initmem) - we do not need to patch them and should > not display any warnings. > > The warning is displayed because the test required to satisfy > jump_entry_is_init is based on init_section_contains (__init_begin to > __init_end) whereas the test in __jump_label_update is based on > init_kernel_text (_sinittext to _einittext) via kernel_text_address). > > In addition to fixing this, we also remove an out-of-date comment > and use a WARN instead of a WARN_ONCE. This last sentence is stale -- it was true in v1 but not since then. With that droppped: Acked-by: Mark Rutland Mark. > Fixes: 19483677684b ("jump_label: Annotate entries that operate on __init code earlier") > Signed-off-by: Andrew Murray > Acked-by: Peter Zijlstra (Intel) > --- > kernel/jump_label.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/kernel/jump_label.c b/kernel/jump_label.c > index df3008419a1d..cdb3ffab128b 100644 > --- a/kernel/jump_label.c > +++ b/kernel/jump_label.c > @@ -407,7 +407,9 @@ static bool jump_label_can_update(struct jump_entry *entry, bool init) > return false; > > if (!kernel_text_address(jump_entry_code(entry))) { > - WARN_ONCE(1, "can't patch jump_label at %pS", (void *)jump_entry_code(entry)); > + WARN_ONCE(!jump_entry_is_init(entry), > + "can't patch jump_label at %pS", > + (void *)jump_entry_code(entry)); > return false; > } > > -- > 2.21.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel