From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD9BDC3A5A1 for ; Thu, 22 Aug 2019 19:57:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 818C32339F for ; Thu, 22 Aug 2019 19:57:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="J8pnKrZN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 818C32339F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uRS2NyaZw7V+EpzMcuwqKXO8PUeFUgj6qbReFACg9YE=; b=J8pnKrZNQ6p9Wf eQWqMp8UFHOtmvaa7VM7zB1gabUh3zf5TnKFYBne2hbKylsmI9jFpQUAbxdCwEWMIMkpcYZlBEBMB 68Lh3prCbF4AhSOeusvbwlEg6rh/idNz7sfTNXci33KxjQjx8tniorgDj4ubmWtYqCedZKj67qBVb rHGV3syfCCWDOmg8KIPOZat34/orBRxqxzrJF+W5FWl8Ep9PYQKZJxTSWuitTm+QVSswqHarf2yj6 o7DaeSEgaPY82/HnQ9wEoFIEGq9cYBSB4HkAJQ+0viMdAeIVdXSY5fRPHGTKWyleokhGAMSweAZSS rtCBRSTVYxamQsIFEyCQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i0tD6-0005qe-QB; Thu, 22 Aug 2019 19:57:28 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i0tD4-0005iW-7W for linux-arm-kernel@lists.infradead.org; Thu, 22 Aug 2019 19:57:27 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DE167A2BDB4; Thu, 22 Aug 2019 19:57:25 +0000 (UTC) Received: from treble (ovpn-121-55.rdu2.redhat.com [10.10.121.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CD5C060925; Thu, 22 Aug 2019 19:57:24 +0000 (UTC) Date: Thu, 22 Aug 2019 14:57:22 -0500 From: Josh Poimboeuf To: Raphael Gault Subject: Re: [RFC v4 01/18] objtool: Add abstraction for computation of symbols offsets Message-ID: <20190822195722.gx36v32x2zfythwy@treble> References: <20190816122403.14994-1-raphael.gault@arm.com> <20190816122403.14994-2-raphael.gault@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190816122403.14994-2-raphael.gault@arm.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Thu, 22 Aug 2019 19:57:26 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190822_125726_301913_C2D76795 X-CRM114-Status: GOOD ( 14.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: raph.gault+kdev@gmail.com, peterz@infradead.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, julien.thierry.kdev@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 16, 2019 at 01:23:46PM +0100, Raphael Gault wrote: > @@ -672,14 +672,19 @@ static int add_call_destinations(struct objtool_file *file) > } > > } else if (rela->sym->type == STT_SECTION) { > + /* > + * the original x86_64 code adds 4 to the rela->addend > + * which is not needed on arm64 architecture. > + */ > + dest_off = arch_dest_rela_offset(rela->addend); I agree with Julien that this comment isn't needed. The "arch_" prefix already implies there are arch-specific differences. Also, this patch should replace all the other "addend + 4" usages: $ git grep "addend + 4" tools/objtool tools/objtool/arch/x86/decode.c: return addend + 4; tools/objtool/check.c: dest_off = rela->addend + 4; tools/objtool/check.c: dest_off = rela->sym->sym.st_value + rela->addend + 4; -- Josh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel