From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 454E8C3A5A2 for ; Fri, 23 Aug 2019 08:38:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 165A222CEC for ; Fri, 23 Aug 2019 08:38:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qHztEP6c"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="lo91WDqM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 165A222CEC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yPRDjhnSNU8QV/dB3DH1rxdBh2GjEPcOWAdjCJYvhSE=; b=qHztEP6clkddA5 XaqwzOoYR2lX1692Pzb5ebDSSPVTchBUjWYOdDH3uvhCOPpmOYbC0SdNImvHiIf0skeU2pSPOxSRc gKAh5MMBM3eOaiR+U6eKmqLLIjn+5NU3acOgdn9MKr+3JliaCve0chmKefjCHpIY+wK9oTdWbNjEO 0FUpqGL6HCI25Bh0pKIH+LpW5fhhjv0lXASl3/NpUAcWwutCP1Zn9HnTTC1a6c3ilDHZ2r9xbcNXa rDb3BOHRhACRp3qB4mVDw3huDT0gV+kuW02JmTIgakNHVfTwFwJoNR776I9Smz/wq7rAwy8V+g4pU Omzm5Czn5Yps7LaqaXUA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i1555-0006qZ-MF; Fri, 23 Aug 2019 08:37:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i154Q-0006F7-AC for linux-arm-kernel@lists.infradead.org; Fri, 23 Aug 2019 08:37:21 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 599C922CEC; Fri, 23 Aug 2019 08:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566549437; bh=niV7neuzYojJdHn0ExBeb264ApqQ6IcTCNkFCeK4d+o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lo91WDqMkrMHkBSpDl1bj3ZG5vGkzmlVPsKy2PaOuAhB8vy9ujjPpFGPC4MW4h1cU FqIft2qhTQzKucvJeqF4/BmwPJnFE6ZTbwpi6UEqDCdTaOKZIBGoqdX2OJd+jeeDPo mCmk/FFGHESA6BxwLZTCKFbsPfstWev8YNa/jqlg= Date: Fri, 23 Aug 2019 09:37:13 +0100 From: Will Deacon To: "Leizhen (ThunderTown)" Subject: Re: [PATCH v3 0/2] improve the concurrency of arm_smmu_atc_inv_domain() Message-ID: <20190823083712.ggzmw3rcodwyhmlf@willie-the-truck> References: <20190823024551.24448-1-thunder.leizhen@huawei.com> <20190823075026.pwlx33e4crh3m6tn@willie-the-truck> <7e28e1ce-2cc3-3c7f-45c7-e7de334c6976@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7e28e1ce-2cc3-3c7f-45c7-e7de334c6976@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190823_013718_439063_D0FBC729 X-CRM114-Status: GOOD ( 15.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jean-Philippe Brucker , Joerg Roedel , John Garry , iommu , Robin Murphy , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 23, 2019 at 04:06:52PM +0800, Leizhen (ThunderTown) wrote: > > > On 2019/8/23 15:50, Will Deacon wrote: > > On Fri, Aug 23, 2019 at 10:45:49AM +0800, Zhen Lei wrote: > >> v2 --> v3: > >> As Will Deacon's suggestion, I changed the lock type of > >> arm_smmu_domain.devices_lock from spinlock_t to rwlock_t, and I saw that the > >> performance is all right. And further use nr_ats_masters to quickly check have > >> no obvious effect, so I drop it. > > > > :/ > > > > I already sent two versions of a series fixing this without any locking at > > all on the ->unmap() path, and you were on cc. I've also queued that stuff > > up. > > > > Did you not receive my patches? > Sorry, my message filter setting is a bit wrong, must contains > "linux-kernel@vger.kernel.org", I have corrected it. Ha, sounds like the opposite of my email filter ;) > > v1: https://lists.linuxfoundation.org/pipermail/iommu/2019-August/038306.html > > v2: https://lists.linuxfoundation.org/pipermail/iommu/2019-August/038374.html > OK, I will test it when it's my turn to use the board. Thanks, although I plan to send it to Joerg today so any changes will need to go on top. Does your testing involve ATS, or just non-ATS devices? I've tested the latter locally, although I haven't looked at the performance since most of the patches are trying to fix the enable/disable ordering. Thanks, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel