From: Andrew Murray <andrew.murray@arm.com> To: Xiaowei Bao <xiaowei.bao@nxp.com> Cc: mark.rutland@arm.com, roy.zang@nxp.com, lorenzo.pieralisi@arm.co, arnd@arndb.de, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, minghuan.Lian@nxp.com, robh+dt@kernel.org, gustavo.pimentel@synopsys.com, jingoohan1@gmail.com, bhelgaas@google.com, leoyang.li@nxp.com, shawnguo@kernel.org, mingkai.hu@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 03/10] PCI: designware-ep: Move the function of getting MSI capability forward Date: Fri, 23 Aug 2019 14:38:38 +0100 Message-ID: <20190823133837.GF14582@e119886-lin.cambridge.arm.com> (raw) In-Reply-To: <20190822112242.16309-3-xiaowei.bao@nxp.com> On Thu, Aug 22, 2019 at 07:22:35PM +0800, Xiaowei Bao wrote: > Move the function of getting MSI capability to the front of init > function, because the init function of the EP platform driver will use > the return value by the function of getting MSI capability. > > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com> Reviewed-by: Andrew Murray <andrew.murray@arm.com> > --- > v2: > - No change. > > drivers/pci/controller/dwc/pcie-designware-ep.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c > index b8388f8..0a6c199 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c > @@ -656,6 +656,10 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) > if (ret < 0) > epc->max_functions = 1; > > + ep->msi_cap = dw_pcie_ep_find_capability(pci, PCI_CAP_ID_MSI); > + > + ep->msix_cap = dw_pcie_ep_find_capability(pci, PCI_CAP_ID_MSIX); > + > if (ep->ops->ep_init) > ep->ops->ep_init(ep); > > @@ -672,9 +676,6 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) > dev_err(dev, "Failed to reserve memory for MSI/MSI-X\n"); > return -ENOMEM; > } > - ep->msi_cap = dw_pcie_ep_find_capability(pci, PCI_CAP_ID_MSI); > - > - ep->msix_cap = dw_pcie_ep_find_capability(pci, PCI_CAP_ID_MSIX); > > offset = dw_pcie_ep_find_ext_capability(pci, PCI_EXT_CAP_ID_REBAR); > if (offset) { > -- > 2.9.5 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply index Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-22 11:22 [PATCH v2 01/10] PCI: designware-ep: Add multiple PFs support for DWC Xiaowei Bao 2019-08-22 11:22 ` [PATCH v2 02/10] PCI: designware-ep: Add the doorbell mode of MSI-X in EP mode Xiaowei Bao 2019-08-23 13:35 ` Andrew Murray 2019-08-23 23:51 ` Xiaowei Bao 2019-08-22 11:22 ` [PATCH v2 03/10] PCI: designware-ep: Move the function of getting MSI capability forward Xiaowei Bao 2019-08-23 13:38 ` Andrew Murray [this message] 2019-08-24 0:20 ` Xiaowei Bao 2019-08-22 11:22 ` [PATCH v2 04/10] dt-bindings: pci: layerscape-pci: add compatible strings for ls1088a and ls2088a Xiaowei Bao 2019-08-27 22:26 ` Rob Herring 2019-08-29 9:19 ` Xiaowei Bao 2019-08-22 11:22 ` [PATCH v2 05/10] PCI: layerscape: Fix some format issue of the code Xiaowei Bao 2019-08-23 13:45 ` Andrew Murray 2019-08-24 0:00 ` Xiaowei Bao 2019-08-22 11:22 ` [PATCH v2 06/10] PCI: layerscape: Modify the way of getting capability with different PEX Xiaowei Bao 2019-08-22 11:43 ` Kishon Vijay Abraham I 2019-08-23 2:39 ` Xiaowei Bao 2019-08-23 3:39 ` Kishon Vijay Abraham I 2019-08-23 4:13 ` Xiaowei Bao 2019-09-02 13:36 ` Andrew Murray 2019-09-03 2:11 ` Xiaowei Bao 2019-08-22 11:22 ` [PATCH v2 07/10] PCI: layerscape: Modify the MSIX to the doorbell way Xiaowei Bao 2019-08-23 13:58 ` Andrew Murray 2019-08-24 0:08 ` Xiaowei Bao 2019-08-27 13:25 ` Andrew Murray 2019-08-28 2:49 ` Xiaowei Bao 2019-08-29 5:13 ` Kishon Vijay Abraham I 2019-11-05 12:37 ` Lorenzo Pieralisi 2019-11-06 9:33 ` Xiaowei Bao 2019-11-06 9:40 ` Gustavo Pimentel 2019-11-06 10:03 ` Xiaowei Bao 2019-11-06 13:39 ` Kishon Vijay Abraham I 2019-11-06 15:40 ` Gustavo Pimentel 2019-08-22 11:22 ` [PATCH v2 08/10] PCI: layerscape: Add EP mode support for ls1088a and ls2088a Xiaowei Bao 2019-08-23 14:27 ` Andrew Murray 2019-08-24 0:18 ` Xiaowei Bao 2019-08-24 6:45 ` christophe leroy 2019-08-25 3:07 ` Xiaowei Bao 2019-08-27 14:48 ` Andrew Murray 2019-08-28 3:25 ` Xiaowei Bao 2019-08-26 9:49 ` Xiaowei Bao 2019-08-27 13:34 ` Andrew Murray 2019-08-28 4:29 ` Xiaowei Bao 2019-08-28 9:01 ` Andrew Murray 2019-08-29 2:03 ` Xiaowei Bao 2019-08-22 11:22 ` [PATCH v2 09/10] arm64: dts: layerscape: Add PCIe EP node for ls1088a Xiaowei Bao 2019-08-22 11:22 ` [PATCH v2 10/10] misc: pci_endpoint_test: Add LS1088a in pci_device_id table Xiaowei Bao 2019-08-23 13:25 ` [PATCH v2 01/10] PCI: designware-ep: Add multiple PFs support for DWC Andrew Murray 2019-08-23 23:50 ` Xiaowei Bao 2019-08-27 13:10 ` Andrew Murray 2019-08-28 7:22 ` Xiaowei Bao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190823133837.GF14582@e119886-lin.cambridge.arm.com \ --to=andrew.murray@arm.com \ --cc=arnd@arndb.de \ --cc=bhelgaas@google.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=gustavo.pimentel@synopsys.com \ --cc=jingoohan1@gmail.com \ --cc=kishon@ti.com \ --cc=leoyang.li@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=lorenzo.pieralisi@arm.co \ --cc=mark.rutland@arm.com \ --cc=minghuan.Lian@nxp.com \ --cc=mingkai.hu@nxp.com \ --cc=robh+dt@kernel.org \ --cc=roy.zang@nxp.com \ --cc=shawnguo@kernel.org \ --cc=xiaowei.bao@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ARM-Kernel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \ linux-arm-kernel@lists.infradead.org public-inbox-index linux-arm-kernel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git