From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EADECC3A59E for ; Sat, 24 Aug 2019 09:12:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDB3E20870 for ; Sat, 24 Aug 2019 09:12:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FvfSoRC+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="mLioaqdQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDB3E20870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ptx41a7Z5q+xiJ5CV95vcODc/l4rDrAdGTwooGAl5uk=; b=FvfSoRC+kPuHly zShLTWk7f8zgXZ+O5AALyxtE6bFIOUjX31XVQEZcyko/XcuTO71wWUxSeq+9+QZK3g4N+hCMr1CRm Vn0cS4RYHWWtR3phxi33w8APJt7hKgO73PPikjZmQWK7Uj8VN5kZVhrQzzV+iP7bOM71kbfm5oGEQ 80D4CKjiIeyU4b4P+1x0jQAafi09qEqjMs+DHLVgkPSvilAcaOjVcn2yz2cAHDV+HyIJ6U7EIdy6D 0gK9XmPI/C53eorOlnjZv3dYA8vWonH5uUXQiUdQMoardlOODa46CJiNFGS9GasJOB64PR/vWJgkz t2nuxeYlOxhBBFCl5Kyw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i1S5H-0005ed-Ph; Sat, 24 Aug 2019 09:11:43 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i1S5C-0005e3-Kf; Sat, 24 Aug 2019 09:11:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=35I2LZAPShB6Cj6P1TUgP57NLp4slH9dw71QCTasf9w=; b=mLioaqdQuJrNX1/NOkC7pA8My Ryo55kL3A7U7vH8bgvzRZRnYXeZ2hRuR+aV+Sc3CBEDrBRmT35v1S4u6kcoA16cth4z8CJTm6ymbD 8WNI/0PSz/PSa2MVjCktPfJYME3Y3RZPoAOyP/skC54IPikXx2zLBOF2tH7vrGDyfBW0ZLCSY6og5 +OvoFmwhMZbpHFxXBxrW3v60B6ExenZlhuYUSmpKggb28NJIaq+yDZpiI9Xx3Iym4pGP1vujJZkaM Hrh7+UUsjFRODb6McAKxgR1p8fT+POTuIuy8aMHnD2pXhRqNR169RFR1NJ3NGxJkNUHXdGvRkZx6K SMP73liAA==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:53936) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1i1S4m-00029T-5T; Sat, 24 Aug 2019 10:11:12 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1i1S4g-0002Ql-9j; Sat, 24 Aug 2019 10:11:06 +0100 Date: Sat, 24 Aug 2019 10:11:06 +0100 From: Russell King - ARM Linux admin To: =?iso-8859-1?Q?Ren=E9?= van Dorst Subject: Re: [PATCH net-next v3 1/3] net: ethernet: mediatek: Add basic PHYLINK support Message-ID: <20190824091106.GC13294@shell.armlinux.org.uk> References: <20190823134516.27559-1-opensource@vdorst.com> <20190823134516.27559-2-opensource@vdorst.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190823134516.27559-2-opensource@vdorst.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190824_021139_039800_648B9B3C X-CRM114-Status: UNSURE ( 8.57 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nelson Chang , Frank Wunderlich , netdev@vger.kernel.org, Sean Wang , linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, John Crispin , Matthias Brugger , Stefan Roese , "David S . Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 23, 2019 at 03:45:14PM +0200, Ren=E9 van Dorst wrote: > This convert the basics to PHYLINK API. > SGMII support is not in this patch. > = > Signed-off-by: Ren=E9 van Dorst > -- > v2->v3: > * Make link_down() similar as link_up() suggested by Russell King Yep, almost there, but... > +static void mtk_mac_link_down(struct phylink_config *config, unsigned in= t mode, > + phy_interface_t interface) > +{ > + struct mtk_mac *mac =3D container_of(config, struct mtk_mac, > + phylink_config); > + u32 mcr =3D mtk_r32(mac->hw, MTK_MAC_MCR(mac->id)); > = > + mcr &=3D (MAC_MCR_TX_EN | MAC_MCR_RX_EN); ... this clears all bits _except_ for the tx and rx enable (which will remain set) - you probably wanted a ~ before the (. -- = RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps = up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel