From: "Ondřej Jirman" <megous@megous.com>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
devicetree@vger.kernel.org,
Maxime Ripard <maxime.ripard@bootlin.com>,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org
Subject: Re: [linux-sunxi] [PATCH v2 0/3] Add basic support for RTC on Allwinner H6 SoC
Date: Sat, 24 Aug 2019 14:56:12 +0200 [thread overview]
Message-ID: <20190824125612.zq5qsay2wv62wykt@core.my.home> (raw)
In-Reply-To: <5421621.t8Lore9UF7@jernej-laptop>
Hi,
On Sat, Aug 24, 2019 at 10:06:14AM +0200, Jernej Škrabec wrote:
> Dne sobota, 24. avgust 2019 ob 10:04:24 CEST je Jernej Škrabec napisal(a):
> > Hi!
> >
> > Dne torek, 20. avgust 2019 ob 17:19:31 CEST je megous@megous.com napisal(a):
> > > From: Ondrej Jirman <megous@megous.com>
> > >
> > > I went through the datasheets for H6 and H5, and compared the differences.
> > > RTCs are largely similar, but not entirely compatible. Incompatibilities
> > > are in details not yet implemented by the rtc driver though.
> > >
> > > I also corrected the clock tree in H6 DTSI.
> > >
> > > This patchset is necessary for implementing the WiFi/Bluetooth support
> > > on boards using H6 SoC.
> > >
> > > There was some discussion previously of describing HOSC, DCXO and XO
> > > oscillators and clocks as part of RTC in DT, but I decided against it
> > > because it's not necessary, becuse information that would be provided
> > > as a part of DT can already be determined at runtime from RTC registers,
> > > so this woudn't add any value and would only introduce complications
> > > to the driver. See: https://patchwork.kernel.org/cover/10898083/
> > >
> > > Please take a look.
> > >
> > >
> > > Thank you and regards,
> > >
> > > Ondrej Jirman
> >
> > Sorry for a bit late test, but with your patches on Tanix TX6 box I get this
> > in dmesg:
> >
> > [ 17.431742] sun6i-rtc 7000000.rtc: Failed to set rtc time.
> > [ 20.439742] sun6i-rtc 7000000.rtc: rtc is still busy.
> > [ 21.435744] sun6i-rtc 7000000.rtc: rtc is still busy.
> > [ 24.055741] sun6i-rtc 7000000.rtc: rtc is still busy.
> > [ 24.439752] sun6i-rtc 7000000.rtc: rtc is still busy.
> >
> > Last line is repeated non-stop.
> >
> > Any idea what could be wrong?
>
> Additional info - this is on kernel 5.2.6 with your patches applied.
Do you have schematics, or a FEX file for the board or any other info on how the
RTC is set up on that board?
Can you dump the RTC register range?
regards,
o.
> Best regards,
> Jernej
>
>
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-24 12:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 15:19 [PATCH v2 0/3] Add basic support for RTC on Allwinner H6 SoC megous
2019-08-20 15:19 ` [PATCH v2 1/3] dt-bindings: Add compatible for H6 RTC megous
2019-08-22 21:15 ` Alexandre Belloni
2019-08-20 15:19 ` [PATCH v2 2/3] rtc: sun6i: Add support " megous
2019-08-22 21:16 ` Alexandre Belloni
2019-08-24 12:32 ` [linux-sunxi] " Jernej Škrabec
2019-08-24 12:46 ` Ondřej Jirman
2019-08-24 12:51 ` Jernej Škrabec
2019-08-24 13:05 ` Ondřej Jirman
2019-08-24 13:16 ` Jernej Škrabec
2019-08-24 13:30 ` Ondřej Jirman
2019-08-24 21:09 ` Jernej Škrabec
2019-08-24 21:27 ` Ondřej Jirman
2019-08-24 21:36 ` Jernej Škrabec
2019-08-24 22:16 ` Ondřej Jirman
2019-08-20 15:19 ` [PATCH v2 3/3] arm64: dts: sun50i-h6: Add support for RTC and fix the clock tree megous
2019-08-23 8:19 ` Maxime Ripard
2019-08-24 8:04 ` [linux-sunxi] [PATCH v2 0/3] Add basic support for RTC on Allwinner H6 SoC Jernej Škrabec
2019-08-24 8:06 ` Jernej Škrabec
2019-08-24 12:56 ` Ondřej Jirman [this message]
2019-08-24 12:58 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190824125612.zq5qsay2wv62wykt@core.my.home \
--to=megous@megous.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).