From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Yan Markman <ymarkman@marvell.com>,
Antoine Tenart <antoine.tenart@bootlin.com>,
Grzegorz Jaszczyk <jaz@semihalf.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Nadav Haklai <nadavh@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Stefan Chulski <stefanc@marvell.com>,
Marcin Wojtas <mw@semihalf.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 16/20] dt-bindings: marvell: Declare the CN913x SoC compatibles
Date: Sat, 24 Aug 2019 13:30:36 +0200 [thread overview]
Message-ID: <20190824133036.798da540@xps13> (raw)
In-Reply-To: <20190821193726.GA32220@bogus>
Hi Rob,
Rob Herring <robh@kernel.org> wrote on Wed, 21 Aug 2019 14:37:26 -0500:
> On Tue, Aug 06, 2019 at 04:54:56PM +0200, Miquel Raynal wrote:
> > From: Grzegorz Jaszczyk <jaz@semihalf.com>
> >
> > Describe the compatible properties for the new Marvell SoCs:
> > * CN9130: 1x AP807-quad + 1x CP115 (1x embedded)
> > * CN9131: 1x AP807-quad + 2x CP115 (1x embedded + 1x modular)
> > * CN9132: 1x AP807-quad + 3x CP115 (1x embedded + 2x modular)
> >
> > CP115 are similar to CP110 in terms of features.
> >
> > There are three development boards based on these SoCs:
> > * CN9130-DB: comes as a single mother board (with the CP115 bundled)
> > * CN9131-DB: same as CN9130-DB with one additional modular CP115
> > * CN9132-DB: same as CN9130-DB with two additional modular CP115
> >
> > Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > .../bindings/arm/marvell/armada-7k-8k.txt | 13 ++++++++++++-
> > 1 file changed, 12 insertions(+), 1 deletion(-)
>
> Please convert this to DT schema first.
As you wish.
>
> >
> > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.txt b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.txt
> > index df98a9c82a8c..8eb34ca4c4f0 100644
> > --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.txt
> > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.txt
> > @@ -1,7 +1,7 @@
> > Marvell Armada 7K/8K Platforms Device Tree Bindings
> > ---------------------------------------------------
> >
> > -Boards using a SoC of the Marvell Armada 7K or 8K families must carry
> > +Boards using a SoC of the Marvell Armada 7K/8K or CN913x families must carry
> > the following root node property:
> >
> > - compatible, with one of the following values:
> > @@ -18,6 +18,17 @@ the following root node property:
> > - "marvell,armada8040", "marvell,armada-ap806-quad", "marvell,armada-ap806"
> > when the SoC being used is the Armada 8040
> >
> > + - "marvell,cn9130", "marvell,armada-ap807-quad", "marvell,armada-ap807"
> > + when the SoC being used is the Armada CN9130 with no external CP.
> > +
> > + - "marvell,cn9131", "marvell,cn9130",
> > + "marvell,armada-ap807-quad", "marvell,armada-ap807"
> > + when the SoC being used is the Armada CN9130 with one external CP.
> > +
> > + - "marvell,cn9132", "marvell,cn9131", "marvell,cn9130",
> > + "marvell,armada-ap807-quad", "marvell,armada-ap807"
>
> It's generally not all that useful to have all these compatibles.
>
> > + when the SoC being used is the Armada CN9130 with two external CPs.
>
> Is the number of external CPs not discoverable somewhere else in the DT?
I don't think so.
What do you suggest? Keep only the marvell,cn9130 compatible? I am not
sure having the three compatibles is actually useful but for the reader
I find it more friendly. Of course the model name will reflect the
number of external CP but from a computational point of view that's
hard to parse if needed.
>
> > +
> > Example:
> >
> > compatible = "marvell,armada7040-db", "marvell,armada7040",
> > --
> > 2.20.1
> >
Thanks,
Miquèl
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-24 11:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 14:54 [PATCH 00/20] Add new Marvell CN9130 SoC support Miquel Raynal
2019-08-06 14:54 ` [PATCH 01/20] arm64: dts: marvell: Enumerate the first AP806 syscon Miquel Raynal
2019-08-06 14:54 ` [PATCH 02/20] arm64: dts: marvell: Add AP806-dual missing CPU clocks Miquel Raynal
2019-08-06 14:54 ` [PATCH 03/20] dt-bindings: ap80x: replace AP806 with AP80x Miquel Raynal
2019-08-21 19:32 ` Rob Herring
2019-08-06 14:54 ` [PATCH 04/20] MAINTAINERS: Add new Marvell CN9130-based files to track Miquel Raynal
2019-08-06 14:54 ` [PATCH 05/20] arm64: dts: marvell: Prepare the introduction of AP807 based SoCs Miquel Raynal
2019-08-27 15:20 ` Gregory CLEMENT
2019-08-06 14:54 ` [PATCH 06/20] arm64: dts: marvell: Move clocks to AP806 specific file Miquel Raynal
2019-08-06 14:54 ` [PATCH 07/20] arm64: dts: marvell: Add support for AP807/AP807-quad Miquel Raynal
2019-08-06 14:54 ` [PATCH 08/20] arm64: dts: marvell: Add AP806-dual cache description Miquel Raynal
2019-08-06 14:54 ` [PATCH 09/20] arm64: dts: marvell: Add AP806-quad " Miquel Raynal
2019-08-06 14:54 ` [PATCH 10/20] arm64: dts: marvell: Add AP807-quad " Miquel Raynal
2019-08-06 14:54 ` [PATCH 11/20] arm64: dts: marvell: Fix CP110 NAND controller node multi-line comment alignment Miquel Raynal
2019-08-06 14:54 ` [PATCH 12/20] arm64: dts: marvell: Prepare the introduction of CP115 Miquel Raynal
2019-08-06 14:54 ` [PATCH 13/20] arm64: dts: marvell: Drop PCIe I/O ranges from CP11x file Miquel Raynal
2019-08-06 14:54 ` [PATCH 14/20] arm64: dts: marvell: Externalize PCIe macros " Miquel Raynal
2019-08-06 14:54 ` [PATCH 15/20] arm64: dts: marvell: Add support for CP115 Miquel Raynal
2019-08-06 14:54 ` [PATCH 16/20] dt-bindings: marvell: Declare the CN913x SoC compatibles Miquel Raynal
2019-08-21 19:37 ` Rob Herring
2019-08-24 11:30 ` Miquel Raynal [this message]
2019-08-06 14:54 ` [PATCH 17/20] arm64: dts: marvell: Add support for Marvell CN9130 SoC support Miquel Raynal
2019-08-06 14:54 ` [PATCH 18/20] arm64: dts: marvell: Add support for Marvell CN9130-DB Miquel Raynal
2019-08-06 14:54 ` [PATCH 19/20] arm64: dts: marvell: Add support for Marvell CN9131-DB Miquel Raynal
2019-08-06 14:55 ` [PATCH 20/20] arm64: dts: marvell: Add support for Marvell CN9132-DB Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190824133036.798da540@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=antoine.tenart@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=jaz@semihalf.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=robh@kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=ymarkman@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).