Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] soc: imx: gpcv2: Print the correct error code
@ 2019-08-21 16:33 Guido Günther
  2019-08-22  8:12 ` Daniel Baluta
  2019-08-24 20:41 ` Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Guido Günther @ 2019-08-21 16:33 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Lucas Stach, Anson Huang, Andrey Smirnov,
	Rob Herring, Guido Günther, linux-arm-kernel, linux-kernel

The current code prints 'ret' (thus 0) while it should use 'err'.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
 drivers/soc/imx/gpcv2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
index 31b8d002d855..b0dffb06c05d 100644
--- a/drivers/soc/imx/gpcv2.c
+++ b/drivers/soc/imx/gpcv2.c
@@ -198,7 +198,7 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct generic_pm_domain *genpd,
 		err = regulator_disable(domain->regulator);
 		if (err)
 			dev_err(domain->dev,
-				"failed to disable regulator: %d\n", ret);
+				"failed to disable regulator: %d\n", err);
 		/* Preserve earlier error code */
 		ret = ret ?: err;
 	}
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] soc: imx: gpcv2: Print the correct error code
  2019-08-21 16:33 [PATCH] soc: imx: gpcv2: Print the correct error code Guido Günther
@ 2019-08-22  8:12 ` Daniel Baluta
  2019-08-24 20:41 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Baluta @ 2019-08-22  8:12 UTC (permalink / raw)
  To: dl-linux-imx, linux-kernel, festevam, agx, robh, shawnguo,
	andrew.smirnov, Anson Huang, linux-arm-kernel, l.stach, kernel,
	s.hauer

On Wed, 2019-08-21 at 18:33 +0200, Guido Günther wrote:
> The current code prints 'ret' (thus 0) while it should use 'err'.
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>

Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>

> ---
>  drivers/soc/imx/gpcv2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
> index 31b8d002d855..b0dffb06c05d 100644
> --- a/drivers/soc/imx/gpcv2.c
> +++ b/drivers/soc/imx/gpcv2.c
> @@ -198,7 +198,7 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct
> generic_pm_domain *genpd,
>  		err = regulator_disable(domain->regulator);
>  		if (err)
>  			dev_err(domain->dev,
> -				"failed to disable regulator: %d\n",
> ret);
> +				"failed to disable regulator: %d\n",
> err);
>  		/* Preserve earlier error code */
>  		ret = ret ?: err;
>  	}
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] soc: imx: gpcv2: Print the correct error code
  2019-08-21 16:33 [PATCH] soc: imx: gpcv2: Print the correct error code Guido Günther
  2019-08-22  8:12 ` Daniel Baluta
@ 2019-08-24 20:41 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2019-08-24 20:41 UTC (permalink / raw)
  To: Guido Günther
  Cc: Rob Herring, Anson Huang, Andrey Smirnov, Sascha Hauer,
	linux-kernel, NXP Linux Team, Pengutronix Kernel Team,
	Fabio Estevam, linux-arm-kernel, Lucas Stach

On Wed, Aug 21, 2019 at 06:33:04PM +0200, Guido Günther wrote:
> The current code prints 'ret' (thus 0) while it should use 'err'.
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>

Applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-21 16:33 [PATCH] soc: imx: gpcv2: Print the correct error code Guido Günther
2019-08-22  8:12 ` Daniel Baluta
2019-08-24 20:41 ` Shawn Guo

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox