From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C16BCC3A59F for ; Mon, 26 Aug 2019 11:54:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 940EE2070B for ; Mon, 26 Aug 2019 11:54:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uH+fWMSL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 940EE2070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=iki.fi Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HTfttV46N/Ayq87Yi6x6aAGF5O4gjft1ZtgfnpIjHy0=; b=uH+fWMSLY7lH9X 2IU9njAxp05C2uHCrw7snqxi8HE+lmDGzECfb5xSSHxsXYdMiG/6xEuXCPUML5/04S90fjHqdCRHd pzopGLu62rQ+MXDJiI+j6LpFU5SW2+TDpWown6BH+USbGIi8EsD45sEBHi7q3SiDEPxvMftMHsw7/ NmqH5dcsx8Ra69LrexIKoIIMV9zprrEsprtiDQgQQZH8SR1BAjxehnfhEUBN1a9xf9CDSs7BJkAX8 EBS/H4uSf0oHwA04FKWWlWeziNuNi5sMrVyg6hQgRbcCMC8ompT8v/FHZngT9tYhaedb7K3fOlB1J tzbY6nrHikfBzF6uH2CQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2Da5-00009C-PX; Mon, 26 Aug 2019 11:54:41 +0000 Received: from hillosipuli.retiisi.org.uk ([2a01:4f9:c010:4572::81:2]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i2Da2-00008B-Su; Mon, 26 Aug 2019 11:54:40 +0000 Received: from valkosipuli.localdomain (valkosipuli.retiisi.org.uk [IPv6:2a01:4f9:c010:4572::80:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id 9D982634C87; Mon, 26 Aug 2019 14:52:19 +0300 (EEST) Received: from sailus by valkosipuli.localdomain with local (Exim 4.92) (envelope-from ) id 1i2DXn-0000Nt-H1; Mon, 26 Aug 2019 14:52:19 +0300 Date: Mon, 26 Aug 2019 14:52:19 +0300 From: Sakari Ailus To: Louis Kuo Subject: Re: [RFC PATCH V3 3/4] dt-bindings: mt8183: Add sensor interface dt-bindings Message-ID: <20190826115219.GB826@valkosipuli.retiisi.org.uk> References: <1559815233-24796-1-git-send-email-louis.kuo@mediatek.com> <1559815233-24796-4-git-send-email-louis.kuo@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1559815233-24796-4-git-send-email-louis.kuo@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190826_045439_290830_1D21C39B X-CRM114-Status: GOOD ( 18.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Sean.Cheng@mediatek.com, laurent.pinchart+renesas@ideasonboard.com, Rynn.Wu@mediatek.com, christie.yu@mediatek.com, srv_heupstream@mediatek.com, holmes.chiou@mediatek.com, Jerry-ch.Chen@mediatek.com, tfiga@chromium.org, keiichiw@chromium.org, jungo.lin@mediatek.com, sj.huang@mediatek.com, yuzhao@chromium.org, hans.verkuil@cisco.com, zwisler@chromium.org, frederic.chen@mediatek.com, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Louis, On Thu, Jun 06, 2019 at 06:00:32PM +0800, Louis Kuo wrote: > This patch adds the DT binding documentation for the sensor interface > module in Mediatek SoCs. > > Signed-off-by: Louis Kuo > --- > .../devicetree/bindings/media/mediatek-seninf.txt | 31 ++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek-seninf.txt > > diff --git a/Documentation/devicetree/bindings/media/mediatek-seninf.txt b/Documentation/devicetree/bindings/media/mediatek-seninf.txt > new file mode 100644 > index 0000000..979063a > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/mediatek-seninf.txt > @@ -0,0 +1,31 @@ > +* Mediatek seninf MIPI-CSI2 host driver Note that DT bindings document the hardware, not the driver implementation. > + > +Seninf MIPI-CSI2 host driver is a HW camera interface controller. It support a widely adopted, Same here; driver apparently refers to software. Please wrap before or at 80 characters per line. > +simple, high-speed protocol primarily intended for point-to-point image and video > +transmission between cameras and host devices. Could you elaborate the properties of the hardware in a bit more detail, such as how many ports there are and how many lanes they can support? See e.g. Documentation/devicetree/bindings/media/ti,omap3isp.txt . Please also refer to video-interfaces.txt and document the port nodes and the relevant properties in the endpoint nodes, as in the binding example I referred to. > + > +Required properties: > + - compatible: "mediatek,mt8183-seninf" > + - reg: Must contain an entry for each entry in reg-names. > + - reg-names: Must include the following entries: > + "base_reg": seninf registers base > + "rx_reg": Rx analog registers base > + - interrupts: interrupt number to the cpu. > + - clocks : clock name from clock manager > + - clock-names: must be CLK_CAM_SENINF and CLK_TOP_MUX_SENINF. > + It is the clocks of seninf > + > +Example: > + seninf: seninf@1a040000 { > + compatible = "mediatek,mt8183-seninf"; > + reg = <0 0x1a040000 0 0x8000>, > + <0 0x11C80000 0 0x6000>; > + reg-names = "base_reg", "rx_reg"; > + interrupts = ; > + power-domains = <&scpsys MT8183_POWER_DOMAIN_CAM>; > + clocks = > + <&camsys CLK_CAM_SENINF>, <&topckgen CLK_TOP_MUX_SENINF>; Please wrap before 80 and align the above two lines. > + clock-names = > + "CLK_CAM_SENINF", "CLK_TOP_MUX_SENINF"; No need to wrap here. > + } > + > -- > 1.9.1 This must be old. -- Regards, Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel