From: Andrew Jones <drjones@redhat.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kvm@vger.kernel.org, Suzuki K Poulose <suzuki.poulose@arm.com>,
James Morse <james.morse@arm.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu,
Julien Thierry <julien.thierry.kdev@gmail.com>
Subject: Re: [PATCH 0/3] arm64: KVM: Kiss hyp_alternate_select() goodbye
Date: Mon, 2 Sep 2019 10:34:03 +0200 [thread overview]
Message-ID: <20190902083403.ujiilcurhzrbc4ph@kamzik.brq.redhat.com> (raw)
In-Reply-To: <20190901211237.11673-1-maz@kernel.org>
On Sun, Sep 01, 2019 at 10:12:34PM +0100, Marc Zyngier wrote:
> hyp_alternate_select() is a leftover from the my second attempt at
> supporting VHE (the first one was never merged, thankfully), and is
> now an irrelevant relic. It was a way to patch function pointers
> without having to dereference memory, a bit like static keys for
> function calls.
>
> Lovely idea, but since Christoffer mostly separated the VHE and !VHE
> hypervisor paths, most of the uses of hyp_alternate_select() are
> gone. What is left is two instances that are better replaced by
> already existing static keys. One of the instances becomes
> cpus_have_const_cap(), and the rest is a light sprinkling of
> has_vhe().
>
> So off it goes.
>
> Marc Zyngier (3):
> arm64: KVM: Drop hyp_alternate_select for checking for
> ARM64_WORKAROUND_834220
> arm64: KVM: Replace hyp_alternate_select with has_vhe()
> arm64: KVM: Kill hyp_alternate_select()
>
> arch/arm64/include/asm/kvm_hyp.h | 24 ---------------------
> arch/arm64/kvm/hyp/switch.c | 17 ++-------------
> arch/arm64/kvm/hyp/tlb.c | 36 +++++++++++++++++++-------------
> 3 files changed, 24 insertions(+), 53 deletions(-)
>
> --
> 2.20.1
>
Yay! The 'func()(...)' stuff always gave me cross-eyes.
Reviewed-by: Andrew Jones <drjones@redhat.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-09-02 8:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-01 21:12 [PATCH 0/3] arm64: KVM: Kiss hyp_alternate_select() goodbye Marc Zyngier
2019-09-01 21:12 ` [PATCH 1/3] arm64: KVM: Drop hyp_alternate_select for checking for ARM64_WORKAROUND_834220 Marc Zyngier
2019-09-01 21:12 ` [PATCH 2/3] arm64: KVM: Replace hyp_alternate_select with has_vhe() Marc Zyngier
2019-09-01 21:12 ` [PATCH 3/3] arm64: KVM: Kill hyp_alternate_select() Marc Zyngier
2019-09-02 8:00 ` [PATCH 0/3] arm64: KVM: Kiss hyp_alternate_select() goodbye Christoffer Dall
2019-09-02 8:34 ` Andrew Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902083403.ujiilcurhzrbc4ph@kamzik.brq.redhat.com \
--to=drjones@redhat.com \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).