From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3078DC3A59E for ; Mon, 2 Sep 2019 10:53:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0341721744 for ; Mon, 2 Sep 2019 10:53:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Be27DLWj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0341721744 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g3YxeAPnJFEMZLIQQc8DO6F8Iv3cU5MosqAQxTPVeAU=; b=Be27DLWjtkavzv fvxfCtneDP/iQ1j5y+FqROI2Kkbt5i4knS2GqZoPkploouHg7R0ZHKaHQpUZkKi4Yd1didUiKlkYH q1CJc6jfMwm701ZM0txsnX/k3TDlIy+WA7NpEz97o3LWrt1U332IhSXfRnTkxYr0g5KsNBdyO32Tn AZXAHNH6lgF2/KWVf7+wLVLT3sPgx+xpgy+hAYXmolmw3Fw1euw5u1l2Z62ZEzRwiU83o9lZ2OOoI lZ2xDO037hzJk20EhE5fOAJoz/P/saqqg2Ly7ZiMAofG4NBEVhSZ+875uV5IB/GhsABhSoLWYMBXX 1TwBqBpMw7hOOn0LEfBw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i4jxk-0001mL-7V; Mon, 02 Sep 2019 10:53:32 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i4jxh-0001lj-60 for linux-arm-kernel@lists.infradead.org; Mon, 02 Sep 2019 10:53:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5ACD528; Mon, 2 Sep 2019 03:53:26 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8C6DB3F246; Mon, 2 Sep 2019 03:53:25 -0700 (PDT) Date: Mon, 2 Sep 2019 11:53:23 +0100 From: Dave Martin To: Cristian Marussi Subject: Re: [PATCH v3 00/11] Add arm64/signal initial kselftest support Message-ID: <20190902105322.GL27757@arm.com> References: <20190802170300.20662-1-cristian.marussi@arm.com> <20190813162254.GX10425@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190902_035329_268145_C4C053E5 X-CRM114-Status: GOOD ( 21.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andreyknvl@google.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 30, 2019 at 05:40:42PM +0100, Cristian Marussi wrote: > Hi > > On 13/08/2019 17:22, Dave Martin wrote: > > On Fri, Aug 02, 2019 at 06:02:49PM +0100, Cristian Marussi wrote: > >> Hi > >> > >> this patchset aims to add the initial arch-specific arm64 support to > >> kselftest starting with signals-related test-cases. > >> A common internal test-case layout is proposed which then it is anyway > >> wired-up to the toplevel kselftest Makefile, so that it should be possible > >> at the end to run it on an arm64 target in the usual way with KSFT. > > > > The tests look like a reasonable base overall and something that we can > > extend later as needed. > > > > There are various minor things that need attention -- see my comments on > > the individual patches. Apart for some things that can be factored out, > > I don't think any of it involves redesign. > > > > > > A few general comments: > > > > * Please wrap all commit messages to <= 75 chars, and follow the other > > guidelines about commit messages in > > Documentation/process/submitting-patches.rst). > > > > * Remember to run scripts/checkpatch.pl on your patches. Currently > > various issues are reported: they should mostly be trivial to fix. > > checkpatch does report some false positives, but most of the warnings > > I see look relevant. > > > > Thanks for the review. I addressed latest issues in V4, published now. > > I kept tests verbose (outputting to stderr) as of now. > Removed as a whole standalone build/run. The responses look reasonable, thanks for repost. I'll take a look. [...] Cheers ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel