From: "Pali Rohár" <pali.rohar@gmail.com>
To: Adam Ford <aford173@gmail.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
"Paul Walmsley" <paul@pwsan.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Tony Lindgren" <tony@atomide.com>,
"Russell King" <linux@armlinux.org.uk>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Tero Kristo" <t-kristo@ti.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
"Adam Ford" <adam.ford@logicpd.com>,
arm-soc <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC] ARM: omap3: Enable HWMODS for HW Random Number Generator
Date: Mon, 9 Sep 2019 15:40:33 +0200 [thread overview]
Message-ID: <20190909134033.s26eiurpat3iekse@pali> (raw)
In-Reply-To: <CAHCN7xL-Gfxe0qF5w7BUsHnyhcNNpmCnchdKErnmiqggXfsLWw@mail.gmail.com>
On Monday 09 September 2019 08:37:09 Adam Ford wrote:
> On Mon, Sep 9, 2019 at 7:13 AM Adam Ford <aford173@gmail.com> wrote:
> >
> > On Thu, Sep 5, 2019 at 6:04 PM Tony Lindgren <tony@atomide.com> wrote:
> > >
> > > Hi,
> > >
> > > * Adam Ford <aford173@gmail.com> [190828 15:01]:
> > > > The datasheet for the AM3517 shows the RNG is connected to L4.
> > > > It shows the module address for the RNG is 0x480A0000, and it
> > > > matches the omap2.dtsi description. Since the driver can support
> > > > omap2 and omap4, it seems reasonable to assume the omap3 would
> > > > use the same core for the RNG.
> > > >
> > > > This RFC, mimics much of the omap2 hwmods on the OMAP3. It
> > > > also adds the necessary clock for driving the RNG. Unfortunately,
> > > > it appears non-functional. If anyone has any suggestions on how
> > > > to finish the hwmod (or port it to the newer l4 device tree
> > > > format), feedback is requested.
> > >
> > > Yup I'll take the bait :) The patch below seems to do the trick
> > > for me on dm3730 based on translating your patch to probe with
> > > ti-sysc.
> > >
> > > Not sure about 34xx, it seems we're missing rng_clk? Care
> > > to give it a try and attempt simlar patches for 34xx and
> > > 3517?
> > >
> > > At least I'm not needing the "ti,no-reset-on-init" property
> > > that your patch has a comment for. Maybe that's needed on
> > > some other omap3.
> > >
> > > Oh and this needs to default to status = "disabled" for
> > > HS devices like n900 as it needs to use the omap3-rom-rng.
> > >
> > > Regards,
> > >
> > > Tony
> > >
> > > 8< -----------------------
> > > diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi
> > > --- a/arch/arm/boot/dts/omap36xx.dtsi
> > > +++ b/arch/arm/boot/dts/omap36xx.dtsi
> > > @@ -140,6 +140,29 @@
> > > };
> > > };
> > >
> > > + rng_target: target-module@480a0000 {
> > > + compatible = "ti,sysc-omap2", "ti,sysc";
> > > + reg = <0x480a003c 0x4>,
> > > + <0x480a0040 0x4>,
> > > + <0x480a0044 0x4>;
> > > + reg-names = "rev", "sysc", "syss";
> > > + ti,sysc-mask = <(SYSC_OMAP2_AUTOIDLE)>;
> > > + ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> > > + <SYSC_IDLE_NO>;
> > > + ti,syss-mask = <1>;
> > > + clocks = <&rng_ick>;
> > > + clock-names = "ick";
> > > + #address-cells = <1>;
> > > + #size-cells = <1>;
> > > + ranges = <0 0x480a0000 0x2000>;
> > > +
> > > + rng: rng@0 {
> > > + compatible = "ti,omap2-rng";
> > > + reg = <0x0 0x2000>;
> > > + interrupts = <52>;
> > > + };
> > > + };
> > > +
>
> I applied this on 5.3 and it is working. I assume the same is true in for-next.
>
> Do you want to submit a formal patch? I can mark it as 'tested-by'
> This really helps speed up the startup sequence on boards with sshd
> because it delays for nearly 80 seconds waiting for entropy without
> the hwrng.
Hi! When applying a patch, could you please disable this rng for n900?
In omap3-n900.dts for rng should be status = "disabled" (as Tony already
wrote), similarly like for aes.
Thanks!
> adam
> >
> > Tony,
> >
> > Can you tell me what branch you're using? I am not seeing the note
> > below, so I am not exactly sure what version to base my testing.
> >
> > ada,
> > > /*
> > > * Note that the sysconfig register layout is a subset of the
> > > * "ti,sysc-omap4" type register with just sidle and midle bits
--
Pali Rohár
pali.rohar@gmail.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-09 13:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 15:00 [RFC] ARM: omap3: Enable HWMODS for HW Random Number Generator Adam Ford
2019-09-05 23:04 ` Tony Lindgren
2019-09-09 12:13 ` Adam Ford
2019-09-09 13:37 ` Adam Ford
2019-09-09 13:40 ` Pali Rohár [this message]
2019-09-09 16:35 ` Tony Lindgren
2019-09-09 19:19 ` Adam Ford
2019-09-10 15:48 ` Adam Ford
2019-09-10 16:21 ` Adam Ford
2019-09-10 16:39 ` Pali Rohár
2019-10-22 12:13 ` Adam Ford
2019-10-22 16:06 ` Tony Lindgren
2019-09-10 13:56 ` Adam Ford
2019-09-10 14:37 ` Sebastian Reichel
2019-09-10 14:44 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190909134033.s26eiurpat3iekse@pali \
--to=pali.rohar@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=adam.ford@logicpd.com \
--cc=aford173@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=paul@pwsan.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).