From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4656FC47404 for ; Thu, 12 Sep 2019 13:11:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A6E720856 for ; Thu, 12 Sep 2019 13:11:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Yp9Ya3rs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="pwR5uMri" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A6E720856 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b1quzKCjEPaBP75vlBbsrY+FOLkpM+FVCAyeCy4+dkc=; b=Yp9Ya3rsC+6WAQ DqRYERVdE5Va/HliMYNA9SCfSdqks6rOCcS6RiqQLdJgVot7VRatVFZBkWfYvoEFDEbRkz+zASkhc a4e1zo9Uq7TIxHiFYpivU0//XaBvAKa7T3puJmXpti7z88fzsnGumjXuNYIdWYXNNVpYJ8qyXPpfn j3Fyabv5PKVjvpv+k1KZNVkXjrnzhBOfpm7bzWZaAYHkORnCH95CodKHR8xlZNcUaMNyc+VnOfr7J pH+Ldl34hQGc5t70n0dwHJg2hxdn0GCsiE8nKCtGrt/o8gtfYQTdL382Mepr1Ltb62s/KYsYTJZ2U 1heWlm8mnUi72vgRt2sA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8Ot6-000791-CX; Thu, 12 Sep 2019 13:11:52 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8Ot2-00078G-QF for linux-arm-kernel@lists.infradead.org; Thu, 12 Sep 2019 13:11:50 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2DC3C2084D; Thu, 12 Sep 2019 13:11:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568293908; bh=1BVRp6Jdhq2LIzfXH91FkdH1Pyx1eRvvXJVHjQ5DMrw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pwR5uMriy0MozL8gyPhsCQ6j9MrbR7tKEdL3o9VMuwaAacTIvttZSreG0nYE1A/7m sJnTtIoSHNhRMxBHiYtv9f7iKLVSGDrt9iOTH2xscPYScJmgOMuwYOebUu4fDpOE6A rpbKjPwmaGwU6DBvfsFwrXM/5Fwfr20h6y3KNRC8= Date: Thu, 12 Sep 2019 14:11:44 +0100 From: Will Deacon To: Mark Rutland Subject: Re: [PATCH] arm64: fix function types in COND_SYSCALL Message-ID: <20190912131143.u3rncvqdgx4z3ckz@willie-the-truck> References: <20190910224044.100388-1-samitolvanen@google.com> <20190911151545.GD3360@blommer> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190911151545.GD3360@blommer> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190912_061148_877805_BB104682 X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Kees Cook , Sami Tolvanen , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 11, 2019 at 04:15:46PM +0100, Mark Rutland wrote: > On Tue, Sep 10, 2019 at 03:40:44PM -0700, Sami Tolvanen wrote: > > Define a weak function in COND_SYSCALL instead of a weak alias to > > sys_ni_syscall, which has an incompatible type. This fixes indirect > > call mismatches with Control-Flow Integrity (CFI) checking. > > > > Signed-off-by: Sami Tolvanen > > This looks correct to me, builds fine, and I asume has been tested, so FWIW: > > Acked-by: Mark Rutland > > In looking at this, I came to the conclusion that we can drop the ifdeffery > around our SYSCALL_DEFINE0(), COND_SYSCALL(), and SYS_NI(), which I evidently > cargo-culted from x86 (where the ifdeffery is actually necessary). Curious: why is it required on x86? > I can send a follow up for that. Yes, please. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel