From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF293C49ED7 for ; Fri, 13 Sep 2019 03:42:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FC4420684 for ; Fri, 13 Sep 2019 03:42:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ytq3+Gpv"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="iTlc+yhv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FC4420684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KOeL9X3vDSyfYAPuBKbWivRqvhFYWtn931Y9VwC7pPo=; b=Ytq3+GpvXkTh8g W2w+GCU2WAg7vUZCvbBC2hDnpV3LKUb5/yHR1B8JxIQKR/bxHxr0ftbdc9wMv37q7bMJ/30QSEXNr Gac2w6v6gx/qpnUtUXQnGT7BJ9JfzeBwtqYxjr8rUwPKNhoeRkcjMaR81QB8kR9IJGy7SDZx4dwVl 8RvB+fBCDsRj67SQal+G7bIN7WCYq7scBDleJ9jzIzErwWK1PxYbt6Fj91Xf0marBLMIyrCS8AKyA TKgn3jUrVgGaPC+x9S6sHefJmfv6Iin5wyrq3eDbzLWMYCICJRYM2sTE7/IRq+bUmPcw9nQGtNwRw 5x98T8JhISTksTnNtGcg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8cTb-0003ym-0M; Fri, 13 Sep 2019 03:42:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8cTY-0003yP-1W for linux-arm-kernel@lists.infradead.org; Fri, 13 Sep 2019 03:42:25 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 759EF20684; Fri, 13 Sep 2019 03:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568346143; bh=a4+pLs0HMpwthQVTXKUFl9IjvLrN/5bYwSFxfU5uDKw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iTlc+yhvbhgGcqvpGhGuRb8jZA11MoghlvglMSEwsgxqcp05bmmYUKE/J82jv2Buq pkUX/gLzFxBDpIjNUXXObPjP/a7HDnHC26YmztmstpVsv6dzCD2EJ3XkWgwe1+vVFo gn5lk9BdxbneE1Q+HqWQtNKWa8WvzoHclgfl9gLk= Date: Fri, 13 Sep 2019 11:42:14 +0800 From: Shawn Guo To: Anson Huang Subject: Re: [PATCH] clk: imx: lpcg: write twice when writing lpcg regs Message-ID: <20190913034213.GH17142@dragon> References: <1566936978-28519-1-git-send-email-peng.fan@nxp.com> <20190906172044.B99FB20838@mail.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190912_204224_105103_7DB43AA1 X-CRM114-Status: GOOD ( 14.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , Peng Fan , Dong Aisheng , Stephen Boyd , "mturquette@baylibre.com" , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Abel Vesa , dl-linux-imx , "kernel@pengutronix.de" , "festevam@gmail.com" , "s.hauer@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" , Jacky Bai Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 10, 2019 at 02:47:59AM +0000, Anson Huang wrote: > > > > On Sat, Sep 7, 2019 at 9:47 PM Stephen Boyd wrote: > > > > > > Quoting Peng Fan (2019-08-27 01:17:50) > > > > From: Peng Fan > > > > > > > > There is hardware issue that: > > > > The output clock the LPCG cell will not turn back on as expected, > > > > even though a read of the IPG registers in the LPCG indicates that > > > > the clock should be enabled. > > > > > > > > The software workaround is to write twice to enable the LPCG clock > > > > output. > > > > > > > > Signed-off-by: Peng Fan > > > > > > Does this need a Fixes tag? > > > > Not sure as it's not code logic issue but a hardware bug. > > And 4.19 LTS still have not this driver support. > > Looks like there is an errata for this issue, and Ranjani just sent a patch for review internally, Having errata number in both commit log and code comment is generally helpful. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel