* [PATCH] arm64: dts: ls1028a: fix a compatible issue
@ 2019-08-29 7:34 Yuantian Tang
2019-09-14 2:42 ` Shawn Guo
0 siblings, 1 reply; 4+ messages in thread
From: Yuantian Tang @ 2019-08-29 7:34 UTC (permalink / raw)
To: shawnguo
Cc: mark.rutland, devicetree, Yuantian Tang, leoyang.li, robh+dt,
linux-arm-kernel
The I2C multiplexer used on ls1028aqds is PCA9547, not PCA9847.
So correct it.
Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
index 5e14e5a19744..f5da9e8b0d9d 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
@@ -107,7 +107,7 @@
status = "okay";
i2c-mux@77 {
- compatible = "nxp,pca9847";
+ compatible = "nxp,pca9547";
reg = <0x77>;
#address-cells = <1>;
#size-cells = <0>;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: ls1028a: fix a compatible issue
2019-08-29 7:34 [PATCH] arm64: dts: ls1028a: fix a compatible issue Yuantian Tang
@ 2019-09-14 2:42 ` Shawn Guo
2019-09-24 8:00 ` [EXT] " Andy Tang
0 siblings, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2019-09-14 2:42 UTC (permalink / raw)
To: Yuantian Tang
Cc: mark.rutland, devicetree, robh+dt, linux-arm-kernel, leoyang.li
On Thu, Aug 29, 2019 at 03:34:39PM +0800, Yuantian Tang wrote:
> The I2C multiplexer used on ls1028aqds is PCA9547, not PCA9847.
> So correct it.
Can elaborate the fix a little bit, saying what's the issue exactly
with using that incorrect compatible?
>
> Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
Do we need a fix tag?
Shawn
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index 5e14e5a19744..f5da9e8b0d9d 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -107,7 +107,7 @@
> status = "okay";
>
> i2c-mux@77 {
> - compatible = "nxp,pca9847";
> + compatible = "nxp,pca9547";
> reg = <0x77>;
> #address-cells = <1>;
> #size-cells = <0>;
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix a compatible issue
2019-09-14 2:42 ` Shawn Guo
@ 2019-09-24 8:00 ` Andy Tang
2019-10-03 8:44 ` Shawn Guo
0 siblings, 1 reply; 4+ messages in thread
From: Andy Tang @ 2019-09-24 8:00 UTC (permalink / raw)
To: Shawn Guo; +Cc: mark.rutland, devicetree, robh+dt, linux-arm-kernel, Leo Li
Hi Shawn,
> -----Original Message-----
> From: Shawn Guo <shawnguo@kernel.org>
> Sent: 2019年9月14日 10:43
> To: Andy Tang <andy.tang@nxp.com>
> Cc: Leo Li <leoyang.li@nxp.com>; robh+dt@kernel.org;
> mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org
> Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix a compatible issue
>
> Caution: EXT Email
>
> On Thu, Aug 29, 2019 at 03:34:39PM +0800, Yuantian Tang wrote:
> > The I2C multiplexer used on ls1028aqds is PCA9547, not PCA9847.
> > So correct it.
>
> Can elaborate the fix a little bit, saying what's the issue exactly with using
> that incorrect compatible?
Ok.
>
> >
> > Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
>
> Do we need a fix tag?
What does "fix tag" mean?
BR,
Andy
>
> Shawn
>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > index 5e14e5a19744..f5da9e8b0d9d 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > @@ -107,7 +107,7 @@
> > status = "okay";
> >
> > i2c-mux@77 {
> > - compatible = "nxp,pca9847";
> > + compatible = "nxp,pca9547";
> > reg = <0x77>;
> > #address-cells = <1>;
> > #size-cells = <0>;
> > --
> > 2.17.1
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix a compatible issue
2019-09-24 8:00 ` [EXT] " Andy Tang
@ 2019-10-03 8:44 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2019-10-03 8:44 UTC (permalink / raw)
To: Andy Tang; +Cc: mark.rutland, devicetree, robh+dt, linux-arm-kernel, Leo Li
On Tue, Sep 24, 2019 at 08:00:29AM +0000, Andy Tang wrote:
> Hi Shawn,
>
>
> > -----Original Message-----
> > From: Shawn Guo <shawnguo@kernel.org>
> > Sent: 2019年9月14日 10:43
> > To: Andy Tang <andy.tang@nxp.com>
> > Cc: Leo Li <leoyang.li@nxp.com>; robh+dt@kernel.org;
> > mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> > devicetree@vger.kernel.org
> > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix a compatible issue
> >
> > Caution: EXT Email
> >
> > On Thu, Aug 29, 2019 at 03:34:39PM +0800, Yuantian Tang wrote:
> > > The I2C multiplexer used on ls1028aqds is PCA9547, not PCA9847.
> > > So correct it.
> >
> > Can elaborate the fix a little bit, saying what's the issue exactly with using
> > that incorrect compatible?
> Ok.
>
> >
> > >
> > > Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
> >
> > Do we need a fix tag?
> What does "fix tag" mean?
Please search 'Fixes' in Documentation/process/submitting-patches.rst.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-03 8:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-29 7:34 [PATCH] arm64: dts: ls1028a: fix a compatible issue Yuantian Tang
2019-09-14 2:42 ` Shawn Guo
2019-09-24 8:00 ` [EXT] " Andy Tang
2019-10-03 8:44 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).