From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C120C4CEC7 for ; Sun, 15 Sep 2019 18:52:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4149820830 for ; Sun, 15 Sep 2019 18:52:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SCa2paka" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4149820830 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: From:Subject:To:Message-Id:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l2FcQVyu3TSFDs+/0FttRCqMSg8icHFW4PKZ+QbleqE=; b=SCa2paka0kv+dQ Au6PJ0fqsw47z8UJ0oan6Yn7ACrcLuKInudJI2MZfmtMpO+NlwX1P8D6r5SaCl1ismu97b8BYK3/E qQUebijkGGncuoFVwsBkQ1WQZ8rQULgLhZxXlCc2Q6H1ZYfKrDcKTPdRyBiMFqEOiLR9Ot6TStcVe nG8LKUzPPRr+buqZgBDllXmqJBzHSPGU2icIxErvYXt/WF81K76BoTW3D7p2/E8w4RlHzC4+JG7iV m3QXmvhmGc4/GrDeIzZxcxlx6xv9YLBuWsyg4s0eKzLsR9Eq/bjXrbnePi/yq1g2v3PKqU6Lkjir4 AkdQ92qT9N0LI/FZzz0w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9Zcy-00007i-QE; Sun, 15 Sep 2019 18:52:04 +0000 Received: from shards.monkeyblade.net ([2620:137:e000::1:9]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9Zcv-000079-MQ for linux-arm-kernel@lists.infradead.org; Sun, 15 Sep 2019 18:52:03 +0000 Received: from localhost (93-63-141-166.ip28.fastwebnet.it [93.63.141.166]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 99A15153E82EC; Sun, 15 Sep 2019 11:51:50 -0700 (PDT) Date: Sun, 15 Sep 2019 19:51:49 +0100 (WEST) Message-Id: <20190915.195149.86866545205816280.davem@davemloft.net> To: alexandru.ardelean@analog.com Subject: Re: [PATCH v2] net: stmmac: socfpga: re-use the `interface` parameter from platform data From: David Miller In-Reply-To: <20190912132850.10585-1-alexandru.ardelean@analog.com> References: <20190912132850.10585-1-alexandru.ardelean@analog.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 15 Sep 2019 11:51:52 -0700 (PDT) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190915_115201_736635_F507CDFD X-CRM114-Status: UNSURE ( 7.26 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.torgue@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, peppe.cavallaro@st.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Alexandru Ardelean Date: Thu, 12 Sep 2019 16:28:50 +0300 > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > index c141fe783e87..5b6213207c43 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c ... > +static inline int socfpga_get_plat_phymode(struct socfpga_dwmac *dwmac) Please do not use the inline keyword in foo.c files, let the compiler device. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel