From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F6AAC4CECD for ; Tue, 17 Sep 2019 20:40:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20DC92054F for ; Tue, 17 Sep 2019 20:40:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o22NGcXf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="g19ToDQB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20DC92054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:From:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PgqZMnkw65Obh9GQUCCYzptp8pr68R5XU+PsZd9uTek=; b=o22NGcXfsN+Tj9 TDZg/ndrssL9F7Y7tcC6YMZgphfCet+IE/TidIYxrQRJGhTYrhRsNT4DocMP1s54+jgHWoKH9/BDO as53aOE5Ah2txT5x88gqLmZb2SUHAxKVgtJwCba4BVhoIC9xV9KlBki4OMwY9fGOczxPtOZWAOrJF C9VwSx6GsMQTjs9KJNfjIq8ewvZsxk31IEQfiUJtQz6jIsfwvER4ERq81wtiWem3goa9beBlXCpoq oTjFrebdv5WxxP2SZjXW5HkqEWbnJ1ZhZ2dh9suaE0XX0/q/xWpZTBrRXLUqOJiDZhlD+Eg9XAl25 ExNv3SjK1/cD+LE+MjtQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAKGX-0005U5-LU; Tue, 17 Sep 2019 20:40:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAKGU-0005TI-1u for linux-arm-kernel@lists.infradead.org; Tue, 17 Sep 2019 20:39:59 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9F75C2054F; Tue, 17 Sep 2019 20:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568752797; bh=t7XSIVvuIrJr+dTFLwJdB0q0iDWxPt3F88Tk1jyyAP8=; h=In-Reply-To:References:Cc:To:From:Subject:Date:From; b=g19ToDQBV751yjIEYkLnsdhOeu+FbOMz4i9GlEvIDjacEF61ADydYtjS3jv4EbPQK yuSedeuNiovoGkvFB2FoQ9Z/GOLlOG7GVDqXUq3zucvTxcc9MPx+72WE3CRQyXtexi 61n3o6OxehKUpmjDJ/QK50ACQS/HKJ6xld5MF0QY= MIME-Version: 1.0 In-Reply-To: <20190916161447.32715-2-manivannan.sadhasivam@linaro.org> References: <20190916161447.32715-1-manivannan.sadhasivam@linaro.org> <20190916161447.32715-2-manivannan.sadhasivam@linaro.org> To: Manivannan Sadhasivam , mturquette@baylibre.com, robh+dt@kernel.org From: Stephen Boyd Subject: Re: [PATCH v5 1/8] clk: Zero init clk_init_data in helpers User-Agent: alot/0.8.1 Date: Tue, 17 Sep 2019 13:39:56 -0700 Message-Id: <20190917203957.9F75C2054F@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190917_133958_361438_CBD64D2A X-CRM114-Status: GOOD ( 11.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Manivannan Sadhasivam , darren.tsao@bitmain.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, fisher.cheng@bitmain.com, alec.lin@bitmain.com, linux-clk@vger.kernel.org, haitao.suo@bitmain.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Manivannan Sadhasivam (2019-09-16 09:14:40) > The clk_init_data struct needs to be initialized to zero for the new > parent_map implementation to work correctly. Otherwise, the member which > is available first will get processed. > > Signed-off-by: Manivannan Sadhasivam > --- > drivers/clk/clk-composite.c | 2 +- > drivers/clk/clk-divider.c | 2 +- > drivers/clk/clk-fixed-rate.c | 2 +- > drivers/clk/clk-gate.c | 2 +- > drivers/clk/clk-mux.c | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c > index b06038b8f658..4d579f9d20f6 100644 > --- a/drivers/clk/clk-composite.c > +++ b/drivers/clk/clk-composite.c > @@ -208,7 +208,7 @@ struct clk_hw *clk_hw_register_composite(struct device *dev, const char *name, > unsigned long flags) > { > struct clk_hw *hw; > - struct clk_init_data init; > + struct clk_init_data init = { NULL }; I'd prefer { } because then we don't have to worry about ordering the struct to have a pointer vs. something else first. > struct clk_composite *composite; > struct clk_ops *clk_composite_ops; > int ret; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel