From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Gregory CLEMENT <gregory.clement@bootlin.com>
Cc: linux-kernel@vger.kernel.org,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Mark Brown <broonie@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] spi: atmel: Remove AVR32 leftover
Date: Thu, 19 Sep 2019 19:24:53 +0200 [thread overview]
Message-ID: <20190919172453.GA21254@piout.net> (raw)
In-Reply-To: <20190919154034.7489-1-gregory.clement@bootlin.com>
On 19/09/2019 17:40:34+0200, Gregory CLEMENT wrote:
> AV32 support has been from the kernel a few release ago, but there was
AVR32 and missing word^
> still some specific macro for this architecture in this driver. Lets
> remove it.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> ---
> drivers/spi/spi-atmel.c | 24 ------------------------
> 1 file changed, 24 deletions(-)
>
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index bb94f5927819..de1e1861a70c 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -222,37 +222,13 @@
> | SPI_BF(name, value))
>
> /* Register access macros */
> -#ifdef CONFIG_AVR32
> -#define spi_readl(port, reg) \
> - __raw_readl((port)->regs + SPI_##reg)
> -#define spi_writel(port, reg, value) \
> - __raw_writel((value), (port)->regs + SPI_##reg)
> -
> -#define spi_readw(port, reg) \
> - __raw_readw((port)->regs + SPI_##reg)
> -#define spi_writew(port, reg, value) \
> - __raw_writew((value), (port)->regs + SPI_##reg)
> -
> -#define spi_readb(port, reg) \
> - __raw_readb((port)->regs + SPI_##reg)
> -#define spi_writeb(port, reg, value) \
> - __raw_writeb((value), (port)->regs + SPI_##reg)
> -#else
> #define spi_readl(port, reg) \
> readl_relaxed((port)->regs + SPI_##reg)
> #define spi_writel(port, reg, value) \
> writel_relaxed((value), (port)->regs + SPI_##reg)
> -
> -#define spi_readw(port, reg) \
> - readw_relaxed((port)->regs + SPI_##reg)
> #define spi_writew(port, reg, value) \
> writew_relaxed((value), (port)->regs + SPI_##reg)
>
> -#define spi_readb(port, reg) \
> - readb_relaxed((port)->regs + SPI_##reg)
> -#define spi_writeb(port, reg, value) \
> - writeb_relaxed((value), (port)->regs + SPI_##reg)
> -#endif
> /* use PIO for small transfers, avoiding DMA setup/teardown overhead and
> * cache operations; better heuristics consider wordsize and bitrate.
> */
> --
> 2.23.0
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-19 17:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 15:40 [PATCH] spi: atmel: Remove AVR32 leftover Gregory CLEMENT
2019-09-19 17:24 ` Alexandre Belloni [this message]
2019-09-19 19:13 ` Thomas Petazzoni
2019-10-01 11:41 ` Applied "spi: atmel: Remove AVR32 leftover" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919172453.GA21254@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).