From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0065CC3A5A6 for ; Mon, 23 Sep 2019 09:18:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C52EB2064A for ; Mon, 23 Sep 2019 09:18:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GcDRTtAH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C52EB2064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Aru32Ixc+/Z3n8p+dzPd00UYAyawTQwxyF7rX1Pd6uU=; b=GcDRTtAHBWkjph O4Hkp5obm1BLTbz8r/jQdUDw5nkS8jcetZAFx1ohPZtK8gMfEGjtSyCz96DWPRIudBLVK1dYHpdsO oI2wLZ3CbLbjNWyu3+nR7mUy5Q8KhaCmHGjWBkyVs5vXwby2f1rrdivTORJVJaV86oI2N4GmiwhXh jh86YYbVK2E5TPQPanT1pHKGR+srO9GjW3XNssW64mgXQ6TOQ8RU4O5sGz2ohAgxEZXNrlZRin1Cv mR4UVllbGseCpCsMPcQZB7DKrg5XMJFEgbqYNZBilxf/WCrNIlE/n31a0hUwPonBfoblgTXqKgiXN NhmVrDoy1p8+nZO3eKag==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCKU8-0002vR-Ut; Mon, 23 Sep 2019 09:18:21 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCKTp-0002ht-4x for linux-arm-kernel@lists.infradead.org; Mon, 23 Sep 2019 09:18:03 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iCKTc-0005wP-Px; Mon, 23 Sep 2019 11:17:48 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1iCKTZ-0001wK-TP; Mon, 23 Sep 2019 11:17:45 +0200 Date: Mon, 23 Sep 2019 11:17:45 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Rasmus Villemoes , Russell King Subject: Re: [PATCH 1/4] pwm: mxs: implement ->apply Message-ID: <20190923091745.ehvz4zi2riyanmug@pengutronix.de> References: <20190923081348.6843-1-linux@rasmusvillemoes.dk> <20190923081348.6843-2-linux@rasmusvillemoes.dk> <20190923082459.huqpbz5eseonkscv@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190923_021801_204432_8692EBA0 X-CRM114-Status: GOOD ( 13.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, [expanded the recipents to include RMK and the clk list] On Mon, Sep 23, 2019 at 11:04:39AM +0200, Rasmus Villemoes wrote: > On 23/09/2019 10.24, Uwe Kleine-K=F6nig wrote: > > Also there is a bug already in .config: You are not supposed to call > > clk_get_rate if the clk might be off. > = > Interesting, I didn't know that. So the prepare_enable logic needs to be > moved before we start computing the period/duty cycles. Do you know why > it has apparently worked so far? I would have thought such a rule would > be enforced by the clock framework, or at least produced a warning. FTR: This is documented in the kerneldoc code comment to clk_get_rate in include/linux/clk.h. Assuming this is relevant, it might indeed make sense to add a WARN_ONCE for this. Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel