From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B0AFC432C1 for ; Tue, 24 Sep 2019 12:00:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F153F21655 for ; Tue, 24 Sep 2019 12:00:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ffQGPfWj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F153F21655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0uea/eSs88Un+Rbu3cXXEbIFxwsxReOATG3tHjYtzOU=; b=ffQGPfWjTyv+B3 w4CJHgTJHB1n8CrbV8VIZ5L+bq9TMsHffl7zQ2ko1wMcpYHSrEN1YT0Z6Xudn+J+BTjcMqeKmB7IT Un0lhMwPjC12TrMcwtZxl/JSZTnA9Sgiawq0rYd8vFx+hApM1V1HnHWKULumJuRYD0MX+WgqqQgOR U7UwXX8jGoas8FxNLmCia2x516GS+4h6g5MVNDRuliWF4F2i8nKFekawSTecGb53pwYzTcLJFqm+m OuxEBDryLsVX1R9OrtrC9O759j4ajDgqxiIUnbKAgwPQCYcGwz/yEEAHBAmOpquPLDJ9YwzpFA6ct IgX7uiUfoxbSt6cTrV1A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCjUh-0004nT-EO; Tue, 24 Sep 2019 12:00:35 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCjUd-0004n1-PK for linux-arm-kernel@lists.infradead.org; Tue, 24 Sep 2019 12:00:34 +0000 X-Originating-IP: 90.65.161.137 Received: from localhost (lfbn-1-1545-137.w90-65.abo.wanadoo.fr [90.65.161.137]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 5909A20018; Tue, 24 Sep 2019 12:00:19 +0000 (UTC) Date: Tue, 24 Sep 2019 14:00:18 +0200 From: Alexandre Belloni To: Eugen.Hristev@microchip.com Subject: Re: [PATCH] clk: at91: sam9x60: fix programmable clock Message-ID: <20190924120018.GA4757@piout.net> References: <1569321191-27606-1-git-send-email-eugen.hristev@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1569321191-27606-1-git-send-email-eugen.hristev@microchip.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190924_050031_972689_ACC5A41D X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sboyd@kernel.org, mturquette@baylibre.com, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/09/2019 10:39:09+0000, Eugen.Hristev@microchip.com wrote: > From: Eugen Hristev > > The prescaler mask for sam9x60 must be 0xff (8 bits). > Being set to 0, means that we cannot set any prescaler, thus the > programmable clocks do not work (except the case with prescaler 0) > Set the mask accordingly in layout struct. > > Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver") > Signed-off-by: Eugen Hristev Acked-by: Alexandre Belloni > --- > drivers/clk/at91/sam9x60.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c > index 9790ddf..86238d5 100644 > --- a/drivers/clk/at91/sam9x60.c > +++ b/drivers/clk/at91/sam9x60.c > @@ -43,6 +43,7 @@ static const struct clk_pll_characteristics upll_characteristics = { > }; > > static const struct clk_programmable_layout sam9x60_programmable_layout = { > + .pres_mask = 0xff, > .pres_shift = 8, > .css_mask = 0x1f, > .have_slck_mck = 0, > -- > 2.7.4 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel