From: Lee Jones <lee.jones@linaro.org>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: gene_chen@richtek.com, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
Wilma.Wu@mediatek.com, linux-arm-kernel@lists.infradead.org,
shufan_lee@richtek.com
Subject: Re: [PATCH] mfd: mt6360: add pmic mt6360 driver
Date: Tue, 24 Sep 2019 21:38:48 +0100 [thread overview]
Message-ID: <20190924203848.GC4469@dell> (raw)
In-Reply-To: <CAE+NS342Kn6OEz4D9Y0yfXStnW6KQ6N2yuQtgN2q2bXafofShg@mail.gmail.com>
On Tue, 24 Sep 2019, Gene Chen wrote:
> 2019-09-19 15:18 GMT+08:00, Lee Jones <lee.jones@linaro.org>:
> > On Thu, 19 Sep 2019, Gene Chen wrote:
> >
> >> Lee Jones <lee.jones@linaro.org> 於 2019年9月18日 週三 下午6:51寫道：
> >> >
> >> > On Wed, 18 Sep 2019, Gene Chen wrote:
> >> >
> >> > > From: Gene Chen <gene_chen@richtek.com>
> >> > >
> >> > > Add mfd driver for mt6360 pmic chip include
> >> > > Battery Charger/USB_PD/Flash LED/RGB LED/LDO/Buck
> >> > >
> >> > > Signed-off-by: Gene Chen <gene_chen@richtek.com
> >> > > ---
> >> >
> >> > This looks different from the one you sent before, but I don't see a
> >> > version bump or any changelog in this space. Please re-submit with
> >> > the differences noted.
> >> >
> >>
> >> the change is
> >> 1. add missing include file
> >> 2. modify commit message
> >>
> >> this patch is regarded as version 1
> >
> > It's different to the first one you sent to the list, so it needs a
> > version bump and a change log. There also appears to still be issues
> > with it, if the auto-builders are to be believed.
> >
> > Do ensure you thoroughly test your patches before sending upstream.
> >
> > Please fix the issues and resubmit your v3 with a nice changelog.
> >
>
> thank you for suggestion
> may i ask how to disable kbuild test reboot for s390/x86_64/ia64?
> we want support only cross compiler = aarch64-linux-gnu-
> and we have test build pass with our patch
You can't and we wouldn't want to.
If this driver should only be built/tested for AArch64, you need to
ensure the Kconfig represents that.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-24 20:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 10:15 [PATCH] mfd: mt6360: add pmic mt6360 driver Gene Chen
2019-09-18 10:51 ` Lee Jones
2019-09-19 2:20 ` Gene Chen
2019-09-19 7:18 ` Lee Jones
2019-09-24 15:34 ` Gene Chen
2019-09-24 20:38 ` Lee Jones [this message]
2019-09-18 19:18 ` kbuild test robot
2019-09-18 21:58 ` kbuild test robot
-- strict thread matches above, loose matches on Subject: below --
2019-09-18 9:55 Gene Chen
2019-09-18 14:10 ` kbuild test robot
2019-09-12 8:10 Gene Chen
2019-09-12 9:13 ` Matthias Brugger
2019-09-16 8:06 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190924203848.GC4469@dell \
--to=lee.jones@linaro.org \
--cc=Wilma.Wu@mediatek.com \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).