Re: [PATCH v6] gpio/mpc8xxx: change irq handler from chained to normal

From: kbuild test robot <lkp@intel.com>
To: Hui Song <hui.song_1@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Song Hui <hui.song_1@nxp.com>,
	linux-gpio@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-kernel@vger.kernel.org, Li Yang <leoyang.li@nxp.com>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	kbuild-all@01.org, Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6] gpio/mpc8xxx: change irq handler from chained to normal
Date: Fri, 27 Sep 2019 12:33:28 +0800	[thread overview]
Message-ID: <201909271214.EqPL1TAm%lkp@intel.com> (raw)
In-Reply-To: <20190927031551.20074-1-hui.song_1@nxp.com>

[-- Attachment #1: Type: text/plain, Size: 6313 bytes --]

Hi Hui,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on gpio/for-next]
[cannot apply to v5.3 next-20190925]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Hui-Song/gpio-mpc8xxx-change-irq-handler-from-chained-to-normal/20190927-113256
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:12:0,
                    from drivers/gpio/gpio-mpc8xxx.c:12:
   drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_gpio_irq_cascade':
>> include/linux/bitops.h:22:30: error: passing argument 1 of 'find_first_bit' from incompatible pointer type [-Werror=incompatible-pointer-types]
     for ((bit) = find_first_bit((addr), (size));  \
                                 ^
>> drivers/gpio/gpio-mpc8xxx.c:140:2: note: in expansion of macro 'for_each_set_bit'
     for_each_set_bit(i, &mask, 32)
     ^~~~~~~~~~~~~~~~
   In file included from arch/x86/include/asm/bitops.h:384:0,
                    from include/linux/bitops.h:19,
                    from include/linux/kernel.h:12,
                    from drivers/gpio/gpio-mpc8xxx.c:12:
   include/asm-generic/bitops/find.h:59:22: note: expected 'const long unsigned int *' but argument is of type 'unsigned int *'
    extern unsigned long find_first_bit(const unsigned long *addr,
                         ^~~~~~~~~~~~~~
   In file included from include/linux/kernel.h:12:0,
                    from drivers/gpio/gpio-mpc8xxx.c:12:
>> include/linux/bitops.h:24:29: error: passing argument 1 of 'find_next_bit' from incompatible pointer type [-Werror=incompatible-pointer-types]
          (bit) = find_next_bit((addr), (size), (bit) + 1))
                                ^
>> drivers/gpio/gpio-mpc8xxx.c:140:2: note: in expansion of macro 'for_each_set_bit'
     for_each_set_bit(i, &mask, 32)
     ^~~~~~~~~~~~~~~~
   In file included from arch/x86/include/asm/bitops.h:384:0,
                    from include/linux/bitops.h:19,
                    from include/linux/kernel.h:12,
                    from drivers/gpio/gpio-mpc8xxx.c:12:
   include/asm-generic/bitops/find.h:15:22: note: expected 'const long unsigned int *' but argument is of type 'unsigned int *'
    extern unsigned long find_next_bit(const unsigned long *addr, unsigned long
                         ^~~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from include/linux/kernel.h:12:0,
                    from drivers//gpio/gpio-mpc8xxx.c:12:
   drivers//gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_gpio_irq_cascade':
>> include/linux/bitops.h:22:30: error: passing argument 1 of 'find_first_bit' from incompatible pointer type [-Werror=incompatible-pointer-types]
     for ((bit) = find_first_bit((addr), (size));  \
                                 ^
   drivers//gpio/gpio-mpc8xxx.c:140:2: note: in expansion of macro 'for_each_set_bit'
     for_each_set_bit(i, &mask, 32)
     ^~~~~~~~~~~~~~~~
   In file included from arch/x86/include/asm/bitops.h:384:0,
                    from include/linux/bitops.h:19,
                    from include/linux/kernel.h:12,
                    from drivers//gpio/gpio-mpc8xxx.c:12:
   include/asm-generic/bitops/find.h:59:22: note: expected 'const long unsigned int *' but argument is of type 'unsigned int *'
    extern unsigned long find_first_bit(const unsigned long *addr,
                         ^~~~~~~~~~~~~~
   In file included from include/linux/kernel.h:12:0,
                    from drivers//gpio/gpio-mpc8xxx.c:12:
>> include/linux/bitops.h:24:29: error: passing argument 1 of 'find_next_bit' from incompatible pointer type [-Werror=incompatible-pointer-types]
          (bit) = find_next_bit((addr), (size), (bit) + 1))
                                ^
   drivers//gpio/gpio-mpc8xxx.c:140:2: note: in expansion of macro 'for_each_set_bit'
     for_each_set_bit(i, &mask, 32)
     ^~~~~~~~~~~~~~~~
   In file included from arch/x86/include/asm/bitops.h:384:0,
                    from include/linux/bitops.h:19,
                    from include/linux/kernel.h:12,
                    from drivers//gpio/gpio-mpc8xxx.c:12:
   include/asm-generic/bitops/find.h:15:22: note: expected 'const long unsigned int *' but argument is of type 'unsigned int *'
    extern unsigned long find_next_bit(const unsigned long *addr, unsigned long
                         ^~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/find_first_bit +22 include/linux/bitops.h

4677d4a53e0d56 Borislav Petkov 2010-05-03  14  
^1da177e4c3f41 Linus Torvalds  2005-04-16  15  /*
^1da177e4c3f41 Linus Torvalds  2005-04-16  16   * Include this here because some architectures need generic_ffs/fls in
^1da177e4c3f41 Linus Torvalds  2005-04-16  17   * scope
^1da177e4c3f41 Linus Torvalds  2005-04-16  18   */
^1da177e4c3f41 Linus Torvalds  2005-04-16 @19  #include <asm/bitops.h>
^1da177e4c3f41 Linus Torvalds  2005-04-16  20  
984b3f5746ed2c Akinobu Mita    2010-03-05  21  #define for_each_set_bit(bit, addr, size) \
3e037454bcfa4b Shannon Nelson  2007-10-16 @22  	for ((bit) = find_first_bit((addr), (size));		\
3e037454bcfa4b Shannon Nelson  2007-10-16  23  	     (bit) < (size);					\
3e037454bcfa4b Shannon Nelson  2007-10-16 @24  	     (bit) = find_next_bit((addr), (size), (bit) + 1))
3e037454bcfa4b Shannon Nelson  2007-10-16  25  

:::::: The code at line 22 was first introduced by commit
:::::: 3e037454bcfa4b187e8293d2121bd8c0f5a5c31c I/OAT: Add support for MSI and MSI-X

:::::: TO: Shannon Nelson <shannon.nelson@intel.com>
:::::: CC: Linus Torvalds <torvalds@woody.linux-foundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 68827 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel