From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B73FECE587 for ; Tue, 1 Oct 2019 13:26:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30DFD20815 for ; Tue, 1 Oct 2019 13:26:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UnKEBF/N"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="UXd0w/I5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30DFD20815 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h02Ntd/s4FkLjLcXXaDVuujiPgorsllBsNTOLsA+T8s=; b=UnKEBF/NG0NfOr 2fwQZSlmJx2sdgbVEf+opDIDvq9/64aRn1lQ8uTDDAEZ4dXNWGutq1Ef+NlaAp9FNiLBg5fmaeGgu EDBVtMKyiMdpcZNmVCwEB6OyF7tZezjkWJAgVWd3DzaZ5Tn6tobQMStv7PHPOKfGnsaGDId3cG/w/ DLTYrJ09PUTlzD9sG+Qrq2lHStfC00S3JeCme6+h+vM8v2BiquvbxwS/sGi/cwSnih1cBO65TNAaY aMpbMw5i1RqEVWu7Igb2AXRG0K29JOED5dSeAoUWbGoTqecoAy/sN9ZKVtPrqFzZxKgtbEHvPJl8Q LmUsjXkUNBz8FYSgFuxA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFIAx-0005qx-EK; Tue, 01 Oct 2019 13:26:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFIAv-0005qK-Dq for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2019 13:26:46 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9840D205F4; Tue, 1 Oct 2019 13:26:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569936405; bh=8AYODUkLIhWgx1CLwLKwmalHpwZd+Q1qNbypTTN8BA0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UXd0w/I5aELR21rcXWrbb71PaZrP98X1Anl3gA8DKH6zugoz0yNvo54azsQLSY/tg s7tggAZBvV8cfVt1IpjNFUUW3hGD8J4DUZ7gi3ZVQnyYnVx0l32rbxn0XfDYY3LIzZ z/K8THG6o5F+HXl8uDRmBicNsWl2C45WcZstVkig= Date: Tue, 1 Oct 2019 14:26:40 +0100 From: Will Deacon To: Vincenzo Frascino Subject: Re: [PATCH v3 2/5] arm64: vdso32: Detect binutils support for dmb ishld Message-ID: <20191001132640.plowjzi5nmajs72x@willie-the-truck> References: <20190920142738.qlsjwguc6bpnez63@willie-the-truck> <20190926214342.34608-1-vincenzo.frascino@arm.com> <20190926214342.34608-3-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190926214342.34608-3-vincenzo.frascino@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191001_062645_485648_F0FD109F X-CRM114-Status: GOOD ( 14.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ard.biesheuvel@linaro.org, catalin.marinas@arm.com, ndesaulniers@google.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 26, 2019 at 10:43:39PM +0100, Vincenzo Frascino wrote: > As reported by Will Deacon, older versions of binutils that do not > support certain types of memory barriers can cause build failure of the > vdso32 library. > > Add a compilation time mechanism that detects if binutils supports those > instructions and configure the kernel accordingly. > > Cc: Will Deacon > Cc: Catalin Marinas > Signed-off-by: Vincenzo Frascino > --- > arch/arm64/include/asm/vdso/compat_barrier.h | 2 +- > arch/arm64/kernel/vdso32/Makefile | 9 +++++++++ > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/vdso/compat_barrier.h b/arch/arm64/include/asm/vdso/compat_barrier.h > index fb60a88b5ed4..3fd8fd6d8fc2 100644 > --- a/arch/arm64/include/asm/vdso/compat_barrier.h > +++ b/arch/arm64/include/asm/vdso/compat_barrier.h > @@ -20,7 +20,7 @@ > > #define dmb(option) __asm__ __volatile__ ("dmb " #option : : : "memory") > > -#if __LINUX_ARM_ARCH__ >= 8 > +#if __LINUX_ARM_ARCH__ >= 8 && defined(CONFIG_AS_DMB_ISHLD) > #define aarch32_smp_mb() dmb(ish) > #define aarch32_smp_rmb() dmb(ishld) > #define aarch32_smp_wmb() dmb(ishst) > diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile > index 19e0d3115ffe..77aa61340374 100644 > --- a/arch/arm64/kernel/vdso32/Makefile > +++ b/arch/arm64/kernel/vdso32/Makefile > @@ -15,6 +15,8 @@ cc32-disable-warning = $(call try-run,\ > $(COMPATCC) -W$(strip $(1)) -c -x c /dev/null -o "$$TMP",-Wno-$(strip $(1))) > cc32-ldoption = $(call try-run,\ > $(COMPATCC) $(1) -nostdlib -x c /dev/null -o "$$TMP",$(1),$(2)) > +cc32-as-instr = $(call try-run,\ > + printf "%b\n" "$(1)" | $(COMPATCC) $(VDSO_AFLAGS) -c -x assembler -o "$$TMP" -,$(2),$(3)) It's a shame that we have to duplicate the logic from scripts/Kbuild.include here. Is there a way to reuse those helpers by temporarily overriding things like CC and KBUILD_AFLAGS? If not, no bother, but thought I'd better ask. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel