linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: ard.biesheuvel@linaro.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	ndesaulniers@google.com, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/5] arm64: vdso32: Introduce COMPAT_CC_IS_GCC
Date: Tue, 1 Oct 2019 15:20:38 +0100	[thread overview]
Message-ID: <20191001142038.ptwyfbesfrz3kkoz@willie-the-truck> (raw)
In-Reply-To: <ed7d1465-2d7b-d57c-c1b1-215af1ba7a6f@arm.com>

On Tue, Oct 01, 2019 at 03:20:35PM +0100, Vincenzo Frascino wrote:
> On 10/1/19 2:27 PM, Catalin Marinas wrote:
> > On Tue, Oct 01, 2019 at 02:14:23PM +0100, Will Deacon wrote:
> >> On Thu, Sep 26, 2019 at 10:43:38PM +0100, Vincenzo Frascino wrote:
> >>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> >>> index 37c610963eee..0e5beb928af5 100644
> >>> --- a/arch/arm64/Kconfig
> >>> +++ b/arch/arm64/Kconfig
> >>> @@ -110,7 +110,7 @@ config ARM64
> >>>  	select GENERIC_STRNLEN_USER
> >>>  	select GENERIC_TIME_VSYSCALL
> >>>  	select GENERIC_GETTIMEOFDAY
> >>> -	select GENERIC_COMPAT_VDSO if (!CPU_BIG_ENDIAN && COMPAT)
> >>> +	select GENERIC_COMPAT_VDSO if (!CPU_BIG_ENDIAN && COMPAT && COMPATCC_IS_ARM_GCC)
> >>>  	select HANDLE_DOMAIN_IRQ
> >>>  	select HARDIRQS_SW_RESEND
> >>>  	select HAVE_PCI
> >>> @@ -313,6 +313,9 @@ config KASAN_SHADOW_OFFSET
> >>>  	default 0xeffffff900000000 if ARM64_VA_BITS_36 && KASAN_SW_TAGS
> >>>  	default 0xffffffffffffffff
> >>>  
> >>> +config COMPATCC_IS_ARM_GCC
> >>> +	def_bool $(success,$(COMPATCC) --version | head -n 1 | grep -q "arm-.*-gcc")
> >>
> >> I've seen toolchains where the first part of the tuple is "armv7-", so they
> >> won't get detected here. However, do we really need to detect this? If
> >> somebody passes a duff compiler, then the build will fail in the same way as
> >> if they passed it to CROSS_COMPILE=.
> > 
> > Not sure what happens if we pass an aarch64 compiler. Can we end up with
> > a 64-bit compat vDSO?
> > 
> 
> I agree with Catalin here. The problem is not only when you pass and aarch64
> toolchain but even an x86 and so on.

I disagree. What happens if you do:

$ make ARCH=arm64 CROSS_COMPILE=x86_64-linux-gnu-

on your x86 box?

> If the problem is related to armv7- we can change the rule as "arm.*-gcc" which
> should detect them as well. Do you know what is the triple that an armv7-
> toolchain prints?

'fraid not, since I don't have one to hand. I think you'd end up matching
arm*-gcc, which is pretty broad.

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-10-01 14:20 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190920142738.qlsjwguc6bpnez63@willie-the-truck>
2019-09-26  6:03 ` [PATCH 0/4] arm64: vdso32: Address various issues Vincenzo Frascino
2019-09-26  6:03   ` [PATCH 1/4] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Vincenzo Frascino
2019-09-26  8:06     ` Catalin Marinas
2019-09-26 10:56       ` Vincenzo Frascino
2019-09-26 11:02         ` Vincenzo Frascino
2019-09-26 15:23           ` Catalin Marinas
2019-09-26 12:22         ` Vincenzo Frascino
2019-09-26 15:17           ` Catalin Marinas
2019-09-26 20:17             ` Vincenzo Frascino
2019-09-26  6:03   ` [PATCH 2/4] arm64: vdso32: Detect binutils support for dmb ishld Vincenzo Frascino
2019-09-26  8:30     ` Catalin Marinas
2019-09-26 10:59       ` Vincenzo Frascino
2019-09-26  6:03   ` [PATCH 3/4] arm64: vdso32: Fix compilation warning Vincenzo Frascino
2019-09-26  8:32     ` Catalin Marinas
2019-09-26 11:03       ` Vincenzo Frascino
2019-09-26  6:03   ` [PATCH 4/4] arm64: Remove gettimeofday.S Vincenzo Frascino
2019-09-26  8:34     ` Catalin Marinas
2019-09-26 13:38 ` [PATCH v2 0/4] arm64: vdso32: Address various issues Vincenzo Frascino
2019-09-26 13:38   ` [PATCH v2 1/4] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Vincenzo Frascino
2019-09-26 15:13     ` Catalin Marinas
2019-09-26 13:38   ` [PATCH v2 2/4] arm64: vdso32: Detect binutils support for dmb ishld Vincenzo Frascino
2019-09-26 14:26     ` Catalin Marinas
2019-09-26 20:19       ` Vincenzo Frascino
2019-09-26 15:59     ` Catalin Marinas
2019-09-26 21:17       ` Vincenzo Frascino
2019-09-26 16:23     ` Nick Desaulniers
2019-09-26 13:38   ` [PATCH v2 3/4] arm64: vdso32: Fix compilation warning Vincenzo Frascino
2019-09-26 15:22     ` Catalin Marinas
2019-09-26 13:38   ` [PATCH v2 4/4] arm64: Remove gettimeofday.S Vincenzo Frascino
2019-09-26 15:31   ` [PATCH v2 0/4] arm64: vdso32: Address various issues Catalin Marinas
2019-09-26 20:29     ` Vincenzo Frascino
2019-09-26 21:43 ` [PATCH v3 0/5]arm64: " Vincenzo Frascino
2019-09-26 21:43   ` [PATCH v3 1/5] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Vincenzo Frascino
2019-09-27  9:24     ` Catalin Marinas
2019-10-01 13:14     ` Will Deacon
2019-10-01 13:27       ` Catalin Marinas
2019-10-01 14:20         ` Vincenzo Frascino
2019-10-01 14:20           ` Will Deacon [this message]
2019-10-01 14:37             ` Vincenzo Frascino
2019-10-01 14:43               ` Will Deacon
2019-10-01 14:59                 ` Vincenzo Frascino
2019-10-01 15:30                 ` Catalin Marinas
2019-10-01 16:46                   ` Will Deacon
2019-10-01 16:59                     ` Nick Desaulniers
2019-10-01 17:07                       ` Will Deacon
2019-10-01 17:12                         ` Nick Desaulniers
2019-10-01 17:14                           ` Will Deacon
2019-09-26 21:43   ` [PATCH v3 2/5] arm64: vdso32: Detect binutils support for dmb ishld Vincenzo Frascino
2019-09-27  9:25     ` Catalin Marinas
2019-10-01 13:26     ` Will Deacon
2019-10-01 14:23       ` Vincenzo Frascino
2019-09-26 21:43   ` [PATCH v3 3/5] arm64: vdso32: Fix compilation warning Vincenzo Frascino
2019-09-27  9:26     ` Catalin Marinas
2019-10-01 13:21     ` Will Deacon
2019-10-01 14:41       ` Vincenzo Frascino
2019-09-26 21:43   ` [PATCH v3 4/5] arm64: Remove gettimeofday.S Vincenzo Frascino
2019-09-26 21:43   ` [PATCH v3 5/5] arm64: vdso32: Remove jump label config option in Makefile Vincenzo Frascino
2019-09-27  9:27     ` Catalin Marinas
2019-09-27 10:46   ` [PATCH v3 0/5]arm64: vdso32: Address various issues Catalin Marinas
2019-10-01 13:27   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191001142038.ptwyfbesfrz3kkoz@willie-the-truck \
    --to=will@kernel.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=tglx@linutronix.de \
    --cc=vincenzo.frascino@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).