From: Mike Rapoport <rppt@linux.ibm.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Adam Ford <aford173@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
The etnaviv authors <etnaviv@lists.freedesktop.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Fabio Estevam <festevam@gmail.com>,
Christoph Hellwig <hch@lst.de>,
arm-soc <linux-arm-kernel@lists.infradead.org>,
Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH v2 00/21] Refine memblock API
Date: Thu, 3 Oct 2019 14:30:10 +0300 [thread overview]
Message-ID: <20191003113010.GC23397@linux.ibm.com> (raw)
In-Reply-To: <20191003084914.GV25745@shell.armlinux.org.uk>
On Thu, Oct 03, 2019 at 09:49:14AM +0100, Russell King - ARM Linux admin wrote:
> On Thu, Oct 03, 2019 at 08:34:52AM +0300, Mike Rapoport wrote:
> > (trimmed the CC)
> >
> > On Wed, Oct 02, 2019 at 06:14:11AM -0500, Adam Ford wrote:
> > > On Wed, Oct 2, 2019 at 2:36 AM Mike Rapoport <rppt@linux.ibm.com> wrote:
> > > >
> > >
> > > Before the patch:
> > >
> > > # cat /sys/kernel/debug/memblock/memory
> > > 0: 0x10000000..0x8fffffff
> > > # cat /sys/kernel/debug/memblock/reserved
> > > 0: 0x10004000..0x10007fff
> > > 34: 0x2fffff88..0x3fffffff
> > >
> > >
> > > After the patch:
> > > # cat /sys/kernel/debug/memblock/memory
> > > 0: 0x10000000..0x8fffffff
> > > # cat /sys/kernel/debug/memblock/reserved
> > > 0: 0x10004000..0x10007fff
> > > 36: 0x80000000..0x8fffffff
> >
> > I'm still not convinced that the memblock refactoring didn't uncovered an
> > issue in etnaviv driver.
> >
> > Why moving the CMA area from 0x80000000 to 0x30000000 makes it fail?
>
> I think you have that the wrong way round.
I'm relying on Adam's reports of working and non-working versions.
According to that etnaviv works when CMA area is at 0x80000000 and does not
work when it is at 0x30000000.
He also sent logs a few days ago [1], they also confirm that.
[1] https://lore.kernel.org/linux-mm/CAHCN7xJEvS2Si=M+BYtz+kY0M4NxmqDjiX9Nwq6_3GGBh3yg=w@mail.gmail.com/
> > BTW, the code that complained about "command buffer outside valid memory
> > window" has been removed by the commit 17e4660ae3d7 ("drm/etnaviv:
> > implement per-process address spaces on MMUv2").
> >
> > Could be that recent changes to MMU management of etnaviv resolve the
> > issue?
>
> The iMX6 does not have MMUv2 hardware, it has MMUv1. With MMUv1
> hardware requires command buffers within the first 2GiB of physical
> RAM.
I've mentioned that patch because it removed the check for cmdbuf address
for MMUv1:
@@ -785,15 +768,7 @@ int etnaviv_gpu_init(struct etnaviv_gpu *gpu)
PAGE_SIZE);
if (ret) {
dev_err(gpu->dev, "could not create command buffer\n");
- goto unmap_suballoc;
- }
-
- if (!(gpu->identity.minor_features1 & chipMinorFeatures1_MMU_VERSION) &&
- etnaviv_cmdbuf_get_va(&gpu->buffer, &gpu->cmdbuf_mapping) > 0x80000000) {
- ret = -EINVAL;
- dev_err(gpu->dev,
- "command buffer outside valid memory window\n");
- goto free_buffer;
+ goto fail;
}
/* Setup event management */
I really don't know how etnaviv works, so I hoped that people who
understand it would help.
> I've reported the problem previously but there was no resolution,
> other than pointing the blame at CMA.
>
> https://lists.freedesktop.org/archives/dri-devel/2019-June/thread.html#223516
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
> According to speedtest.net: 11.9Mbps down 500kbps up
--
Sincerely yours,
Mike.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-03 11:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHCN7xJdzEppn8-74SvzACsA25bUHGdV7v=CfS08xzSi59Z2uw@mail.gmail.com>
[not found] ` <CAOMZO5D2uzR6Sz1QnX3G-Ce_juxU-0PO_vBZX+nR1mpQB8s8-w@mail.gmail.com>
[not found] ` <CAHCN7xJ32BYZu-DVTVLSzv222U50JDb8F0A_tLDERbb8kPdRxg@mail.gmail.com>
[not found] ` <20190926160433.GD32311@linux.ibm.com>
[not found] ` <CAHCN7xL1sFXDhKUpj04d3eDZNgLA1yGAOqwEeCxedy1Qm-JOfQ@mail.gmail.com>
[not found] ` <20190928073331.GA5269@linux.ibm.com>
[not found] ` <CAHCN7xJEvS2Si=M+BYtz+kY0M4NxmqDjiX9Nwq6_3GGBh3yg=w@mail.gmail.com>
[not found] ` <CAHCN7xKLhWw4P9-sZKXQcfSfh2r3J_+rLxuxACW0UVgimCzyVw@mail.gmail.com>
[not found] ` <20191002073605.GA30433@linux.ibm.com>
[not found] ` <CAHCN7xL1MkJh44N3W_1+08DHmX__SqnfH6dqUzYzr2Wpg0kQyQ@mail.gmail.com>
2019-10-03 5:34 ` [PATCH v2 00/21] Refine memblock API Mike Rapoport
2019-10-03 8:49 ` Russell King - ARM Linux admin
2019-10-03 11:30 ` Mike Rapoport [this message]
2019-10-03 13:17 ` Lucas Stach
2019-10-04 9:27 ` Russell King - ARM Linux admin
2019-10-04 13:21 ` Lucas Stach
2019-10-04 13:58 ` Adam Ford
2019-10-04 17:10 ` Mike Rapoport
2019-10-04 17:29 ` Mike Rapoport
2019-10-03 14:46 ` Chris Healy
2019-10-04 9:12 ` Russell King - ARM Linux admin
2019-01-21 8:03 Mike Rapoport
[not found] ` <CAHCN7x+Jv7yGPoB0Gm=TJ30ObLJduw2XomHkd++KqFEURYQcGg@mail.gmail.com>
2019-09-25 6:42 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191003113010.GC23397@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=aford173@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=etnaviv@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=hch@lst.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).