From: Catalin Marinas <catalin.marinas@arm.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: ard.biesheuvel@linaro.org, ndesaulniers@google.com,
linux-kernel@vger.kernel.org, luto@kernel.org,
tglx@linutronix.de, will@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/6] arm64: vdso32: Fix syncconfig errors.
Date: Thu, 3 Oct 2019 17:00:41 +0100 [thread overview]
Message-ID: <20191003160041.GI21629@arrakis.emea.arm.com> (raw)
In-Reply-To: <20191002144156.2174-2-vincenzo.frascino@arm.com>
On Wed, Oct 02, 2019 at 03:41:51PM +0100, Vincenzo Frascino wrote:
> Cc: Will Deacon <will@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Reported-by: Will Deacon <will@kernel.org>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
> Tested-by: Catalin Marinas <catalin.marinas@arm.com>
If you changed the patch, please drop my reviewed/tested-by.
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index 84a3d502c5a5..dfa6a5cb99e4 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -53,20 +53,12 @@ $(warning Detected assembler with broken .inst; disassembly will be unreliable)
> endif
> endif
>
> +COMPATCC ?= $(CROSS_COMPILE_COMPAT)gcc
> +export COMPATCC
> +
> ifeq ($(CONFIG_GENERIC_COMPAT_VDSO), y)
> - CROSS_COMPILE_COMPAT ?= $(CONFIG_CROSS_COMPILE_COMPAT_VDSO:"%"=%)
> -
> - ifeq ($(CONFIG_CC_IS_CLANG), y)
> - $(warning CROSS_COMPILE_COMPAT is clang, the compat vDSO will not be built)
> - else ifeq ($(strip $(CROSS_COMPILE_COMPAT)),)
> - $(warning CROSS_COMPILE_COMPAT not defined or empty, the compat vDSO will not be built)
> - else ifeq ($(shell which $(CROSS_COMPILE_COMPAT)gcc 2> /dev/null),)
> - $(error $(CROSS_COMPILE_COMPAT)gcc not found, check CROSS_COMPILE_COMPAT)
> - else
> - export CROSS_COMPILE_COMPAT
> - export CONFIG_COMPAT_VDSO := y
> - compat_vdso := -DCONFIG_COMPAT_VDSO=1
> - endif
> + export CONFIG_COMPAT_VDSO := y
> + compat_vdso := -DCONFIG_COMPAT_VDSO=1
> endif
With this change, if I don't have any CROSS_COMPILE_COMPAT in my
environment, the kernel fails to build because COMPATCC becomes gcc
which cannot build the vdso32. What I really want is not to warn me, nor
fail to build the kernel when I don't care about the compat vDSO (e.g. I
have a 64-bit only machine).
What saved us before was the COMPATCC_IS_ARM_GCC check and a selection
of the GENERIC_COMPAT_VDSO dependent on this check. This was now dropped
from the previous version of the patch. We could add something like
COMPATCC_CAN_LINK.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-03 16:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 14:41 [PATCH v4 0/6] arm64: vdso32: Address various issues Vincenzo Frascino
2019-10-02 14:41 ` [PATCH v4 1/6] arm64: vdso32: Fix syncconfig errors Vincenzo Frascino
2019-10-03 16:00 ` Catalin Marinas [this message]
2019-10-03 16:16 ` Catalin Marinas
2019-10-03 17:03 ` Vincenzo Frascino
2019-10-03 17:40 ` Vincenzo Frascino
2019-10-03 16:20 ` Vincenzo Frascino
2019-10-02 14:41 ` [PATCH v4 2/6] arm64: vdso32: Detect binutils support for dmb ishld Vincenzo Frascino
2019-10-02 14:41 ` [PATCH v4 3/6] arm64: Remove gettimeofday.S Vincenzo Frascino
2019-10-02 14:41 ` [PATCH v4 4/6] arm64: vdso32: Remove jump label config option in Makefile Vincenzo Frascino
2019-10-02 14:41 ` [PATCH v4 5/6] arm64: Remove vdso_datapage.h Vincenzo Frascino
2019-10-02 14:41 ` [PATCH v4 6/6] lib: vdso: Remove CROSS_COMPILE_COMPAT_VDSO Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191003160041.GI21629@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=ndesaulniers@google.com \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).